fix: Use localized message for split requests in LHN #29263

paultsimura · 2023-10-11T07:44:35Z

Details

Display a properly localized split {amount} for {description} message in LHN for group chats with a split bill as the last message.

Fixed Issues

$ #26020
PROPOSAL: #26020 (comment)

Tests

Open any group chat
Click "+" -> "Split Bill"
Enter the amount and description
Submit the request

Verify that in LHN, the last message for this group chat is displayed as split {amount} for {description}

Change language to Spanish

Verify that the message is properly translated

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message: https://expensify.slack.com/archives/C01GTK53T8Q/p1697025563427089
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

split-android.mov

Android: mWeb Chrome

chrome.mov

iOS: Native

iOS.mov

iOS: mWeb Safari

safari.MP4

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

Signed-off-by: Pavlo Tsimura <[email protected]>

melvin-bot · 2023-10-11T07:44:41Z

@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

paultsimura · 2023-10-11T09:11:13Z

src/languages/es.ts

@@ -526,7 +526,7 @@ export default {
        payElsewhere: 'Pagar de otra forma',
        requestAmount: ({amount}: RequestAmountParams) => `solicitar ${amount}`,
        requestedAmount: ({formattedAmount, comment}: RequestedAmountMessageParams) => `solicité ${formattedAmount}${comment ? ` para ${comment}` : ''}`,
-        splitAmount: ({amount}: SplitAmountParams) => `dividir ${amount}`,
+        splitAmount: ({amount, comment}: SplitAmountParams) => `dividir ${amount}${comment ? ` para ${comment}` : ''}`,


@aimane-chnaif I have modified this copy, but the format is identical to the already existing one above, requestedAmount.
Should I still request the translation approval here?

yes, please request. it's same split in English for both present and past form but might be different in Spanish.
We should use present form in confirmation screen and past form in report action, similar to request, requested

That's a great catch! Thanks.

aimane-chnaif · 2023-10-11T13:41:43Z

@paultsimura let me know when ready for review

paultsimura · 2023-10-11T13:44:11Z

@aimane-chnaif it's ready. I'm using the suggested didSplitAmount as a key for now.

src/languages/en.ts

src/languages/es.ts

src/languages/types.ts

src/libs/ReportUtils.js

Co-authored-by: Aimane Chnaif <[email protected]>

paultsimura · 2023-10-11T16:14:28Z

Thanks @aimane-chnaif, ready for re-review.

aimane-chnaif · 2023-10-12T15:45:01Z

@paultsimura please pull main. The branch is 1130 commits behind

paultsimura · 2023-10-12T16:02:34Z

@aimane-chnaif done. Merged and re-tested.

src/libs/ReportUtils.js

Co-authored-by: Aimane Chnaif <[email protected]>

aimane-chnaif · 2023-10-12T18:43:12Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web1.mov

Mobile Web - Chrome

mchrome.mov

Mobile Web - Safari

msafari.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

aimane-chnaif

LGTM 🎉

OSBotify · 2023-10-13T01:28:34Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-10-13T21:11:43Z

🚀 Deployed to staging by https://github.com/robertjchen in version: 1.3.84-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-16T21:12:17Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.84-10 🚀

platform	result
🤖 android 🤖	skipped 🚫
🖥 desktop 🖥	skipped 🚫
🍎 iOS 🍎	skipped 🚫
🕸 web 🕸	skipped 🚫

OSBotify · 2023-10-16T21:48:37Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.84-10 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-10-16T21:51:33Z

🚀 Deployed to staging by https://github.com/robertjchen in version: 1.3.85-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-17T23:16:18Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.85-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

paultsimura added 2 commits October 11, 2023 09:28

Use localized message for split request

639be9d

Signed-off-by: Pavlo Tsimura <[email protected]>

Add explanatory comment

852bcab

paultsimura requested a review from a team as a code owner October 11, 2023 07:44

melvin-bot bot requested review from aimane-chnaif and removed request for a team October 11, 2023 07:44

Prettier

4f1af36

paultsimura commented Oct 11, 2023

View reviewed changes

Separate splitAmount copy to present and past form

a5e4be2

aimane-chnaif reviewed Oct 11, 2023

View reviewed changes

DidSplitAmountParams message formatting

23caa82

Co-authored-by: Aimane Chnaif <[email protected]>

paultsimura requested a review from aimane-chnaif October 11, 2023 16:08

Merge branch 'main' into fix/26020-group-split-LHN

0839bd3

aimane-chnaif reviewed Oct 12, 2023

View reviewed changes

src/libs/ReportUtils.js Show resolved Hide resolved

Early return if the linked transaction is not found

b948d74

Co-authored-by: Aimane Chnaif <[email protected]>

paultsimura requested a review from aimane-chnaif October 12, 2023 18:35

aimane-chnaif approved these changes Oct 12, 2023

View reviewed changes

melvin-bot bot requested a review from robertjchen October 12, 2023 18:44

robertjchen approved these changes Oct 13, 2023

View reviewed changes

robertjchen merged commit ca5127f into Expensify:main Oct 13, 2023

OSBotify mentioned this pull request Oct 13, 2023

Deploy Checklist: New Expensify 2023-10-13 #29585

Closed

97 tasks

lanitochka17 mentioned this pull request Oct 16, 2023

[HOLD for payment 2023-10-24] [HOLD for payment 2023-10-23] Split bill - App crashes when opening bill split preview #29679

Closed

6 tasks

aimane-chnaif mentioned this pull request Oct 16, 2023

[HOLD for payment 2023-10-23][$1000] IOU - When performing an invoice division in a group, the amount of this is set to zero #26020

Closed

5 tasks

OSBotify mentioned this pull request Oct 16, 2023

Deploy Checklist: New Expensify 2023-10-16 #29717

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Use localized message for split requests in LHN #29263

fix: Use localized message for split requests in LHN #29263

paultsimura commented Oct 11, 2023 •

edited

Loading

melvin-bot bot commented Oct 11, 2023

paultsimura Oct 11, 2023 •

edited

Loading

aimane-chnaif Oct 11, 2023 •

edited

Loading

paultsimura Oct 11, 2023

aimane-chnaif commented Oct 11, 2023

paultsimura commented Oct 11, 2023

paultsimura commented Oct 11, 2023

aimane-chnaif commented Oct 12, 2023

paultsimura commented Oct 12, 2023

aimane-chnaif commented Oct 12, 2023

aimane-chnaif left a comment

OSBotify commented Oct 13, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 16, 2023

OSBotify commented Oct 16, 2023

OSBotify commented Oct 16, 2023

OSBotify commented Oct 17, 2023

fix: Use localized message for split requests in LHN #29263

fix: Use localized message for split requests in LHN #29263

Conversation

paultsimura commented Oct 11, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Oct 11, 2023

paultsimura Oct 11, 2023 • edited Loading

Choose a reason for hiding this comment

aimane-chnaif Oct 11, 2023 • edited Loading

Choose a reason for hiding this comment

paultsimura Oct 11, 2023

Choose a reason for hiding this comment

aimane-chnaif commented Oct 11, 2023

paultsimura commented Oct 11, 2023

paultsimura commented Oct 11, 2023

aimane-chnaif commented Oct 12, 2023

paultsimura commented Oct 12, 2023

aimane-chnaif commented Oct 12, 2023

Reviewer Checklist

Screenshots/Videos

aimane-chnaif left a comment

Choose a reason for hiding this comment

OSBotify commented Oct 13, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 16, 2023

OSBotify commented Oct 16, 2023

OSBotify commented Oct 16, 2023

OSBotify commented Oct 17, 2023

paultsimura commented Oct 11, 2023 •

edited

Loading

paultsimura Oct 11, 2023 •

edited

Loading

aimane-chnaif Oct 11, 2023 •

edited

Loading