Add join and leave to user created rooms #28408

srikarparsi · 2023-09-28T17:46:29Z

Details

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/318329
PROPOSAL:

Tests

Create a room - (Global Create -> Send Message -> Room -> Create Room)
Copy the share code - (Click on room name -> Share Code -> Copy URL to Clipboard)
Leave the room - (Click on the three dots and ensure that leave room shows up)
Re-join the room - (Paste the share url into the browser)
Ensure leave room shows in the three dots menu

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
  - Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-10-16.at.9.56.14.PM.mov

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

cloudflare-workers-and-pages · 2023-10-10T05:39:03Z

Deploying with Cloudflare Pages

Latest commit:	`4ba83a2`
Status:	✅ Deploy successful!
Preview URL:	https://ec1d8e97.helpdot.pages.dev
Branch Preview URL:	https://srikar-joinleaveusercreatedr.helpdot.pages.dev

View logs

melvin-bot · 2023-10-10T06:29:46Z

@ArekChr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

srikarparsi · 2023-10-10T06:35:05Z

Hi @ArekChr! Wasn't able to run through the tests myself because I'm having some difficulty with my dev server but I'll go through them and specify more if needed tomorrow. In the meanwhile, please feel free to look over the code and test any flows you feel are necessary.

ArekChr · 2023-10-11T10:12:45Z

@srikarparsi Could you provide more detailed QA steps? By creating room you mean create group/workspace?

…/Expensify/App into srikar-joinLeaveUserCreatedRooms pull origin

srikarparsi · 2023-10-12T02:42:46Z

Hi @ArekChr, just updated the test steps. By room I mean a user created room under a workspace.

ArekChr · 2023-10-12T11:37:59Z

@srikarparsi Thanks! Reviewing

ArekChr · 2023-10-12T13:09:57Z

@srikarparsi I still don't know if I'm following the QA steps correctly, by global create, do you mean the fab plus button? I don't see there is a Room option.

srikarparsi · 2023-10-12T21:17:03Z

Hey yeah, I wrote it in the testing steps but to create a room, you have to use the send message flow. I videod it in case that helps:

Screen.Recording.2023-10-12.at.5.15.53.PM.mov

ArekChr · 2023-10-13T08:37:49Z

@srikarparsi I don't have this option while creating the message. Do I need any specific permissions for that?

srikarparsi · 2023-10-13T18:55:21Z

Hm yeah you might need to be under the beta. But I think you should be able to set this line to true to quickly access it: https://github.com/Expensify/App/blob/main/src/pages/workspace/WorkspaceNewRoomPage.js#L165

ArekChr · 2023-10-16T11:35:32Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

mweb.chrome.mov

Mobile Web - Safari

mweb.safari.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

ArekChr · 2023-10-16T11:36:59Z

@srikarparsi Check mobile platforms, after leaving a room it navigates to Concierge chat, but it could navigate to all chat screens, wdyt?

srikarparsi · 2023-10-17T01:38:08Z

Ah thanks! Not sure if this is expected behavior since it occurs on main but I made a bug report for it here. I think it's expected but either way I think this should be handled in a follow up issue since it currently occurs on main.

OSBotify · 2023-10-19T08:58:46Z

🧪🧪 Use the links below to test this build in android and iOS. Happy testing! 🧪🧪

android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/28408/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/28408/index.html

desktop 💻	web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/28408/NewExpensify.dmg	https://28408.pr-testing.expensify.com

srikarparsi · 2023-10-19T08:59:43Z

Yeah so this is the error I'm getting but I haven't investigated it yet so it's all good if you don't know off the top of your head:

FAILURE: Build failed with an exception.

Where:
Build file '/Users/srikarparsi/Expensidev/App/node_modules/react-native/build.gradle.kts' line: 13

What went wrong:
Plugin [id: 'de.undercouch.download', version: '5.0.1', apply: false] was not found in any of the following sources:

Gradle Core Plugins (plugin is not in 'org.gradle' namespace)

Included Builds (None of the included builds contain this plugin)

Plugin Repositories (could not resolve plugin artifact 'de.undercouch.download:de.undercouch.download.gradle.plugin:5.0.1')
Searched in the following repositories:
MavenRepo
Google
Gradle Central Plugin Repository

Also, the test build just came up so I'll just run that tomorrow on an android and add in that screenshot :)

merge main

jasperhuangg · 2023-10-27T20:23:09Z

@srikarparsi conflicts

…/Expensify/App into srikar-joinLeaveUserCreatedRooms merge conflicts

jasperhuangg · 2023-10-30T20:19:30Z

@srikarparsi more conflicts 😓

jasperhuangg · 2023-10-30T20:19:47Z

DM me when you fix them so we can get this merged before they happen again

jasperhuangg · 2023-11-08T22:50:59Z

bump @srikarparsi what's the status on this one?

srikarparsi · 2023-11-09T08:48:08Z

Hey @jasperhuangg! Sorry for the delay, I've been caught up with a bunch of other things but will resolve conflicts tomorrow and ping you once it's ready so that we don't run into more conflicts.

srikarparsi · 2023-11-10T07:18:05Z

Hey @jasperhuangg, resolved conflicts and tested again and works well so this is ready for review whenever you get a chance :)

merge main

jasperhuangg · 2023-11-15T21:52:50Z

@srikarparsi ah linter is failing, do you mind updating with npm run prettier

srikarparsi · 2023-11-17T01:00:12Z

Hey @jasperhuangg! Just did :)

OSBotify · 2023-11-17T20:38:24Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-11-22T00:49:06Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.4.1-13 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

add join and leave for user created rooms

bf9aaac

srikarparsi self-assigned this Sep 28, 2023

Merge branch 'main' into srikar-joinLeaveUserCreatedRooms

aa228cc

srikarparsi and others added 3 commits October 10, 2023 02:15

remove uneeded dependencies

a1c66ea

fix merge conflict

ea034e6

Delete uneeded file

53791e0

srikarparsi marked this pull request as ready for review October 10, 2023 06:29

srikarparsi requested a review from a team as a code owner October 10, 2023 06:29

melvin-bot bot requested review from ArekChr and removed request for a team October 10, 2023 06:29

srikarparsi and others added 3 commits October 11, 2023 20:42

Merge branch 'main' into srikar-joinLeaveUserCreatedRooms

f89d2fd

merge main

60c2536

Merge branch 'srikar-joinLeaveUserCreatedRooms' of https://github.com…

0782b2d

…/Expensify/App into srikar-joinLeaveUserCreatedRooms pull origin

srikarparsi added 2 commits October 11, 2023 22:59

unused dependencies

d115aec

prettier

154cc7f

resolve merge conflicts

15056e3

srikarparsi added the Ready To Build label Oct 17, 2023

merge conflicts

bf02bf5

srikarparsi and others added 3 commits October 19, 2023 05:03

prettier

4ba83a2

Merge branch 'main' into srikar-joinLeaveUserCreatedRooms

8327374

merge main

Merge branch 'main' into srikar-joinLeaveUserCreatedRooms

ea24992

jasperhuangg previously approved these changes Oct 27, 2023

View reviewed changes

srikarparsi added 2 commits October 27, 2023 17:05

resolve conflicts

1dcd567

Merge branch 'srikar-joinLeaveUserCreatedRooms' of https://github.com…

226dbcf

…/Expensify/App into srikar-joinLeaveUserCreatedRooms merge conflicts

srikarparsi dismissed jasperhuangg’s stale review via 226dbcf October 27, 2023 21:06

srikarparsi added 2 commits November 10, 2023 01:53

resolve conflicts

a6271a1

cleanup changes

d03cad9

Merge branch 'main' into srikar-joinLeaveUserCreatedRooms

d72155c

merge main

jasperhuangg previously approved these changes Nov 15, 2023

View reviewed changes

prettier

b957028

srikarparsi dismissed jasperhuangg’s stale review via b957028 November 17, 2023 00:59

jasperhuangg approved these changes Nov 17, 2023

View reviewed changes

jasperhuangg merged commit 3f7e66a into main Nov 17, 2023

jasperhuangg deleted the srikar-joinLeaveUserCreatedRooms branch November 17, 2023 20:34

os-botify bot mentioned this pull request Nov 20, 2023

Deploy Checklist: New Expensify 2023-11-20 #31556

Closed

90 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add join and leave to user created rooms #28408

Add join and leave to user created rooms #28408

srikarparsi commented Sep 28, 2023 •

edited by jasperhuangg

Loading

cloudflare-workers-and-pages bot commented Oct 10, 2023 •

edited

Loading

melvin-bot bot commented Oct 10, 2023

srikarparsi commented Oct 10, 2023

ArekChr commented Oct 11, 2023

srikarparsi commented Oct 12, 2023

ArekChr commented Oct 12, 2023

ArekChr commented Oct 12, 2023

srikarparsi commented Oct 12, 2023

ArekChr commented Oct 13, 2023

srikarparsi commented Oct 13, 2023

ArekChr commented Oct 16, 2023 •

edited by jasperhuangg

Loading

ArekChr commented Oct 16, 2023

srikarparsi commented Oct 17, 2023 •

edited

Loading

OSBotify commented Oct 19, 2023

srikarparsi commented Oct 19, 2023

jasperhuangg commented Oct 27, 2023

jasperhuangg commented Oct 30, 2023

jasperhuangg commented Oct 30, 2023

jasperhuangg commented Nov 8, 2023

srikarparsi commented Nov 9, 2023

srikarparsi commented Nov 10, 2023

jasperhuangg commented Nov 15, 2023

srikarparsi commented Nov 17, 2023

OSBotify commented Nov 17, 2023

OSBotify commented Nov 22, 2023

Add join and leave to user created rooms #28408

Add join and leave to user created rooms #28408

Conversation

srikarparsi commented Sep 28, 2023 • edited by jasperhuangg Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

cloudflare-workers-and-pages bot commented Oct 10, 2023 • edited Loading

Deploying with Cloudflare Pages

melvin-bot bot commented Oct 10, 2023

srikarparsi commented Oct 10, 2023

ArekChr commented Oct 11, 2023

srikarparsi commented Oct 12, 2023

ArekChr commented Oct 12, 2023

ArekChr commented Oct 12, 2023

srikarparsi commented Oct 12, 2023

ArekChr commented Oct 13, 2023

srikarparsi commented Oct 13, 2023

ArekChr commented Oct 16, 2023 • edited by jasperhuangg Loading

Reviewer Checklist

Screenshots/Videos

ArekChr commented Oct 16, 2023

srikarparsi commented Oct 17, 2023 • edited Loading

OSBotify commented Oct 19, 2023

srikarparsi commented Oct 19, 2023

jasperhuangg commented Oct 27, 2023

jasperhuangg commented Oct 30, 2023

jasperhuangg commented Oct 30, 2023

jasperhuangg commented Nov 8, 2023

srikarparsi commented Nov 9, 2023

srikarparsi commented Nov 10, 2023

jasperhuangg commented Nov 15, 2023

srikarparsi commented Nov 17, 2023

OSBotify commented Nov 17, 2023

OSBotify commented Nov 22, 2023

srikarparsi commented Sep 28, 2023 •

edited by jasperhuangg

Loading

cloudflare-workers-and-pages bot commented Oct 10, 2023 •

edited

Loading

ArekChr commented Oct 16, 2023 •

edited by jasperhuangg

Loading

srikarparsi commented Oct 17, 2023 •

edited

Loading