-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade react-native-key-command version #28370
Upgrade react-native-key-command version #28370
Conversation
@thesahindia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Accidentally added @rushatgabhane, sorry - please ignore! |
@hungvu193, please resolve the conflicts. |
Updated! |
Reviewer Checklist
Screenshots/VideosWebScreen.Recording.2023-09-22.at.1.07.47.AM.movMobile Web - Chrome86526849-4cf3-4940-882c-268889db0510.MP4Mobile Web - SafariRPReplay_Final1695326575.MP4DesktopScreen.Recording.2023-09-22.at.1.09.48.AM.moviOSAndroidebf22008-ff10-4621-9b61-78c438937a3f.MP4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Hmm not sure why the test is still failing after merging main. |
Maybe flaky, re-running |
🚀 Deployed to staging by https://github.com/roryabraham in version: 1.3.76-0 🚀
|
🚀 Deployed to production by https://github.com/mountiny in version: 1.3.76-6 🚀
|
🚀 Deployed to staging by https://github.com/roryabraham in version: 1.3.77-0 🚀
|
@hungvu193 You seem to forget to upgrade |
I'm not sure about that. The current change is only about a js library, it didn't relate to podfile in this case. |
See Line 588 in 7f063c7
|
I see. Usually I don't commit my podlock because there's a different config between my pod version and upstream pod version. In this case, I already upgraded the package-lock.json, so there's no problem, it will require you to do a pod install which I always did when I did a pull from upstream. |
🚀 Deployed to production by https://github.com/mountiny in version: 1.3.77-7 🚀
|
Details
this PR is a follow up of Expensify/react-native-key-command#34
Fixed Issues
$ #26986
PROPOSAL: #26986 (comment)
Tests
For the warning:
For the normal key listener:
Offline tests
Same as Tests.
QA Steps
Same as Tests.
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
chrome.mov
Mobile Web - Chrome
Mobile Web - Safari
Desktop
desktop.mov
iOS
Android