-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[No QA]Update fastlane
and retry Google authentication to fix builds
#27741
Conversation
@ Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosN/A CI change WebMobile Web - ChromeMobile Web - SafariDesktopiOSAndroid |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
[No QA]Update `fastlane` and retry Google authentication to fix builds (cherry picked from commit aaa1e27)
🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 1.3.71-6 🚀
|
🚀 Deployed to production by https://github.com/thienlnam in version: 1.3.71-12 🚀
|
Details
We are having sporadic issues uploading files to the Google Play API via our deploy pipeline with the error:
This appears to be a known issue with the Google Play API and a workaround to retry uploads has been added in the latest version of
fastlane
. This PR adds the latest version and the retry environment variable set to retry five times.Fixed Issues
Fixes broken Android builds: https://github.com/Expensify/App/actions/runs/6222539379 https://github.com/Expensify/App/actions/runs/6222401060
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
N/A - GitHub Action changes only
Mobile Web - Chrome
N/A - GitHub Action changes only
Mobile Web - Safari
N/A - GitHub Action changes only
Desktop
N/A - GitHub Action changes only
iOS
N/A - GitHub Action changes only
Android
N/A - GitHub Action changes only