-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[No QA][TS migration] Migrate 'asyncOpenURL' lib to TypeScript #26884
[No QA][TS migration] Migrate 'asyncOpenURL' lib to TypeScript #26884
Conversation
@@ -22,8 +19,13 @@ export default function asyncOpenURL(promise, url, shouldSkipCustomSafariLogic) | |||
const windowRef = window.open(); | |||
promise | |||
.then((params) => { | |||
windowRef.location = typeof url === 'string' ? url : url(params); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @luacmartins! I see you're the last person who modified this line. Is there a reason why you skipped href
here? There was a type error without, so I added it and I couldn't spot any regression, but I would like you to cross check it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @kowczarz , did you try this? It's working for me.
.then((params) => {
if (!windowRef) {
return;
}
windowRef.location = typeof url === 'string' ? url : url(params);
})
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kowczarz bump
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, that must have been some typescript caches left, because now it works flawlessly.
@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once small comment, other than that LGTM
Reviewer Checklist
Screenshots/VideosWebScreen.Recording.2023-09-13.at.16.30.14.movMobile Web - Chromescreen-20230913-163325.mp4Mobile Web - SafariScreen.Recording.2023-09-13.at.16.40.57.movDesktopScreen.Recording.2023-09-13.at.16.32.18.moviOSScreen.Recording.2023-09-13.at.16.40.28.movAndroidScreen.Recording.2023-09-13.at.16.39.33.mov |
…arz/async-open-url-lib
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We did not find an internal engineer to review this PR, trying to assign a random engineer to #24813 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
super minor style change, otherwise looks great
Co-authored-by: Nikki Wines <[email protected]>
@NikkiWines fixed ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NikkiWines looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/NikkiWines in version: 1.3.71-0 🚀
|
🚀 Deployed to production by https://github.com/thienlnam in version: 1.3.71-12 🚀
|
Details
Fixed Issues
$ #24813
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
web.mov
Mobile Web - Chrome
[android web.webm](https://github.com/Expensify/App/assets/91068263/a1228794-a284-4f39-9b0d-d2d11e20ff1a)Mobile Web - Safari
ios.web.mp4
Desktop
deskto.mov
iOS
ios.native.mp4
Android
android.native.webm