Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add log when we try to deep link redirect while not authenticated. Don't crash the app. #26839

Merged
merged 4 commits into from
Sep 18, 2023
Merged

Add log when we try to deep link redirect while not authenticated. Don't crash the app. #26839

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
34a2fdb
Add a log for Doza so that we can try to figure out why he is hitting…
marcaaron Sep 5, 2023
c5cc1c8
add more params
marcaaron Sep 6, 2023
e4d3e4a
Add more to the comment
marcaaron Sep 6, 2023
58efdcb
run prettier
marcaaron Sep 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/libs/actions/App.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,6 +453,15 @@ function beginDeepLinkRedirect(shouldAuthenticateWithCurrentAccount = true) {

// eslint-disable-next-line rulesdir/no-api-side-effects-method
API.makeRequestWithSideEffects('OpenOldDotLink', {shouldRetry: false}, {}).then((response) => {
if (!response) {
Log.alert(
'Trying to redirect via deep link, but the response is empty. User likely not authenticated.',
{response, shouldAuthenticateWithCurrentAccount, currentUserAccountID},
true,
);
return;
}

Browser.openRouteInDesktopApp(response.shortLivedAuthToken, currentUserEmail);
});
}
Expand Down
Loading