FIx payment method popover toggle #26377

bernhardoj · 2023-08-31T10:27:42Z

Details

Currently, pressing the payment method the second time doesn't close the popover, instead, it will clear the selected payment method but the popover is still showing.

Fixed Issues

$ #25594
PROPOSAL: #25594 (comment)

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Web/Desktop

Open Settings > Wallet
Add 1 bank account and 1 PayPal if you don't have it
Click the PayPal payment method
Verify a popover menu showing below PayPal payment method with the menu of Edit and Delete
Click the PayPal payment method once again
Verify the popover closes
Repeat step 3-4
Click the bank account payment method
Verify a new popover menu shows below the bank account payment method with Make default payment method (if you have wallet permission) and Delete menu
Repeat step 3-4
Delete the PayPal payment method
Verify the PayPal payment method is successfully deleted

mWeb/Android/iOS

Open Settings > Wallet
Add 1 bank account and 1 PayPal if you don't have it
Click the PayPal payment method
Verify a modal showing with the menu of Edit and Delete
Close the PayPal payment method modal
Click the bank account payment method
Verify a modal showing with Make default payment method (if you have wallet permission) and Delete menu
Close the bank account payment method modal
Delete the PayPal payment method
Verify the PayPal payment method is successfully deleted

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Screen.Recording.2023-08-31.at.17.54.23.mov

Mobile Web - Chrome

Screen.Recording.2023-08-31.at.18.10.36.mov

Mobile Web - Safari

Screen.Recording.2023-08-31.at.18.02.49.mov

Desktop

Screen.Recording.2023-08-31.at.17.56.34.mov

iOS

Screen.Recording.2023-08-31.at.17.58.48.mov

Android

Screen.Recording.2023-08-31.at.18.32.51.mov

melvin-bot · 2023-08-31T10:27:46Z

@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

bernhardoj · 2023-08-31T10:29:30Z

src/pages/settings/Wallet/WalletPage/BaseWalletPage.js

                            deletePaymentMethod();
+                            hideDefaultDeleteMenu();


There is actually no problem so far calling hideDefaultDeleteMenu before deletePaymentMethod, but I think it makes more sense to call deletePaymentMethod first because it uses the paymentMethod which will be cleared once the popover is hidden.

bernhardoj · 2023-08-31T10:29:42Z

src/pages/settings/Wallet/WalletPage/BaseWalletPage.js

                                    makeDefaultPaymentMethod();
+                                    setShouldShowDefaultDeleteMenu(false);
                                }}


same as below (or above)

bernhardoj · 2023-08-31T10:30:16Z

~~Having an issue on Android, will add the recording once the problem is resolved~~ Done

mananjadhav

Code change looks good, I am going to test now.

mananjadhav · 2023-09-01T17:09:31Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web-popver-back-to-back.mov

Mobile Web - Chrome

Mobile Web - Safari

Desktop

desktop-popver-back-to-back.mov

iOS

Android

This change doesn't affect Android, and build is taking too long, hence skipping this one.

src/pages/settings/Wallet/WalletPage/BaseWalletPage.js

Julesssss · 2023-09-04T10:22:10Z

src/pages/settings/Wallet/WalletPage/BaseWalletPage.js

                            deletePaymentMethod();
+                            hideDefaultDeleteMenu();


Julesssss · 2023-09-04T10:23:41Z

Going to merge this one as it is noticeable to Safari users who are creating IOUs (likely during conferences)

OSBotify · 2023-09-04T10:30:27Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-09-04T16:49:52Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 1.3.63-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-09-05T18:42:27Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.63-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-09-05T19:12:50Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 1.3.64-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-09-06T18:55:25Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.64-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix wrong ref and selected payment method is cleared in a wrong timing

a0119c5

bernhardoj requested a review from a team as a code owner August 31, 2023 10:27

melvin-bot bot removed the request for review from a team August 31, 2023 10:27

melvin-bot bot requested a review from mananjadhav August 31, 2023 10:27

bernhardoj commented Aug 31, 2023

View reviewed changes

mananjadhav approved these changes Sep 1, 2023

View reviewed changes

melvin-bot bot requested a review from Julesssss September 1, 2023 16:55

Julesssss reviewed Sep 1, 2023

View reviewed changes

src/pages/settings/Wallet/WalletPage/BaseWalletPage.js Show resolved Hide resolved

Julesssss assigned bernhardoj Sep 4, 2023

Julesssss approved these changes Sep 4, 2023

View reviewed changes

src/pages/settings/Wallet/WalletPage/BaseWalletPage.js

deletePaymentMethod();

hideDefaultDeleteMenu();

Copy link

Contributor

Julesssss Sep 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree

Julesssss merged commit d89182b into Expensify:main Sep 4, 2023

OSBotify mentioned this pull request Sep 4, 2023

Deploy Checklist: New Expensify 2023-09-04 #26686

Closed

35 tasks

OSBotify mentioned this pull request Sep 5, 2023

Deploy Checklist: New Expensify 2023-09-05 #26820

Closed

48 tasks

melvin-bot bot mentioned this pull request Sep 5, 2023

[HOLD for payment 2023-09-12] [$1000] Web - Payments - Unexpected behaviour occur when clicking two times simultaneously on Payment option #25594

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

FIx payment method popover toggle #26377

FIx payment method popover toggle #26377

bernhardoj commented Aug 31, 2023 •

edited

Loading

melvin-bot bot commented Aug 31, 2023

bernhardoj Aug 31, 2023

Julesssss Sep 4, 2023

bernhardoj Aug 31, 2023 •

edited

Loading

bernhardoj commented Aug 31, 2023 •

edited

Loading

mananjadhav left a comment

mananjadhav commented Sep 1, 2023

Julesssss Sep 4, 2023

Julesssss commented Sep 4, 2023

OSBotify commented Sep 4, 2023

OSBotify commented Sep 4, 2023

OSBotify commented Sep 5, 2023

OSBotify commented Sep 5, 2023

OSBotify commented Sep 6, 2023

FIx payment method popover toggle #26377

FIx payment method popover toggle #26377

Conversation

bernhardoj commented Aug 31, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Aug 31, 2023

bernhardoj Aug 31, 2023

Choose a reason for hiding this comment

Julesssss Sep 4, 2023

Choose a reason for hiding this comment

bernhardoj Aug 31, 2023 • edited Loading

Choose a reason for hiding this comment

bernhardoj commented Aug 31, 2023 • edited Loading

mananjadhav left a comment

Choose a reason for hiding this comment

mananjadhav commented Sep 1, 2023

Reviewer Checklist

Screenshots/Videos

Julesssss Sep 4, 2023

Choose a reason for hiding this comment

Julesssss commented Sep 4, 2023

OSBotify commented Sep 4, 2023

OSBotify commented Sep 4, 2023

OSBotify commented Sep 5, 2023

OSBotify commented Sep 5, 2023

OSBotify commented Sep 6, 2023

bernhardoj commented Aug 31, 2023 •

edited

Loading

bernhardoj Aug 31, 2023 •

edited

Loading

bernhardoj commented Aug 31, 2023 •

edited

Loading