[CP Staging] Fix/24389 - Request a money - Clicking on the avatar open a wrong profile #26055

spcheema · 2023-08-28T02:10:29Z

Details

Fixed Issues

$ #24389
$ #26027
PROPOSAL: #24389 (comment)

Tests

Scenario 1.

Open a chat room from LHN
Request a money
Click on any of the IOU message avatars
It should open the details page on RHN
Clicking on each menu item on the details page should open the respective profile page

Scenario 2.

Open a chat room from LHN
Request a money
Click IOU message avatars and it'll open the thread
Clicking on avatars in the thread header and it should open the details page on RHN
Clicking on each menu item on the details page should open the respective profile page

Verify that no errors appear in the JS console

Offline tests

QA Steps

Scenario 1.

Open a chat room from LHN
Request a money
Click on any of the IOU message avatars
It should open the details page on RHN
Clicking on each menu item on the details page should open the respective profile page

Scenario 2.

Open a chat room from LHN
Request a money
Click IOU message avatars and it'll open the thread
Clicking on avatars in the thread header and it should open the details page on RHN
Clicking on each menu item on the details page should open the respective profile page

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Web.mp4

Mobile Web - Chrome

Mobile.-.chrome.mp4

Mobile Web - Safari

Mobile.-.safari.mp4

Desktop

Desktop.1.mp4

iOS

Screen.Recording.2023-08-17.at.12.45.37.pm.mp4

Android

Re_.Meet.-.buf-ooot-azm.-.17.August.2023.mp4

melvin-bot · 2023-08-28T02:10:34Z

@narefyev91 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

spcheema · 2023-08-28T02:39:29Z

Unfortunately another regression @narefyev91

The change is based on the following reasoning.

There are 3 types of reports here

iou
chat
expense

The profile should be displayed for chat and expense reports when the report header avatar is clicked whereas iou report should display a list of participants (owner & manager)

Ideally, there should not be any other case but I have added report detail navigation as a fallback route to prevent unexpected behavior if:

actionActorID is 0 or -1
somebody mistakenly changed the logic to include any other report.

narefyev91 · 2023-08-28T07:22:49Z

@spcheema seems one more issue based on your code

Screen.Recording.2023-08-28.at.10.21.39.mov

Showing black screen

spcheema · 2023-08-28T07:35:15Z

@narefyev91 Can you please share the error log or steps to reproduce?

narefyev91 · 2023-08-28T07:42:03Z

Screen.Recording.2023-08-28.at.10.18.14.mov

@spcheema check this full video - you will see all steps

spcheema · 2023-08-28T07:54:35Z

@narefyev91 I have it tested with new and existing users but didn't face blank page issue. I need your help to reproduce it.

https://www.loom.com/share/c1b2c9ed34494311b22936da85996b87?sid=598aa24e-3f4b-4de9-8198-4525e1d1a930

Can you please try to reproduce and check logs. There might be some more information to about.

narefyev91 · 2023-08-28T08:00:05Z

It's not a blank page to be honest - it's something that fires black absolute position - clicking on any place - close it

Screen.Recording.2023-08-28.at.10.58.06.mov

Can you run your code on latest main?

narefyev91 · 2023-08-28T08:03:42Z

Just adding simple logs

Get 2 and 5 - which means 2 Navigation fires

I think we missing return here?

narefyev91 · 2023-08-28T08:05:32Z

Ohh wow - github on checkout - removed return for that line! for some reason.... hmmm - let me re-test again

narefyev91 · 2023-08-28T08:22:12Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

android-web.mov

Mobile Web - Safari

ios-web.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

narefyev91

LGTM!
🎀 👀 🎀 C+ reviewed

spcheema · 2023-08-28T09:19:30Z

I just noticed you have approved the PR @narefyev91.

Was there any issue? Or I meant what was the issue? How it get fixed?

narefyev91 · 2023-08-28T09:24:35Z

I just noticed you have approved the PR @narefyev91.

Was there any issue? Or I meant what was the issue? How it get fixed?

Yup the issue was - during checkout to your branch - for some reason my IDE remove that return at second if construction - i add it and code started to be the same as yours - and after that no issues

luacmartins

LGTM and tests well.

luacmartins · 2023-08-28T15:51:46Z

Merging since it fixes a deploy blocker

OSBotify · 2023-08-28T15:57:32Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

…staging-26027 [CP Staging] Fix/24389 - Request a money - Clicking on the avatar open a wrong profile (cherry picked from commit f02b003)

OSBotify · 2023-08-28T16:42:49Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.3.57-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-29T00:06:15Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.57-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-08-30T01:54:55Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.3.59-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-31T01:55:12Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.59-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

Fix empty RHN navigation issue

33c584b

spcheema requested a review from a team as a code owner August 28, 2023 02:10

melvin-bot bot requested review from narefyev91 and removed request for a team August 28, 2023 02:10

spcheema mentioned this pull request Aug 28, 2023

[HOLD for payment 2023-09-06] [HOLD for payment 2023-09-04] Web - Blank members page displayed when open the cash amount page header for the first time #26027

Closed

6 tasks

Add fallback route

eca7ebd

narefyev91 approved these changes Aug 28, 2023

View reviewed changes

melvin-bot bot requested a review from youssef-lr August 28, 2023 08:22

luacmartins approved these changes Aug 28, 2023

View reviewed changes

luacmartins merged commit f02b003 into Expensify:main Aug 28, 2023

luacmartins mentioned this pull request Aug 28, 2023

Deploy Checklist: New Expensify 2023-08-24 #25813

Closed

73 tasks

OSBotify mentioned this pull request Aug 28, 2023

Deploy Checklist: New Expensify 2023-08-28 #26113

Closed

melvin-bot bot mentioned this pull request Aug 28, 2023

[HOLD for payment 2023-09-06] [HOLD for payment 2023-09-04] [$1000] Web - Request a money - Clicking on the avatar open a wrong profile #24389

Closed

6 tasks

OSBotify mentioned this pull request Aug 30, 2023

Deploy Checklist: New Expensify 2023-08-30 #26268

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CP Staging] Fix/24389 - Request a money - Clicking on the avatar open a wrong profile #26055

[CP Staging] Fix/24389 - Request a money - Clicking on the avatar open a wrong profile #26055

spcheema commented Aug 28, 2023

melvin-bot bot commented Aug 28, 2023

spcheema commented Aug 28, 2023 •

edited

Loading

narefyev91 commented Aug 28, 2023

spcheema commented Aug 28, 2023

narefyev91 commented Aug 28, 2023

spcheema commented Aug 28, 2023 •

edited

Loading

narefyev91 commented Aug 28, 2023

narefyev91 commented Aug 28, 2023

narefyev91 commented Aug 28, 2023

narefyev91 commented Aug 28, 2023

narefyev91 left a comment

spcheema commented Aug 28, 2023

narefyev91 commented Aug 28, 2023

luacmartins left a comment

luacmartins commented Aug 28, 2023

OSBotify commented Aug 28, 2023

OSBotify commented Aug 28, 2023

OSBotify commented Aug 29, 2023

OSBotify commented Aug 30, 2023

OSBotify commented Aug 31, 2023

[CP Staging] Fix/24389 - Request a money - Clicking on the avatar open a wrong profile #26055

[CP Staging] Fix/24389 - Request a money - Clicking on the avatar open a wrong profile #26055

Conversation

spcheema commented Aug 28, 2023

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Aug 28, 2023

spcheema commented Aug 28, 2023 • edited Loading

narefyev91 commented Aug 28, 2023

spcheema commented Aug 28, 2023

narefyev91 commented Aug 28, 2023

spcheema commented Aug 28, 2023 • edited Loading

narefyev91 commented Aug 28, 2023

narefyev91 commented Aug 28, 2023

narefyev91 commented Aug 28, 2023

narefyev91 commented Aug 28, 2023

Reviewer Checklist

Screenshots/Videos

narefyev91 left a comment

Choose a reason for hiding this comment

spcheema commented Aug 28, 2023

narefyev91 commented Aug 28, 2023

luacmartins left a comment

Choose a reason for hiding this comment

luacmartins commented Aug 28, 2023

OSBotify commented Aug 28, 2023

OSBotify commented Aug 28, 2023

OSBotify commented Aug 29, 2023

OSBotify commented Aug 30, 2023

OSBotify commented Aug 31, 2023

spcheema commented Aug 28, 2023 •

edited

Loading

spcheema commented Aug 28, 2023 •

edited

Loading