fixed: dev: '0:undefined:' displayed in reaction emoji tooltip #23371

jfquevedol2198 · 2023-07-21T20:45:32Z

Details

#23307

Fixed Issues

$ #23307
PROPOSAL: #23307 (comment)

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

Web, Desktop, mWeb, Mobile

Open a chat
Send a message
React message with any emoji
Right click on reacted emoji (Desktop & Web)
Long touch on Emoji (Mobile & mWeb)
Verify Emoji & Count & user details are shown correctly

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

melvin-bot · 2023-07-21T20:45:36Z

@Santhosh-Sellavel Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2023-07-21T20:45:49Z

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

jfquevedol2198 · 2023-07-21T21:15:38Z

I have read the CLA Document and I hereby sign the CLA

jfquevedol2198 · 2023-07-22T04:53:08Z

@Santhosh-Sellavel I need to do extra thing on this PR?

Santhosh-Sellavel · 2023-07-23T19:24:11Z

@jfquevedol2198 Include Test steps

Santhosh-Sellavel · 2023-07-23T19:42:43Z

Moved here #23371 (comment)

Santhosh-Sellavel · 2023-07-23T19:50:29Z

I noticed a couple of issues,

One blue line border for the page. This happens on the main too. Check the image
Reactions count is not updated immediately, unable to view the list if the emoji is just added by the user. Check video below for more. Again this is not related to the changes here

Screen.Recording.2023-07-24.at.1.18.18.AM.mov

@stitesExpensify Is these valid bugs to be reported or not thanks?

Santhosh-Sellavel

Mostly Looks good.

Waiting for test steps and change from contributor
Waiting for clarification from @stitesExpensify for this fixed: dev: '0:undefined:' displayed in reaction emoji tooltip #23371 (comment).

src/components/Reactions/ReportActionItemEmojiReactions.js

jfquevedol2198 · 2023-07-24T07:19:20Z

@Santhosh-Sellavel Test steps:

Open a chat
Send a message
React message with any emoji
Right click on reacted emoji (Desktop & Web)
Long touch on Emoji (Mobile & mWeb)
Displays expected result with correct reactions on Emoji and users list

jfquevedol2198 · 2023-07-24T07:46:50Z

I noticed a couple of issues,

One blue line border for the page. This happens on the main too. Check the image

Reactions count is not updated immediately, unable to view the list if the emoji is just added by the user. Check video below for more. Again this is not related to the changes here

Screen.Recording.2023-07-24.at.1.18.18.AM.mov
@stitesExpensify Is these valid bugs to be reported or not thanks?

@Santhosh-Sellavel #2 is done in PR update.
We need to do #1 on this PR, too?

stitesExpensify · 2023-07-24T17:52:35Z

Glad #2 is fixed. I don't think that #1 needs to be fixed in this PR, that can be reported separately

stitesExpensify

The code seems to test well online. When offline, however when offline it is not possible to view who has reacted if you are the first. I think if we put this into the optimistic data instead of the success data it will be fixed

src/libs/actions/Report.js

stitesExpensify · 2023-07-24T18:56:57Z

@jfquevedol2198 added a review. @Santhosh-Sellavel can you see if you agree with my comments?

jfquevedol2198 · 2023-07-24T19:32:23Z

@stitesExpensify @Santhosh-Sellavel
Thanks for reviewing kindly, I just updated.

src/libs/actions/Report.js

jfquevedol2198 · 2023-07-24T20:29:44Z

@Santhosh-Sellavel @stitesExpensify
All requested changes are done

Santhosh-Sellavel · 2023-07-24T20:49:50Z

@stitesExpensify Initiate workflow

stitesExpensify · 2023-07-24T21:04:49Z

I just realized on re-review that I don't think that this is the correct solution 😬

Emoji Reactions are no longer going to be stored on the reportAction message as of the PR that caused this bug. They are only going to be stored in the ${ONYXKEYS.COLLECTION.REPORT_ACTIONS_REACTIONS}${reportActionID} collection. So the real solution here is actually to update the PopoverReactionList to get the reactions from there, as opposed to updating the optimistic data of the action. My apologies for not catching this earlier, but we shouldn't be updating ${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${originalReportID} when adding the reaction anymore 😞

stitesExpensify

Code is looking much better. As soon as @Santhosh-Sellavel makes sure it tests well I'll merge.

jfquevedol2198 · 2023-07-25T22:14:47Z

@Santhosh-Sellavel can you please check so that I can update if have any issue?

Santhosh-Sellavel · 2023-07-25T23:13:58Z

@Santhosh-Sellavel Test steps:

Open a chat

Send a message

React message with any emoji

Right click on reacted emoji (Desktop & Web)
Long touch on Emoji (Mobile & mWeb)

Displays expected result with correct reactions on Emoji and users list

@jfquevedol2198 Looks good add it to the PR description thanks!

Step 5 Verify Emoji & Count & user details are shown correctly, thanks!

jfquevedol2198 · 2023-07-25T23:17:30Z

@Santhosh-Sellavel I just added Test Steps as QA steps in PR description. Thanks

Santhosh-Sellavel · 2023-07-25T23:31:14Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web & Desktop

Screen.Recording.2023-07-26.at.4.46.05.AM.mov

Mobile Web - Chrome & Mobile Web - Safari

iOS & Android

Santhosh-Sellavel

LGTM tests well!

All yours @stitesExpensify!

jfquevedol2198 · 2023-07-26T01:16:30Z

@stitesExpensify can we merge tonight this if all good?

stitesExpensify · 2023-07-26T01:27:53Z

can we merge tonight this if all good?

Yes we can :)

OSBotify · 2023-07-26T01:32:02Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-07-26T16:09:58Z

🚀 Deployed to staging by https://github.com/stitesExpensify in version: 1.3.46-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

src/components/Reactions/ReportActionItemEmojiReactions.js

src/pages/home/report/ReactionList/PopoverReactionList.js

OSBotify · 2023-07-27T22:07:52Z

🚀 Deployed to staging by https://github.com/stitesExpensify in version: 1.3.47-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-07-27T22:38:44Z

🚀 Deployed to production by https://github.com/marcaaron in version: 1.3.46-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-07-31T18:36:21Z

🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.47-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

jfquevedol2198 · 2023-08-03T17:48:07Z

@Santhosh-Sellavel @stitesExpensify Whats the next step on this? This was first assignment for me so I am wondering..

Santhosh-Sellavel · 2023-08-03T18:03:25Z

@jfquevedol2198 Just payment pending, please keep the discussion on the issue for general doubts thanks!

jfquevedol2198 requested a review from a team as a code owner July 21, 2023 20:45

melvin-bot bot requested review from Santhosh-Sellavel and removed request for a team July 21, 2023 20:45

fixed: dev: '0:undefined:' displayed in reaction emoji tooltip

e87117d

jfquevedol2198 force-pushed the fix/23307-0-undefined-reaction-emoji-tooltip branch from 2ca0b1d to e87117d Compare July 21, 2023 21:22

Santhosh-Sellavel reviewed Jul 23, 2023

View reviewed changes

src/components/Reactions/ReportActionItemEmojiReactions.js Outdated Show resolved Hide resolved

jfquevedol2198 added 2 commits July 24, 2023 11:48

use reactionEmojiName instead of reaction.emojiName

fc871ea

added successData in toogleReaction result and updated test

7477b56

stitesExpensify self-requested a review July 24, 2023 15:16

stitesExpensify requested changes Jul 24, 2023

View reviewed changes

src/libs/actions/Report.js Outdated Show resolved Hide resolved

src/libs/actions/Report.js Outdated Show resolved Hide resolved

merged response data

40f01ea

jfquevedol2198 requested a review from stitesExpensify July 24, 2023 19:32

Santhosh-Sellavel reviewed Jul 24, 2023

View reviewed changes

src/libs/actions/Report.js Outdated Show resolved Hide resolved

jfquevedol2198 added 2 commits July 25, 2023 03:37

removed unnecessary line

660bb48

prettier

fb327b0

jfquevedol2198 requested a review from Santhosh-Sellavel July 25, 2023 15:35

stitesExpensify approved these changes Jul 25, 2023

View reviewed changes

Santhosh-Sellavel approved these changes Jul 25, 2023

View reviewed changes

melvin-bot bot requested a review from stitesExpensify July 25, 2023 23:31

Santhosh-Sellavel approved these changes Jul 26, 2023

View reviewed changes

stitesExpensify approved these changes Jul 26, 2023

View reviewed changes

melvin-bot bot requested a review from stitesExpensify July 26, 2023 01:27

stitesExpensify merged commit e32ff5e into Expensify:main Jul 26, 2023

OSBotify mentioned this pull request Jul 26, 2023

Deploy Checklist: New Expensify 2023-07-26 #23657

Closed

43 tasks

hungvu193 mentioned this pull request Jul 27, 2023

Conversation - Reaction tooltip does not update when other user has removed the emoji #23746

Closed

6 tasks

hungvu193 reviewed Jul 27, 2023

View reviewed changes

src/components/Reactions/ReportActionItemEmojiReactions.js Show resolved Hide resolved

hungvu193 reviewed Jul 27, 2023

View reviewed changes

src/pages/home/report/ReactionList/PopoverReactionList.js Show resolved Hide resolved

OSBotify mentioned this pull request Jul 27, 2023

Deploy Checklist: New Expensify 2023-07-27 #23765

Closed

79 tasks

melvin-bot bot mentioned this pull request Jul 27, 2023

[HOLD for c+ payment in newdot] [$1000] Dev: "0:undefined:" displayed in reaction emoji tooltip #23307

Closed

6 tasks

s77rt mentioned this pull request Jul 28, 2023

[HOLD for payment 2023-08-17] [$1000] Web - Emoji count and details are not dynamically updating when reactions are added #23752

Closed

6 tasks

pbkompasz mentioned this pull request Aug 3, 2023

[$1000] Chat - Removed reactions by other user offline still displayed after going online #23388

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fixed: dev: '0:undefined:' displayed in reaction emoji tooltip #23371

fixed: dev: '0:undefined:' displayed in reaction emoji tooltip #23371

jfquevedol2198 commented Jul 21, 2023 •

edited

Loading

melvin-bot bot commented Jul 21, 2023

github-actions bot commented Jul 21, 2023 •

edited

Loading

jfquevedol2198 commented Jul 21, 2023

jfquevedol2198 commented Jul 22, 2023

Santhosh-Sellavel commented Jul 23, 2023

Santhosh-Sellavel commented Jul 23, 2023 •

edited

Loading

Santhosh-Sellavel commented Jul 23, 2023

Santhosh-Sellavel left a comment

jfquevedol2198 commented Jul 24, 2023

jfquevedol2198 commented Jul 24, 2023

stitesExpensify commented Jul 24, 2023

stitesExpensify left a comment

stitesExpensify commented Jul 24, 2023

jfquevedol2198 commented Jul 24, 2023

jfquevedol2198 commented Jul 24, 2023

Santhosh-Sellavel commented Jul 24, 2023

stitesExpensify commented Jul 24, 2023

stitesExpensify left a comment

jfquevedol2198 commented Jul 25, 2023

Santhosh-Sellavel commented Jul 25, 2023 •

edited

Loading

jfquevedol2198 commented Jul 25, 2023

Santhosh-Sellavel commented Jul 25, 2023

Santhosh-Sellavel left a comment

jfquevedol2198 commented Jul 26, 2023

stitesExpensify commented Jul 26, 2023

OSBotify commented Jul 26, 2023

OSBotify commented Jul 26, 2023

OSBotify commented Jul 27, 2023

OSBotify commented Jul 27, 2023

OSBotify commented Jul 31, 2023

jfquevedol2198 commented Aug 3, 2023

Santhosh-Sellavel commented Aug 3, 2023

fixed: dev: '0:undefined:' displayed in reaction emoji tooltip #23371

fixed: dev: '0:undefined:' displayed in reaction emoji tooltip #23371

Conversation

jfquevedol2198 commented Jul 21, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jul 21, 2023

github-actions bot commented Jul 21, 2023 • edited Loading

jfquevedol2198 commented Jul 21, 2023

jfquevedol2198 commented Jul 22, 2023

Santhosh-Sellavel commented Jul 23, 2023

Santhosh-Sellavel commented Jul 23, 2023 • edited Loading

Santhosh-Sellavel commented Jul 23, 2023

Santhosh-Sellavel left a comment

Choose a reason for hiding this comment

jfquevedol2198 commented Jul 24, 2023

jfquevedol2198 commented Jul 24, 2023

stitesExpensify commented Jul 24, 2023

stitesExpensify left a comment

Choose a reason for hiding this comment

stitesExpensify commented Jul 24, 2023

jfquevedol2198 commented Jul 24, 2023

jfquevedol2198 commented Jul 24, 2023

Santhosh-Sellavel commented Jul 24, 2023

stitesExpensify commented Jul 24, 2023

stitesExpensify left a comment

Choose a reason for hiding this comment

jfquevedol2198 commented Jul 25, 2023

Santhosh-Sellavel commented Jul 25, 2023 • edited Loading

jfquevedol2198 commented Jul 25, 2023

Santhosh-Sellavel commented Jul 25, 2023

Reviewer Checklist

Screenshots/Videos

Santhosh-Sellavel left a comment

Choose a reason for hiding this comment

jfquevedol2198 commented Jul 26, 2023

stitesExpensify commented Jul 26, 2023

OSBotify commented Jul 26, 2023

OSBotify commented Jul 26, 2023

OSBotify commented Jul 27, 2023

OSBotify commented Jul 27, 2023

OSBotify commented Jul 31, 2023

jfquevedol2198 commented Aug 3, 2023

Santhosh-Sellavel commented Aug 3, 2023

jfquevedol2198 commented Jul 21, 2023 •

edited

Loading

github-actions bot commented Jul 21, 2023 •

edited

Loading

Santhosh-Sellavel commented Jul 23, 2023 •

edited

Loading

Santhosh-Sellavel commented Jul 25, 2023 •

edited

Loading