Fix shouldUseFullTitle #23358

ginsuma · 2023-07-21T16:09:01Z

Details

Update ReportSettingsPage and NotificationPreferencePage permission

Fixed Issues

$ #22997
PROPOSAL: #22997 (comment)

Tests

Create a chat room with long name
Open created chat room
Click header to open details
Verify that full chatroom title is visible.

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Safari

Mobile Web - Chrome

Desktop

iOS

Android

melvin-bot · 2023-07-21T16:09:08Z

@robertKozik Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

robertKozik · 2023-07-21T16:12:53Z

src/pages/ReportDetailsPage.js

@@ -155,7 +155,7 @@ function ReportDetailsPage(props) {
                                    tooltipEnabled
                                    numberOfLines={1}
                                    textStyles={[styles.textHeadline, styles.textAlignCenter, styles.pre]}
-                                    shouldUseFullTitle={shouldUseFullTitle}
+                                    shouldUseFullTitle={!shouldUseFullTitle}


Could you negate it where shouldUseFullTitle is created?

const shouldUseFullTitle = !shouldDisableSettings;

I just pushed the update. Sorry for the carelessness.

robertKozik · 2023-07-21T16:14:47Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

robertKozik · 2023-07-21T16:16:57Z

@ginsuma Can you add for test steps the scenario to cover checking the proper name of the room?

ginsuma · 2023-07-21T16:18:04Z

@ginsuma Can you add for test steps the scenario to cover checking the proper name of the room?

I will do it asap. Not in good situation now.

robertKozik · 2023-07-21T16:30:33Z

Test steps for this regression:

Create a chat room with long name
Open created chat room
Click header to open details
Verify that full chatroom title is visible

robertKozik

Looks alright

robertKozik · 2023-07-21T16:34:39Z

@arosiclair It's PRis a fast-follower for #23255, one condition was flawed and room name was wrong due to it

ginsuma · 2023-07-21T16:58:18Z

I added the screenshots. I'm sorry again for the inconvenience.

mananjadhav · 2023-07-23T13:53:06Z

@arosiclair Can we prioritize this? This could easily become a deploy blocker coming week.

@robertKozik do you want to post it on the C+ channel and get someone else to look at this, in case @arosiclair is unavailable?

We're also blocked because of this for this PR.

OSBotify · 2023-07-24T13:35:58Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

arosiclair · 2023-07-24T13:36:15Z

Please try to test a little more thoroughly next time @robertKozik @ginsuma. I'll have this CP'd to staging

Fix shouldUseFullTitle (cherry picked from commit 33ed167)

OSBotify · 2023-07-24T19:39:14Z

🚀 Deployed to staging by https://github.com/arosiclair in version: 1.3.44-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

arosiclair · 2023-07-24T21:04:25Z

Passes on staging

Web

Mobile Web - Safari

Mobile Web - Chrome

Desktop

iOS

No build

Android

OSBotify · 2023-07-25T01:23:42Z

🚀 Deployed to production by https://github.com/marcaaron in version: 1.3.44-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Fix shouldUseFullTitle

5c53549

ginsuma requested a review from a team as a code owner July 21, 2023 16:09

melvin-bot bot requested review from robertKozik and removed request for a team July 21, 2023 16:09

ginsuma mentioned this pull request Jul 21, 2023

Update ReportSettingsPage and NotificationPreferencePage permission #23255

Merged

57 tasks

robertKozik suggested changes Jul 21, 2023

View reviewed changes

Fix shouldUseFullTitle

ee23ba8

robertKozik approved these changes Jul 21, 2023

View reviewed changes

melvin-bot bot requested a review from arosiclair July 21, 2023 16:33

alexxxwork mentioned this pull request Jul 22, 2023

Component refactor: migrate ReportSettingsPage to function component #22927

Merged

57 tasks

This was referenced Jul 23, 2023

Fix: Don't truncate long room names in room details page #23357

Merged

Workspace rooms details page display user list in place of room name #23416

Closed

arosiclair approved these changes Jul 24, 2023

View reviewed changes

arosiclair merged commit 33ed167 into Expensify:main Jul 24, 2023

OSBotify pushed a commit that referenced this pull request Jul 24, 2023

Merge pull request #23358 from ginsuma/fix/22997

baf1a48

Fix shouldUseFullTitle (cherry picked from commit 33ed167)

marcaaron assigned ginsuma Jul 24, 2023

arosiclair mentioned this pull request Jul 24, 2023

Deploy Checklist: New Expensify 2023-07-21 #23362

Closed

OSBotify mentioned this pull request Jul 25, 2023

Deploy Checklist: New Expensify 2023-07-25 #23522

Closed

melvin-bot bot mentioned this pull request Jul 25, 2023

[HOLD for payment 2023-08-02] [HOLD for payment 2023-08-01] [$1000] Web - The first letter of the chat name is cut #22997

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix shouldUseFullTitle #23358

Fix shouldUseFullTitle #23358

ginsuma commented Jul 21, 2023 •

edited

Loading

melvin-bot bot commented Jul 21, 2023

robertKozik Jul 21, 2023

ginsuma Jul 21, 2023

robertKozik commented Jul 21, 2023 •

edited

Loading

robertKozik commented Jul 21, 2023

ginsuma commented Jul 21, 2023

robertKozik commented Jul 21, 2023

robertKozik left a comment

robertKozik commented Jul 21, 2023 •

edited

Loading

ginsuma commented Jul 21, 2023

mananjadhav commented Jul 23, 2023

OSBotify commented Jul 24, 2023

arosiclair commented Jul 24, 2023

OSBotify commented Jul 24, 2023

arosiclair commented Jul 24, 2023

OSBotify commented Jul 25, 2023

Fix shouldUseFullTitle #23358

Fix shouldUseFullTitle #23358

Conversation

ginsuma commented Jul 21, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jul 21, 2023

robertKozik Jul 21, 2023

Choose a reason for hiding this comment

ginsuma Jul 21, 2023

Choose a reason for hiding this comment

robertKozik commented Jul 21, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

robertKozik commented Jul 21, 2023

ginsuma commented Jul 21, 2023

robertKozik commented Jul 21, 2023

robertKozik left a comment

Choose a reason for hiding this comment

robertKozik commented Jul 21, 2023 • edited Loading

ginsuma commented Jul 21, 2023

mananjadhav commented Jul 23, 2023

OSBotify commented Jul 24, 2023

arosiclair commented Jul 24, 2023

OSBotify commented Jul 24, 2023

arosiclair commented Jul 24, 2023

OSBotify commented Jul 25, 2023

ginsuma commented Jul 21, 2023 •

edited

Loading

robertKozik commented Jul 21, 2023 •

edited

Loading

robertKozik commented Jul 21, 2023 •

edited

Loading