fix: clicking spacebar leaves highlight focus on emoji in emoji picker #22995

payal-lathidadiya · 2023-07-17T11:08:42Z

Details

This fixes issue in emoji picker, wherein clicking on spacebar leaves selected/highlight focus on emoji. Removes highlight style for web and desktop since pressing on the emoji is expected to close the popup

Fixed Issues

$ #21806
PROPOSAL: #21806 (comment)

Tests

Open expensify on chrome web/desktop
Go to any chat
Open Emoji picker from composer
Use tab/arrow key to navigate in emoji list
While focus is on any emoji, click on spacebar from keyboard
Verify that it shouldn't leave highlight focus on emoji and cursor should move to search input.

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Same as above

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-07-19.at.6.01.49.PM.mov

Mobile Web - Chrome

Screen.Recording.2023-07-19.at.6.14.47.PM.mov

Mobile Web - Safari

Screen.Recording.2023-07-19.at.6.25.04.PM.mov

Desktop

Screen.Recording.2023-07-19.at.6.05.27.PM.mov

iOS

Screen.Recording.2023-07-19.at.6.22.33.PM.mov

Android

Screen.Recording.2023-07-19.at.6.12.38.PM.mov

melvin-bot · 2023-07-17T11:08:46Z

@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

abdulrahuman5196 · 2023-07-18T15:35:40Z

@payal-lathidadiya Offline tests is also "Same as tests" since this is expected to work offline as well

payal-lathidadiya · 2023-07-18T17:18:31Z

@payal-lathidadiya Offline tests is also "Same as tests" since this is expected to work offline as well

Yeah correct, it's same as test steps above.

abdulrahuman5196 · 2023-07-18T19:19:30Z

@payal-lathidadiya Offline tests is also "Same as tests" since this is expected to work offline as well

Yeah correct, it's same as test steps above.

Could you update the same in author's checklist?

abdulrahuman5196 · 2023-07-18T19:38:00Z

@Julesssss It seems we have an issue of this implementation in case of mobile devices. This approved change is removing a press feedback kind of mechanism in current behaviour.

With this PR.

Untitled.mp4

Current Production behaviour.

Untitled1.mp4

payal-lathidadiya · 2023-07-19T04:32:54Z

Could you update the same in author's checklist?

@abdulrahuman5196 updated. thanks

payal-lathidadiya · 2023-07-19T06:10:26Z

It seems we have an issue of this implementation in case of mobile devices. This approved change is removing a press feedback kind of mechanism in current behaviour.

@abdulrahuman5196
yeah, I can see that now it won't show highlight when selected since we've removed style applied when pressed.

I'm just wondering if we should to show it since selecting emoji is going to close the picker.

Not sure if we should compare UX/behavior with other messaging apps/tools. as checked, slack doesn't show press feedback with emoji selection.

Julesssss · 2023-07-19T08:24:43Z

I'm just wondering if we should to show it since selecting emoji is going to close the picker.

I would expect a native Android View to highlight when pressed, even if the modal is closed. We'll need to resolve this.

payal-lathidadiya · 2023-07-19T10:12:16Z

I'm just wondering if we should to show it since selecting emoji is going to close the picker.

I would expect a native Android View to highlight when pressed, even if the modal is closed. We'll need to resolve this.

Sure @Julesssss, I'll look into possible solution.

Do you think we should apply current solution only except native app? since original issue is only around desktop and web where we support keyboard interaction for navigating in emoji list.

Or do you have any other thoughts or input here.

Julesssss · 2023-07-19T10:16:19Z

We try to avoid any platform specific logic, but yeah using alternate components/files per platform with specific files is okay (for example .android)

abdulrahuman5196 · 2023-07-19T10:18:11Z

I am not sure that will work out. Since we would still face this issue in mobile web.

payal-lathidadiya · 2023-07-19T11:24:58Z

I am not sure that will work out. Since we would still face this issue in mobile web.

@Julesssss @abdulrahuman5196
I just tried and tested by creating separate emoji picker component file for native platfroms i.e. .native.js and keeping existing background style for press event. It seems to be working as expected.

For mobile web, we can use our browser API i.e. Browser.isMobile() to keep those style to get applied for mobile web browsers.

What do you think about this approach and solution?

If looks good, I can push new updates.

Julesssss · 2023-07-19T11:53:56Z

@payal-lathidadiya that sounds reasonable to me 👍

abdulrahuman5196 · 2023-07-19T12:41:57Z

@payal-lathidadiya I think we can also use isSmallScreenWidth prop to solve this. Could you kindly try this?

Julesssss · 2023-07-19T12:48:20Z

I think we can also use isSmallScreenWidth prop to solve this. Could you kindly try this?

I don't like this solution as it is not directly associated with the client platform (r resized desktop web client would still have the bug)

abdulrahuman5196 · 2023-07-19T12:52:35Z

r resized desktop web client would still have the bug

I had the same doubt, but I am unable to check the same currently. So I am suggesting it just as an another option to try out to solve this issue.
Just exploring on options

…ired background style logic adds separate native component to keep mobile behavior as previously and only apply style fix for web and desktop

payal-lathidadiya · 2023-07-19T13:21:52Z

Here we go!
I've pushed new updates to fix issue observed on native and mobile platform.

Also, updated PR with fresh screen recording post testing of new updates on all platforms

payal-lathidadiya · 2023-07-24T05:21:32Z

@abdulrahuman5196 bump for review

abdulrahuman5196 · 2023-07-24T05:22:11Z

Will work on review today

Julesssss

👍

abdulrahuman5196 · 2023-07-26T16:59:35Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-07-26.at.9.47.45.PM.mp4

Mobile Web - Chrome

az_recorder_20230726_220924.mp4

Mobile Web - Safari

Untitled.mp4

Desktop

Screen.Recording.2023-07-26.at.9.46.43.PM.mp4

iOS

Screen.Recording.2023-07-26.at.10.03.06.PM.mp4

Android

az_recorder_20230726_220547.mp4

abdulrahuman5196

Changes looks good and works well. Reviewers checklist is also complete.

All yours. @Julesssss Good to merge.

🎀 👀 🎀
C+ Reviewed

Julesssss · 2023-07-27T08:14:16Z

Tests well

OSBotify · 2023-07-27T08:17:57Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-07-27T22:06:43Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 1.3.47-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-07-31T18:35:12Z

🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.47-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix: clicking spacebar leaves highlight focus on emoji in emoji picker

92362b1

payal-lathidadiya requested a review from a team as a code owner July 17, 2023 11:08

melvin-bot bot removed the request for review from a team July 17, 2023 11:08

melvin-bot bot requested a review from abdulrahuman5196 July 17, 2023 11:08

fix: clicking spacebar leaves highlight focus on emoji in emoji picker

b865ebe

payal-lathidadiya mentioned this pull request Jul 17, 2023

[HOLD for payment 2023-08-07] [$1000] In emoji picker, clicking on spacebar leaves selected/highlight focus on emoji #21806

Closed

6 tasks

Julesssss assigned payal-lathidadiya Jul 17, 2023

Julesssss previously approved these changes Jul 17, 2023

View reviewed changes

split component into platform specific component file and update requ…

a7f1423

…ired background style logic adds separate native component to keep mobile behavior as previously and only apply style fix for web and desktop

payal-lathidadiya dismissed Julesssss’s stale review via a7f1423 July 19, 2023 13:05

remove debug test code

aec5feb

Julesssss approved these changes Jul 26, 2023

View reviewed changes

abdulrahuman5196 approved these changes Jul 26, 2023

View reviewed changes

melvin-bot bot requested a review from Julesssss July 26, 2023 17:07

Julesssss approved these changes Jul 27, 2023

View reviewed changes

Julesssss merged commit 3cc6fdc into Expensify:main Jul 27, 2023

OSBotify mentioned this pull request Jul 27, 2023

Deploy Checklist: New Expensify 2023-07-27 #23765

Closed

79 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: clicking spacebar leaves highlight focus on emoji in emoji picker #22995

fix: clicking spacebar leaves highlight focus on emoji in emoji picker #22995

payal-lathidadiya commented Jul 17, 2023 •

edited

Loading

melvin-bot bot commented Jul 17, 2023

abdulrahuman5196 commented Jul 18, 2023

payal-lathidadiya commented Jul 18, 2023

abdulrahuman5196 commented Jul 18, 2023

abdulrahuman5196 commented Jul 18, 2023

payal-lathidadiya commented Jul 19, 2023

payal-lathidadiya commented Jul 19, 2023

Julesssss commented Jul 19, 2023

payal-lathidadiya commented Jul 19, 2023

Julesssss commented Jul 19, 2023

abdulrahuman5196 commented Jul 19, 2023

payal-lathidadiya commented Jul 19, 2023

Julesssss commented Jul 19, 2023

abdulrahuman5196 commented Jul 19, 2023

Julesssss commented Jul 19, 2023

abdulrahuman5196 commented Jul 19, 2023 •

edited

Loading

payal-lathidadiya commented Jul 19, 2023 •

edited

Loading

payal-lathidadiya commented Jul 24, 2023

abdulrahuman5196 commented Jul 24, 2023

Julesssss left a comment

abdulrahuman5196 commented Jul 26, 2023 •

edited

Loading

abdulrahuman5196 left a comment

Julesssss commented Jul 27, 2023

OSBotify commented Jul 27, 2023

OSBotify commented Jul 27, 2023

OSBotify commented Jul 31, 2023

fix: clicking spacebar leaves highlight focus on emoji in emoji picker #22995

fix: clicking spacebar leaves highlight focus on emoji in emoji picker #22995

Conversation

payal-lathidadiya commented Jul 17, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jul 17, 2023

abdulrahuman5196 commented Jul 18, 2023

payal-lathidadiya commented Jul 18, 2023

abdulrahuman5196 commented Jul 18, 2023

abdulrahuman5196 commented Jul 18, 2023

payal-lathidadiya commented Jul 19, 2023

payal-lathidadiya commented Jul 19, 2023

Julesssss commented Jul 19, 2023

payal-lathidadiya commented Jul 19, 2023

Julesssss commented Jul 19, 2023

abdulrahuman5196 commented Jul 19, 2023

payal-lathidadiya commented Jul 19, 2023

Julesssss commented Jul 19, 2023

abdulrahuman5196 commented Jul 19, 2023

Julesssss commented Jul 19, 2023

abdulrahuman5196 commented Jul 19, 2023 • edited Loading

payal-lathidadiya commented Jul 19, 2023 • edited Loading

payal-lathidadiya commented Jul 24, 2023

abdulrahuman5196 commented Jul 24, 2023

Julesssss left a comment

Choose a reason for hiding this comment

abdulrahuman5196 commented Jul 26, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

abdulrahuman5196 left a comment

Choose a reason for hiding this comment

Julesssss commented Jul 27, 2023

OSBotify commented Jul 27, 2023

OSBotify commented Jul 27, 2023

OSBotify commented Jul 31, 2023

payal-lathidadiya commented Jul 17, 2023 •

edited

Loading

abdulrahuman5196 commented Jul 19, 2023 •

edited

Loading

payal-lathidadiya commented Jul 19, 2023 •

edited

Loading

abdulrahuman5196 commented Jul 26, 2023 •

edited

Loading