22803 - Pasting text or link in edit message pastes the text or link in main compose box #22817

robertKozik · 2023-07-13T16:25:14Z

Details

it's follow up fix for #21583 copy&paste handler wasn't checking whether the incoming event fired from text input/area. It should be handled in a similar manner to the document-scoped keyPressListner

Fixed Issues

$ #22803
PROPOSAL:

Tests

Open the app
Open any report
Send any message
Copy any text
Edit message sent in step 3
Paste the text in edit message and observe that text is pasted in compose box

Verify that no errors appear in the JS console

Offline tests

Same as test steps

QA Steps

Same as test steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-07-13.at.18.18.23.mov

Mobile Web - Chrome

Mobile Web - Safari

Desktop

Screen.Recording.2023-07-13.at.18.22.51.mov

iOS

Android

… event

robertKozik · 2023-07-13T16:40:16Z

I've record the videos for platforms which handle copy&pasting without focus. Let me know if I should record all others.

melvin-bot · 2023-07-13T16:40:40Z

@Santhosh-Sellavel Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Santhosh-Sellavel · 2023-07-13T16:44:06Z

On it

cristipaval · 2023-07-13T16:55:30Z

On it

Thanks for the urgency @Santhosh-Sellavel !

Santhosh-Sellavel · 2023-07-13T17:01:52Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web & Desktop

Screen.Recording.2023-07-13.at.10.32.37.PM.mov

Mobile Web - Chrome & Mobile Web - Safari

Screen.Recording.2023-07-13.at.10.29.36.PM.mov

Santhosh-Sellavel

LGTM, all yours @PauloGasparSv!

francoisl · 2023-07-13T17:17:50Z

Thanks for the quick fix everyone.

@cristipaval do you mind requesting a CP for this in #deployer please? We're trying to close the checklist ASAP today.

francoisl · 2023-07-13T17:20:33Z

Actually nevermind, I got this 😄

OSBotify · 2023-07-13T17:21:21Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

22803 - Pasting text or link in edit message pastes the text or link in main compose box (cherry picked from commit a306694)

OSBotify · 2023-07-13T17:57:09Z

🚀 Deployed to staging by https://github.com/cristipaval in version: 1.3.40-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Santhosh-Sellavel · 2023-07-13T19:58:31Z

src/components/Composer/index.js

    handlePaste(event) {
-        if (!this.props.checkComposerVisibility() && !this.state.isFocused) {
+        if (!this.props.checkComposerVisibility()) {
+            return;
+        }
+
+        if (['INPUT', 'TEXTAREA'].includes(event.target.nodeName)) {


@robertKozik This is flawed in the root itself. this.props.checkComposerVisibility() always fails for edit message items as we didn't pass checkComposerVisibility

This event is called twice one from each instance. We should perform the operation only when it's from the textInput

Yeah you're right. I'm also looking for the another fix for this one. Did you check if pasting to the edited comment works?

I'm not sure that paste event should be trigger only from focused input. The "parent" issue and PR #21583 was introducing the ability to paste when input is not composed

No, it didn't work.

This snippet addresses both issues, but now if I edit an existing message and paste from the clipboard, the cursor remains at the beginning of the pasted message:

Screen.Recording.2023-07-13.at.1.37.54.PM.mov

I'd say let's revert this for now, and then work on a proper fix without having to rush.

Yes agreed lets do that first!

This one comes out of nowhere.

Please revert this first and lets work on the other issue alone!

Revert open here #22845, feel free to review.

@robertKozik about the cursor issue

The contributor here found the PR #22443 which causes it

OSBotify · 2023-07-14T14:43:47Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.40-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-07-17T19:40:20Z

🚀 Deployed to staging by https://github.com/cristipaval in version: 1.3.42-0 🚀

platform	result
🤖 android 🤖	cancelled 🔪
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	cancelled 🔪

OSBotify · 2023-07-19T18:02:06Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.42-26 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

prohibit handling paste event when input or textarea is the source of…

54ae8ba

… event

robertKozik marked this pull request as ready for review July 13, 2023 16:40

robertKozik requested a review from a team as a code owner July 13, 2023 16:40

melvin-bot bot requested review from Santhosh-Sellavel and removed request for a team July 13, 2023 16:40

robertKozik mentioned this pull request Jul 13, 2023

[HOLD for payment 2023-08-02] [HOLD for payment 2023-07-24] [$1000] Web - Pasting text or link in edit message pastes the text or link in main compose box #22803

Closed

6 tasks

Santhosh-Sellavel approved these changes Jul 13, 2023

View reviewed changes

melvin-bot bot requested a review from cristipaval July 13, 2023 17:04

cristipaval approved these changes Jul 13, 2023

View reviewed changes

cristipaval merged commit a306694 into Expensify:main Jul 13, 2023

OSBotify pushed a commit that referenced this pull request Jul 13, 2023

Merge pull request #22817 from robertKozik/16098-followup

777415e

22803 - Pasting text or link in edit message pastes the text or link in main compose box (cherry picked from commit a306694)

francoisl mentioned this pull request Jul 13, 2023

[$1000] [HOLD for payment 2023-07-24] [HOLD for payment 2023-07-21] Chat - Copy to clipboard does not copy with format #22833

Closed

6 tasks

Santhosh-Sellavel reviewed Jul 13, 2023

View reviewed changes

francoisl mentioned this pull request Jul 13, 2023

Revert "22803 - Pasting text or link in edit message pastes the text or link in main compose box" #22845

Merged

56 tasks

OSBotify mentioned this pull request Jul 14, 2023

Deploy Checklist: New Expensify 2023-07-13 #22783

Closed

53 tasks

OSBotify mentioned this pull request Jul 17, 2023

Deploy Checklist: New Expensify 2023-07-17 #23033

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

22803 - Pasting text or link in edit message pastes the text or link in main compose box #22817

22803 - Pasting text or link in edit message pastes the text or link in main compose box #22817

robertKozik commented Jul 13, 2023 •

edited

Loading

robertKozik commented Jul 13, 2023

melvin-bot bot commented Jul 13, 2023

Santhosh-Sellavel commented Jul 13, 2023

cristipaval commented Jul 13, 2023

Santhosh-Sellavel commented Jul 13, 2023 •

edited

Loading

Santhosh-Sellavel left a comment

francoisl commented Jul 13, 2023 •

edited

Loading

francoisl commented Jul 13, 2023

OSBotify commented Jul 13, 2023

OSBotify commented Jul 13, 2023

Santhosh-Sellavel Jul 13, 2023

Santhosh-Sellavel Jul 13, 2023

robertKozik Jul 13, 2023

robertKozik Jul 13, 2023

Santhosh-Sellavel Jul 13, 2023

francoisl Jul 13, 2023

Santhosh-Sellavel Jul 13, 2023

Santhosh-Sellavel Jul 13, 2023 •

edited

Loading

francoisl Jul 13, 2023

Santhosh-Sellavel Jul 17, 2023

OSBotify commented Jul 14, 2023

OSBotify commented Jul 17, 2023

OSBotify commented Jul 19, 2023

22803 - Pasting text or link in edit message pastes the text or link in main compose box #22817

22803 - Pasting text or link in edit message pastes the text or link in main compose box #22817

Conversation

robertKozik commented Jul 13, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

robertKozik commented Jul 13, 2023

melvin-bot bot commented Jul 13, 2023

Santhosh-Sellavel commented Jul 13, 2023

cristipaval commented Jul 13, 2023

Santhosh-Sellavel commented Jul 13, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

Santhosh-Sellavel left a comment

Choose a reason for hiding this comment

francoisl commented Jul 13, 2023 • edited Loading

francoisl commented Jul 13, 2023

OSBotify commented Jul 13, 2023

OSBotify commented Jul 13, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Santhosh-Sellavel Jul 13, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

OSBotify commented Jul 14, 2023

OSBotify commented Jul 17, 2023

OSBotify commented Jul 19, 2023

robertKozik commented Jul 13, 2023 •

edited

Loading

Santhosh-Sellavel commented Jul 13, 2023 •

edited

Loading

francoisl commented Jul 13, 2023 •

edited

Loading

Santhosh-Sellavel Jul 13, 2023 •

edited

Loading