Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert changes introduced by PR 2183 #2267

Merged
merged 1 commit into from
Apr 7, 2021
Merged

Conversation

marcaaron
Copy link
Contributor

@marcaaron marcaaron commented Apr 7, 2021

Details

The PR is blocking the deploy.

Fixed Issues

Fixes #2207

Tests

QA Steps

Repeat steps in linked issue and retest deploy blocker

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

2021-04-07_06-27-45.mp4

@marcaaron marcaaron requested a review from roryabraham April 7, 2021 16:26
@marcaaron marcaaron requested a review from a team as a code owner April 7, 2021 16:26
@marcaaron marcaaron self-assigned this Apr 7, 2021
@marcaaron marcaaron removed the request for review from a team April 7, 2021 16:26
@MelvinBot MelvinBot requested a review from joelbettner April 7, 2021 16:26
@marcaaron
Copy link
Contributor Author

Tested on Android, assuming other platforms are fine.

@marcaaron marcaaron removed the request for review from joelbettner April 7, 2021 16:29
Copy link
Contributor

@roryabraham roryabraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@roryabraham
Copy link
Contributor

roryabraham commented Apr 7, 2021

Merging before E2E finishes because this resolves a deploy blocker and just reverts another PR

@roryabraham roryabraham merged commit b1b663a into master Apr 7, 2021
@roryabraham roryabraham deleted the marcaaron-revert2183 branch April 7, 2021 16:39
@botify
Copy link

botify commented Apr 7, 2021

@roryabraham looks like this was merged without passing tests. Please add a note explaining why this was done or remove the Emergency label if this is not an emergency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Android - Chat - Tapping plus opens chat instead of new or group chat options
3 participants