Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "use selector" to the PR checklist #22287

Merged
merged 1 commit into from
Jul 5, 2023
Merged

Add "use selector" to the PR checklist #22287

merged 1 commit into from
Jul 5, 2023

Conversation

iwiznia
Copy link
Contributor

@iwiznia iwiznia commented Jul 5, 2023

Context https://expensify.slack.com/archives/C01GTK53T8Q/p1688580666577479

Tests

None, just a readme change.

@iwiznia iwiznia self-assigned this Jul 5, 2023
@iwiznia iwiznia requested a review from a team as a code owner July 5, 2023 18:23
@melvin-bot melvin-bot bot removed the request for review from a team July 5, 2023 18:23
@melvin-bot
Copy link

melvin-bot bot commented Jul 5, 2023

@AndrewGable Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot requested a review from AndrewGable July 5, 2023 18:23
Copy link
Contributor

@neil-marcellini neil-marcellini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks

@iwiznia iwiznia merged commit 7075414 into main Jul 5, 2023
@iwiznia iwiznia deleted the iwiznia-patch-2 branch July 5, 2023 21:08
@melvin-bot melvin-bot bot added the Emergency label Jul 5, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 5, 2023

@iwiznia looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@iwiznia iwiznia removed the Emergency label Jul 5, 2023
@iwiznia
Copy link
Contributor Author

iwiznia commented Jul 5, 2023

This is a change to docs only

@OSBotify
Copy link
Contributor

OSBotify commented Jul 5, 2023

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

OSBotify commented Jul 7, 2023

🚀 Deployed to staging by https://github.com/iwiznia in version: 1.3.38-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.38-7 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants