Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix continue bank account text is crossed out when initiating Start Over while offline #21372

Merged
merged 3 commits into from
Jul 3, 2023
Merged

Fix continue bank account text is crossed out when initiating Start Over while offline #21372

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
05a9634
don't strikethorugh the text
bernhardoj Jun 23, 2023
cc299ed
reduce the opacity when disabled
bernhardoj Jun 23, 2023
95f73ab
Merge branch 'main' into fix/18517-continue-bank-account-text-striket…
bernhardoj Jun 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/components/MenuItem.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ function MenuItem(props) {
props.icon && !_.isArray(props.icon) ? styles.ml3 : undefined,
props.shouldShowBasicTitle ? undefined : styles.textStrong,
props.shouldShowHeaderTitle ? styles.textHeadlineH1 : undefined,
props.interactive && props.disabled ? {...styles.disabledText, ...styles.userSelectNone} : undefined,
props.interactive && props.disabled ? {...styles.userSelectNone} : undefined,
styles.pre,
styles.ltr,
isDeleted ? styles.offlineFeedback.deleted : undefined,
Expand Down Expand Up @@ -119,6 +119,7 @@ function MenuItem(props) {
StyleUtils.getButtonBackgroundColorStyle(getButtonState(props.focused || hovered, pressed, props.success, props.disabled, props.interactive), true),
(hovered || pressed) && props.hoverAndPressStyle,
...(_.isArray(props.wrapperStyle) ? props.wrapperStyle : [props.wrapperStyle]),
props.disabled && styles.buttonOpacityDisabled,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reducing the opacity as requested here #18517 (comment)

]}
disabled={props.disabled}
ref={props.forwardedRef}
Expand Down
1 change: 0 additions & 1 deletion src/pages/ReimbursementAccount/ContinueBankAccountSetup.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ function ContinueBankAccountSetup(props) {
icon={Illustrations.BankArrow}
>
<OfflineWithFeedback
pendingAction={pendingAction}
errors={errors}
shouldShowErrorMessage
onClose={BankAccounts.resetReimbursementAccount}
Expand Down