Fix/19156: Keyboard does not hide when switching between attachments with focused password input field #21367

dukenv0307 · 2023-06-23T01:16:23Z

Details

There're total of 4 issues here as per the expanded scope:

When the user navigates away from the PDF password form by clicking on the arrow buttons, dismiss the keyboard
When the user clicks on the eye icon while the keyboard is open, it should toggle immediately without dismissing keyboard
When the user navigates away from the PDF password form to other attachments by swiping, dismiss the keyboard
When the user navigates back to the PDF password form, focus the input and bring up the keyboard again

This PR will fix all above issues

Fixed Issues

$ #19156
PROPOSAL: #19156 (comment)

Tests

Open the App
Login with any account
Send several attachments including PDF-protected file
Click to preview on PDF-protected file -> Press Enter a password
Clicking eye icon while the keyboard is open
Verify that it should toggle immediately without dismissing keyboard
Navigates away from the PDF password form by clicking on the arrow buttons
Verify that keyboard is dismissed
Navigates away from the PDF password form by swiping
Verify that keyboard is dismissed
Navigates back to the PDF password form
Verify that the input is focused and bring up the keyboard again

Verify that no errors appear in the JS console

Offline tests

QA Steps

Open the App
Login with any account
Send several attachments including PDF-protected file
Click to preview on PDF-protected file -> Press Enter a password
Clicking eye icon while the keyboard is open
Verify that it should toggle immediately without dismissing keyboard
Navigates away from the PDF password form by clicking on the arrow buttons
Verify that keyboard is dismissed
Navigates away from the PDF password form by swiping
Verify that keyboard is dismissed
Navigates back to the PDF password form
Verify that the input is focused and bring up the keyboard again

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Screen.Recording.2023-06-23.at.09.09.41.mp4

Mobile Web - Chrome

353647747_7073280172686801_4191885020608394016_n.mp4

Mobile Web - Safari

Screen.Recording.2023-06-23.at.09.11.44.mp4

Desktop

Screen.Recording.2023-06-23.at.09.20.53.mp4

iOS

Screen.Recording.2023-06-23.at.09.04.06.mp4

Android

Screen.Recording.2023-06-23.at.11.39.05.mp4

melvin-bot · 2023-06-23T04:42:20Z

@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

aimane-chnaif

Some minor requests:

src/components/AttachmentView.js

src/components/PDFView/PDFPasswordForm.js

src/components/PDFView/pdfViewPropTypes.js

aimane-chnaif · 2023-06-25T15:25:30Z

There are some known issues which already happen on production:

[android] modal closes unexpectedly when focus on pdf password input (Password input form briefly appears and disappears in pdf preview #16372, not sure why it closed)

android-bug.mov

android-bug2.mov

[mChrome] very buggy while swiping navigation between attachments ([HOLD for payment 2023-06-29] [$1000] mWeb - Attachment - Modify the carousel component to improve swiping navigation between attachments #17723, PR deployed to production but still reproducible)

mchrome1.mov

mchrome2.mov

mchrome-bug3.mov

aimane-chnaif · 2023-06-25T15:31:09Z

src/components/AttachmentView.js

@@ -35,7 +35,9 @@ const propTypes = {
    /** Flag to show the loading indicator */
    shouldShowLoadingSpinnerIcon: PropTypes.bool,

+    /** Should focus to the password input  */


This is the purpose. The main meaning of this prop is to check if this view is active and fully visible on the screen so add it as well.

Got it. Thanks

aimane-chnaif · 2023-06-25T15:39:00Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

The fixes are not working at all because of this known bug - #17723
So should not be a regression. (videos)

Mobile Web - Safari

msafari.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

aimane-chnaif

@MariaHCD all yours!

MariaHCD

LGTM!

OSBotify · 2023-06-26T15:28:49Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-06-26T21:06:31Z

🚀 Deployed to staging by https://github.com/MariaHCD in version: 1.3.33-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-06-28T14:06:55Z

🚀 Deployed to production by https://github.com/thienlnam in version: 1.3.33-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

dukenv0307 added 6 commits June 12, 2023 22:57

fix: move comment

8746656

fix: update

909d7c9

merge main

9556f85

merge main

2357c3f

remove redundant

308e450

remove redundant

86f29aa

dukenv0307 marked this pull request as ready for review June 23, 2023 04:42

dukenv0307 requested a review from a team as a code owner June 23, 2023 04:42

melvin-bot bot requested review from aimane-chnaif and removed request for a team June 23, 2023 04:42

dukenv0307 mentioned this pull request Jun 23, 2023

[HOLD for payment 2023-07-05] [$2000] iOS - Keyboard does not hide when switching between attachments with focused password input field #19156

Closed

6 tasks

dukenv0307 changed the title ~~Fix/19156~~ Fix/19156: Keyboard does not hide when switching between attachments with focused password input field Jun 23, 2023

aimane-chnaif reviewed Jun 25, 2023

View reviewed changes

src/components/AttachmentView.js Show resolved Hide resolved

src/components/PDFView/PDFPasswordForm.js Show resolved Hide resolved

src/components/PDFView/PDFPasswordForm.js Outdated Show resolved Hide resolved

src/components/PDFView/pdfViewPropTypes.js Show resolved Hide resolved

add comment for prop

388bba0

aimane-chnaif reviewed Jun 25, 2023

View reviewed changes

update comment

e02647e

aimane-chnaif approved these changes Jun 25, 2023

View reviewed changes

melvin-bot bot requested a review from MariaHCD June 25, 2023 15:39

MariaHCD approved these changes Jun 26, 2023

View reviewed changes

MariaHCD merged commit 7549b58 into Expensify:main Jun 26, 2023

OSBotify mentioned this pull request Jun 26, 2023

Deploy Checklist: New Expensify 2023-06-26 #21650

Closed

23 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix/19156: Keyboard does not hide when switching between attachments with focused password input field #21367

Fix/19156: Keyboard does not hide when switching between attachments with focused password input field #21367

dukenv0307 commented Jun 23, 2023 •

edited

Loading

melvin-bot bot commented Jun 23, 2023

aimane-chnaif left a comment

aimane-chnaif commented Jun 25, 2023 •

edited

Loading

aimane-chnaif Jun 25, 2023

dukenv0307 Jun 25, 2023

aimane-chnaif commented Jun 25, 2023

aimane-chnaif left a comment

MariaHCD left a comment

OSBotify commented Jun 26, 2023

OSBotify commented Jun 26, 2023

OSBotify commented Jun 28, 2023

Fix/19156: Keyboard does not hide when switching between attachments with focused password input field #21367

Fix/19156: Keyboard does not hide when switching between attachments with focused password input field #21367

Conversation

dukenv0307 commented Jun 23, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jun 23, 2023

aimane-chnaif left a comment

Choose a reason for hiding this comment

aimane-chnaif commented Jun 25, 2023 • edited Loading

aimane-chnaif Jun 25, 2023

Choose a reason for hiding this comment

dukenv0307 Jun 25, 2023

Choose a reason for hiding this comment

aimane-chnaif commented Jun 25, 2023

Reviewer Checklist

Screenshots/Videos

aimane-chnaif left a comment

Choose a reason for hiding this comment

MariaHCD left a comment

Choose a reason for hiding this comment

OSBotify commented Jun 26, 2023

OSBotify commented Jun 26, 2023

OSBotify commented Jun 28, 2023

dukenv0307 commented Jun 23, 2023 •

edited

Loading

aimane-chnaif commented Jun 25, 2023 •

edited

Loading