-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove timezone migration #2115
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, LGTM. This PR is essentially just a revert of https://github.com/Expensify/Expensify.cash/pull/2040/files
For some reason I am unable to record my screen at the moment but I can confirm that this works on staging |
Got screen recording working 🎉 Screen.Recording.2021-03-26.at.2.41.51.PM.mov |
Nice! Need me to test it on my side too? |
Can't hurt 😅 I'd rather be safe than sorry here |
|
@isagoico While that's not good, it looks to me like you're using the production website |
Yep I think the production "set up password" link is broken. I also updated on the staging results for this one here #2040 (comment) |
Details
Removes a migration that was causing issues in the following PR: #2040
Fixed Issues
Fixes https://github.com//pull/2040#issuecomment-808354538Tests/QA
myPersonalDetails
myPersonalDetails
so that it's a string like soOLD
NEW
Tested On
Screenshots
N/A no UI changes