feat req: increase composer's height to 48px

[daraksha-dk]

Details

#15819 (comment)
Increased the composer's height to 48px and the Send button's size to 40px.

Fixed Issues

$ #15819
PROPOSAL: #15819 (comment)

Tests

1. Open the app
2. Go to any chat
3. Verify that the height of composer is 48px
4. Verify that the size of Send and Emoji button is 40x40
5. Verify that Actions icon's size is 32x40 ("+")

• Verify that no errors appear in the JS console

Offline tests

QA Steps

1. Open the app
2. Go to any chat
3. Verify that the height of composer is 48px
4. Verify that the size of Send and Emoji button is 40x40
5. Verify that Actions icon's size is 32x40 ("+")

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-06-20.at.10.12.18.PM.mov

Mobile Web - Chrome

Screen.Recording.2023-06-20.at.10.39.36.PM.mov

Mobile Web - Safari

Screen.Recording.2023-06-20.at.9.59.44.PM.mov

Desktop

Screen.Recording.2023-06-20.at.10.33.22.PM.mov

iOS

Screen.Recording.2023-06-20.at.10.16.38.PM.mov

Android

Screen.Recording.2023-06-20.at.10.36.17.PM.mov

[melvin-bot]

@sobitneupane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[sobitneupane]

Screenshots/Videos

Web

Screen.Recording.2023-06-21.at.11.21.17.mov

Mobile Web - Chrome

Screen.Recording.2023-06-21.at.11.25.03.mov

Mobile Web - Safari

Screen.Recording.2023-06-21.at.11.29.42.mov

Desktop

Screen.Recording.2023-06-21.at.11.26.30.mov

iOS

Screen.Recording.2023-06-21.at.11.31.03.mov

Android

Screen.Recording.2023-06-21.at.11.33.08.mov

[sobitneupane]

@daraksha-dk
Meanwhile there are still some issues:

Inconsistent change in height on adding new line.

Screen.Recording.2023-06-21.at.11.41.58.mov

[daraksha-dk]

Screen.Recording.2023-06-21.at.4.41.22.PM.mov

Sorry for missing that. Fixed now!

cc: @sobitneupane

[shawnborton]

Nice, this looks pretty good to me.

[shawnborton]

Can you spin up a test build when you are ready so I can try it on my end too?

[daraksha-dk]

Can you spin up a test build when you are ready so I can try it on my end too?

@shawnborton I think we need to apply "Ready to build" label on this PR to get those builds

[shawnborton]

Okay cool, let's try it!

[daraksha-dk]

Not sure why it didn't work 🤔. Maybe @mountiny can help us 🙏.

[MariaHCD]

Tried to get those builds but no luck for me either :(

[sobitneupane]

Composer height increases only by 4px on adding first new line. Padding decreases.

Screen.Recording.2023-06-22.at.09.39.17.mov

Similar was the base before as well. But the decrease in padding was quite small and looks as if it is expected.

Before the change:

Screen.Recording.2023-06-22.at.09.43.45.mov

What should we do for this @shawnborton?

I also noticed that on adding second line, the padding again changes (may to adjust Expand button) and changes again on adding third line. It is an existing issue.

[daraksha-dk]

Composer height increases only by 4px on adding first new line. Padding decreases.

I think this behaviour is expected because the increase in height is determined by the lineHeight parameter. Previously, for a single line, the remaining space after accounting for borders and padding was 28px, while for two lines with a lineHeight of 20px, it was 40px. Currently, the remaining space for a single line is 36px, resulting in a total height of 48px, and for two lines, it remains at 40px, resulting in a total height of 52px.
Not sure if padding decreases anywhere though, I think the padding stays the same at 10px vertically.

Previously: (before this changes)

For single line => 2px borders + 10px padding + 28px remaining => 40px
and for two lines => 2px borders + 10px padding + 40px remaining (lineHeight is 20px) => 52px

Currently: (after the changes)

For single line => 2px borders + 10px padding + 36px remaining => 48px
and for two lines => 2px borders + 10px padding + 40px remaining => 52px

I also noticed that on adding second line, the padding again changes (may to adjust Expand button) and changes again on adding third line. It is an existing issue.

I think we meant height here and yes it is changing to accommodate both the "expand" and "actions" buttons in the composer. It's happening in production as well.

cc: @sobitneupane @shawnborton

[mountiny]

Build is running here https://github.com/Expensify/App/actions/runs/5343785571

[OSBotify]

🧪🧪 Use the links below to test this build in android and iOS. Happy testing! 🧪🧪

android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/21131/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/21131/index.html
desktop 💻	web 🕸️
❌ FAILED ❌	https://21131.pr-testing.expensify.com
The QR code can't be generated, because the Desktop build failed

[daraksha-dk]

Builds are ready for testing!

Desktop one failed maybe due to some resource problem as shown below:

cc: @sobitneupane @MariaHCD @shawnborton

[shawnborton]

Tested quickly and I think this feels pretty good to me.

[MariaHCD]

Code LGTM! Over to you, @sobitneupane

[sobitneupane]

Screenshots/Videos

Web

Screen.Recording.2023-06-23.at.14.22.15.mov

Mobile Web - Chrome

Screen.Recording.2023-06-23.at.15.05.19.mov

Mobile Web - Safari

Screen.Recording.2023-06-23.at.14.33.41.mov

Desktop

Screen.Recording.2023-06-23.at.14.30.12.mov

iOS

Screen.Recording.2023-06-23.at.15.03.53.mov

Android

Screen.Recording.2023-06-23.at.15.13.01.mov

[mountiny]

The desktop build failure is unrealted.

[sobitneupane]

@shawnborton Are we okay with following changes?

Following small changes are resulted by this PR.

1. Add action '+' moves slightly up on adding first new line and moves slightly down on adding second new line.

Screen.Recording.2023-06-23.at.23.11.05.mov

We tired to solve this issue by changing height of Add action '+' but it resulted #21131 (comment) issue.

2. On adding new line Height of the composer changes in following pattern:

   With change in this PR:
   48px -> 52 px -> 78 px -> 92px -> +20 on addition of each line afterward

   Previously:
   40px -> 52px -> 78px -> 92px -> +20 on addition of each line afterward.

[daraksha-dk]

In addition to above comment, there are two more ways to handle this.

(3) Applying 40px height only when single icon + is present

Con: + is flickering when we go to the third line.

third.mp4

(4) Apply paddingBottom of 10px for + icon - This will help the behaviour stay as similar to before as possible.

Con: The symmetry of the design is disrupted on the third line and beyond, due to the bottom being 4 pixels longer. To rectify this, an option could be to add 4 pixels to the top as well to achieve symmetry but that will further increase the height of composer.

fourth.mp4

cc: @shawnborton @sobitneupane

[shawnborton]

Add action '+' moves slightly up on adding first new line and moves slightly down on adding second new line.

I think this is fine and is expected

[shawnborton]

(4) Apply paddingBottom of 10px for + icon - This will help the behaviour stay as similar to before as possible.
Con: The symmetry of the design is disrupted on the third line and beyond, due to the bottom being 4 pixels longer. To rectify this, an option could be to add 4 pixels to the top as well to achieve symmetry but that will further increase the height of composer.

I can't quite understand this. The video you shared for this seems to look fine to me?

[daraksha-dk]

(4) Apply paddingBottom of 10px for + icon - This will help the behaviour stay as similar to before as possible.
Con: The symmetry of the design is disrupted on the third line and beyond, due to the bottom being 4 pixels longer. To rectify this, an option could be to add 4 pixels to the top as well to achieve symmetry but that will further increase the height of composer.

I can't quite understand this. The video you shared for this seems to look fine to me?

Here, you can see that the bottom space is bigger than the top.

[daraksha-dk]

@sobitneupane PR updated!

[sobitneupane]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified tests pass on all platforms & I tested again on:
  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

[MariaHCD]

LGTM, leaving the final review to @shawnborton

[shawnborton]

Looks good to me too, but where can I find the most up-to-date screenshots? Especially ones that show the textarea expanding to multi lines. If we have new screenshots, let's add them to the original comment please!

[daraksha-dk]

@shawnborton

but where can I find the most up-to-date screenshots?

Since no further changes were made, the screenshots in the OP and here should be fine

Especially ones that show the textarea expanding to multi lines

You can refer to these screenshots for better clarity

[shawnborton]

Sounds good, I'll merge this one then.

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by https://github.com/shawnborton in version: 1.3.33-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by https://github.com/thienlnam in version: 1.3.33-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅