Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix user cannot remove the description #20544

Merged
merged 6 commits into from
Jun 12, 2023
Merged

Fix user cannot remove the description #20544

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6971a3b
fix user cannot remove the description
dukenv0307 Jun 9, 2023
aa8b3aa
fix description is remove when editing title
dukenv0307 Jun 9, 2023
fe045de
optimize edit task function
dukenv0307 Jun 10, 2023
3e36a6c
clear condition
dukenv0307 Jun 10, 2023
a8dbdfe
fix lint
dukenv0307 Jun 10, 2023
a1726d5
optimize description
dukenv0307 Jun 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/libs/actions/Task.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import ROUTES from '../../ROUTES';
import CONST from '../../CONST';
import DateUtils from '../DateUtils';
import * as UserUtils from '../UserUtils';
import _ from 'underscore';

/**
* Clears out the task info from the store
Expand Down Expand Up @@ -311,7 +312,7 @@ function editTaskAndNavigate(report, ownerEmail, {title, description, assignee})
key: `${ONYXKEYS.COLLECTION.REPORT}${report.reportID}`,
value: {
reportName,
description: (description !== undefined ? description : report.description).trim(),
description: (!_.isUndefined(description) ? description : report.description).trim(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dukenv0307 Can we follow DRY code here , should be extracted at the top below line 292

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fedirjh I updated.

managerEmail: assignee || report.managerEmail,
},
},
Expand Down Expand Up @@ -366,7 +367,7 @@ function editTaskAndNavigate(report, ownerEmail, {title, description, assignee})
{
taskReportID: report.reportID,
title: reportName,
description: (description !== undefined ? description : report.description).trim(),
description: (!_.isUndefined(description) ? description : report.description).trim(),
assignee: assignee || report.managerEmail,
editedTaskReportActionID: editTaskReportAction.reportActionID,
assigneeChatReportActionID: optimisticAssigneeAddComment ? optimisticAssigneeAddComment.reportAction.reportActionID : 0,
Expand Down