Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup App for TypeScript #20179
Setup App for TypeScript #20179
Changes from 83 commits
9e32fbe
8980fb4
4012d0b
3d69491
73c4df8
51fcbe5
0efb8a7
185e166
fb48821
050782b
6ac0040
7d872b5
503c540
9879098
e5f39ee
a29cdd3
4b56d1d
ef87729
8e6e484
2d31bc0
7bd0a30
9bd7b19
9e81d51
6fb4e7c
69f1ef2
3407827
0fb7d77
14088b6
85a14c5
f88861b
f396d4a
fc6aeb7
e566784
24b5bb2
de5afda
c505088
e64c690
acd3098
9e5196f
d1298a7
6dbae89
8765e68
fb467c0
bc150f3
a0ed333
5d4c44a
e93e640
0cbe8fe
8e55e56
e2422f2
caef64c
9be17fd
e868b9d
6e0a38d
06c8c9b
f725a05
54066d3
0fb0b5d
099fe59
d0180eb
f9d92dd
72b2c78
a1f6664
466505c
7d5da15
6f6866a
e723cdd
0692778
f3034a7
4e31da0
c1e2209
238d241
7a30be4
8e3eefc
d08e3d4
f48892e
404cefb
9b3720a
dd99141
fade5bc
9058dad
d234548
a443163
9088b21
b9cbce6
ba028fd
2c0d3e6
e70832e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The doc for the rule says that this rule doesn't take any arguments...
does specifying
touchables
work here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good question! I asked Michał from SWM who added it to
.eslintrc.js
file.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without
touchables
option it doesn't work, the weird part is that it isn't documented, but I found the code responsible for that.has-valid-accessibility-descriptors rule implementation calls isTouchable function which actually uses the
touchables
option 😄There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
touchables
option is documented but only for other rules here. Probably they forgot to includereact-native-a11y/has-valid-accessibility-descriptors
🤷