Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix width of report header on mobile web #2001

Merged
merged 1 commit into from
Mar 23, 2021
Merged

Conversation

tgolen
Copy link
Contributor

@tgolen tgolen commented Mar 22, 2021

@NikkiWines I was having a hard time nailing this down, and I ended up doing a git bisect and found this was originally caused by the change here: 4ce6b36

Details

I believe that just adding flex: 1 fixes the width problem so that everything stays within the view.

Fixed Issues

Fixes https://github.com/Expensify/Expensify/issues/157960

Fixes https://github.com/Expensify/Expensify/issues/157960

Tests

  1. Start a group chat with 4 people
  2. Verify that the report page is shown properly and the name of the report is truncated with "..." when the screen has a narrow width

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

image

Mobile Web

image

Desktop

image
image

iOS

image

Android

image

@tgolen tgolen requested a review from a team March 22, 2021 23:06
@tgolen tgolen self-assigned this Mar 22, 2021
@botify botify requested review from Luke9389 and removed request for a team March 22, 2021 23:06
@NikkiWines
Copy link
Contributor

Ohh interesting one - sorry to have introduced it!

@Luke9389
Copy link
Contributor

Dude, yes! I'm glad to see this fixed, it was bugging me 😄

@Luke9389 Luke9389 merged commit f6cb6ce into master Mar 23, 2021
@Luke9389 Luke9389 deleted the tgolen-fix-report-title branch March 23, 2021 02:13
@github-actions github-actions bot locked and limited conversation to collaborators Mar 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants