-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/regression 18110 composer should have the same height in other platforms #19516
Merged
Merged
Changes from 9 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
009ea52
Fix regression
dukenv0307 62c1cb9
fix check native system
dukenv0307 d68d65b
fix recalculate padding vertical and check platform
dukenv0307 c6f2bb2
fix eslint
dukenv0307 cf53026
add function to get container style of compose
dukenv0307 3aef299
format code
dukenv0307 70c2cd5
fix name variable
dukenv0307 2b40097
add comment
dukenv0307 da56416
resolve conflict
dukenv0307 c00d26e
fix move calculate padding to style utils
dukenv0307 24ca23f
Update src/styles/getContainerComposeStyles/index.js
dukenv0307 42860a0
merge main
dukenv0307 93566fe
merge main
dukenv0307 dded931
fix lint
dukenv0307 79df68d
merge main
dukenv0307 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
import styles from '../styles'; | ||
// we need to set paddingVertical = 0 on the web to avoid App displays normal pointer on some parts of compose box when not in focus | ||
dukenv0307 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
export default () => [styles.textInputComposeSpacing, styles.textInputComposeBorder, {paddingVertical: 0}]; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
import styles from '../styles'; | ||
|
||
export default () => [styles.textInputComposeSpacing, styles.textInputComposeBorder]; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be moved to styles? I think it doesn't make sense to have styling added as code in
render
. Better to get it from styles.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just moved it to StyleUtils. @mananjadhav please check again