Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update internal dev partnerID and password #1893

Merged
merged 1 commit into from
Mar 19, 2021

Conversation

timszot
Copy link
Contributor

@timszot timszot commented Mar 18, 2021

<If necessary, assign reviewers that know the area or changes well. Feel free to tag any additional reviewers you see fit.>

Details

Updates the example .env file to use the chat-expensify-com partner name and password.
cc: @AndrewGable @NikkiWines

Fixed Issues

Fixes https://github.com/Expensify/Expensify/issues/157714

Tests

This requires a new partner row added to your local VMs partners table. This can be added with the following steps:

  1. run Expensidev/scripts/sql.sh
  2. run this query: INSERT OR IGNORE INTO partners ( created, partnerID, partnerName, partnerPassword, partnerKey ) VALUES ( '2021-03-18 00:00:00', 83, 'chat-expensify-com', 'DD1431EB9E11F0071EC05C24E9CB2FD595B1ED75', 'asdf,fdsa');

Then edit your .env file using the new values from .env.example in the PR.

  1. run npm run web
    1a. sign out of any existing accounts
  2. sign in with a new email so a new account gets created
  3. Validate the account with Expensidev/scripts/clitools.sh validator:account
  4. Go back to e.cash and verify you can sign in with the new account and dev password
  5. sign out
  6. sign back in with an existing account and verify it works

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

@timszot timszot requested a review from a team March 18, 2021 23:51
@timszot timszot self-assigned this Mar 18, 2021
@botify botify requested review from marcaaron and removed request for a team March 18, 2021 23:51
@timszot
Copy link
Contributor Author

timszot commented Mar 18, 2021

The Auth PR to add this partner when creating a new VM DB is here.

Once merged I'll send out an email detailing the change and the steps required to update everyone's VM DB with the new partner row.

Copy link
Contributor

@marcaaron marcaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcaaron
Copy link
Contributor

The password here in the .env.example is e21965746fd75f82bb66 but the one in the Auth PR is DD1431EB9E11F0071EC05C24E9CB2FD595B1ED75

Is that right?

I'm having trouble logging in on e.cash local after applying these changes.

@marcaaron
Copy link
Contributor

Ok looks good and tests well for me. There is one quick caveat that my partners table had an entry for greenhouse using the the same partnerID so I had to update it to get this working.

@marcaaron marcaaron merged commit 0b0ff85 into master Mar 19, 2021
@marcaaron marcaaron deleted the timszot_updateDevPartner branch March 19, 2021 18:05
@github-actions github-actions bot locked and limited conversation to collaborators Mar 19, 2021
@timszot
Copy link
Contributor Author

timszot commented Mar 19, 2021

There is one quick caveat that my partners table had an entry for greenhouse using the the same partnerID so I had to update it to get this working.

I'll make sure to add a bit about this to the email I'll send out

@marcaaron
Copy link
Contributor

🎉 thanks for this change!

@isagoico
Copy link

Hello @marcaaron! This one looks like it's internal QA. Can you confirm? If so, let me know when it's tested so I can check it off the deploy list.

@marcaaron
Copy link
Contributor

This only affects development so I think can be checked off.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants