-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update internal dev partnerID and password #1893
Conversation
The Auth PR to add this partner when creating a new VM DB is here. Once merged I'll send out an email detailing the change and the steps required to update everyone's VM DB with the new partner row. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The password here in the Is that right? I'm having trouble logging in on e.cash local after applying these changes. |
Ok looks good and tests well for me. There is one quick caveat that my |
I'll make sure to add a bit about this to the email I'll send out |
🎉 thanks for this change! |
Hello @marcaaron! This one looks like it's internal QA. Can you confirm? If so, let me know when it's tested so I can check it off the deploy list. |
This only affects development so I think can be checked off. |
<If necessary, assign reviewers that know the area or changes well. Feel free to tag any additional reviewers you see fit.>
Details
Updates the example
.env
file to use thechat-expensify-com
partner name and password.cc: @AndrewGable @NikkiWines
Fixed Issues
Fixes https://github.com/Expensify/Expensify/issues/157714Tests
This requires a new partner row added to your local VMs
partners
table. This can be added with the following steps:Expensidev/scripts/sql.sh
INSERT OR IGNORE INTO partners ( created, partnerID, partnerName, partnerPassword, partnerKey ) VALUES ( '2021-03-18 00:00:00', 83, 'chat-expensify-com', 'DD1431EB9E11F0071EC05C24E9CB2FD595B1ED75', 'asdf,fdsa');
Then edit your
.env
file using the new values from.env.example
in the PR.npm run web
1a. sign out of any existing accounts
Expensidev/scripts/clitools.sh validator:account
Tested On