Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove slack notifications for QA #1776

Merged
merged 1 commit into from
Mar 23, 2021
Merged

Remove slack notifications for QA #1776

merged 1 commit into from
Mar 23, 2021

Conversation

iwiznia
Copy link
Contributor

@iwiznia iwiznia commented Mar 15, 2021

<If necessary, assign reviewers that know the area or changes well. Feel free to tag any additional reviewers you see fit.>

Details

Fixed Issues

https://github.com/Expensify/Expensify/issues/157452

Tests

None, we can check the notifications are gone when we merge it

@iwiznia iwiznia self-assigned this Mar 15, 2021
@iwiznia iwiznia requested a review from a team as a code owner March 15, 2021 17:14
@botify botify requested review from alex-mechler and removed request for a team March 15, 2021 17:15
roryabraham
roryabraham approved these changes Mar 15, 2021
View reviewed changes
Copy link
Contributor

@roryabraham roryabraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, this looks right to me 👍

alex-mechler
alex-mechler approved these changes Mar 15, 2021
View reviewed changes
Copy link
Contributor

@alex-mechler alex-mechler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but holding off merging until we see if QA uses them

@roryabraham
Copy link
Contributor

I think they said they are using them, so we'll hold off until we have the new checklists in place (should be very soon, today or tomorrow).

@roryabraham roryabraham changed the title Remove slack notifications for QA [HOLD] Remove slack notifications for QA Mar 15, 2021
@roryabraham roryabraham changed the title [HOLD] Remove slack notifications for QA Remove slack notifications for QA Mar 23, 2021
@roryabraham
Copy link
Contributor

Merging this, they shouldn't need these anymore.

@roryabraham roryabraham merged commit 1560869 into master Mar 23, 2021
@roryabraham roryabraham deleted the ionatan_remove_slack_notification branch March 23, 2021 16:02
@OSBotify OSBotify mentioned this pull request Mar 23, 2021
Closed
85 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roryabraham roryabraham roryabraham approved these changes

@alex-mechler alex-mechler alex-mechler approved these changes

Assignees

@iwiznia iwiznia

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iwiznia @roryabraham @alex-mechler