-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix stale data remaining in storage after Onyx.clear() is called #13886
Conversation
Reviewer Checklist
Screenshots/VideosWeb13886.Web.movMobile Web - Chrome13886.mWeb-Chrome.movMobile Web - Safari13886.mWeb-Safari.movDesktop13886.Desktop.moviOS13886.iOS.movAndroid13886.Android.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor type checks fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! (except the lint error)
Co-authored-by: Luthfi <[email protected]>
Thanks, fixed! |
@tgolen Can you please share any account which has over 1000 reports on it, we only have one with 641 reports which is our domain applause account. |
Hm, I don't think I can, no. I don't know of any accounts. It should probably work for your account with |
🚀 Deployed to production by @AndrewGable in version: 1.2.55-0 🚀
|
Details
This PR is first a re-revert of #13758 and second, it fixes the performance issue (and race condition) from #13884. With this PR, when someone is signing out, and
Onyx.clear()
is called, there is no chance for stale data to remain in Onyx.Fixed Issues
$ #13884
Tests
Web/Desktop platforms
Native Platforms
Nothing changes on Native, and you can't check storage on Native, so just do this basic regression test:
Offline tests
None. This requires you to be online.
QA Steps
Same as the above
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.Screenshots/Videos
Web
Mobile Web - Chrome
Mobile Web - Safari
Desktop
iOS
Android