-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core Branding Add New Icons #12796
Core Branding Add New Icons #12796
Conversation
I'll work on some of the missing icons and provide them here. There are actually some of the missing ones that are in the .zip file but I think I just did not name them correctly (like flash.svg instead of bolt.svg, gear.svg instead of cog.svg, etc) |
Here's a few more: |
apple, android, zoom, shadow, paypal, google-meet, confetti-pop, lets-chat, image-crop-mask don't need to be changed welcome-screenshot, cascading-cards (both), pin-circle can be deleted (not used anymore) circle-hourglass can be replaced with just the hourglass icon So I think that just leaves clipboard, new workspace, example-check (both), and default workspace? |
Here is a new-workspace svg... note that I made it 40x40 as I think that is the correct size for these kinds of things, in case you need to adjust anything code-wise to support that (original looks wider than it is tall, which seems strange): new-workspace.svg.zip And here is a default workspace avatar: workspace-default-avatar.svg.zip Will work on the check images, and TCW is working on the other missing ones (clipboard, link-add). |
Here are new example check images (not the BG is transparent like before, and the height might have changed slightly? I think these should be shown at 200x48?) |
Here are some new, larger check images to try: CheckImages.zip |
Could I get those with transparent BG? |
Oops, let's try that again: CheckImages.zip Will keep you posted on link-copy and clipboard, otherwise I think the rest of your list doesn't need to be updated. |
Agree! One thing I am noticing, what about the announce room icon and the admins room icon? Where are those found? |
Yeah, Daniel's PR will effectively replace all of those. |
Here's 4 more, though looks like we might only be using two of these in the app... |
Woot! I think that the upload link might be broken, could you try reuploading it? |
@aimane-chnaif @nkuoch One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosWebMobile Web - ChromeMobile Web - SafariDesktopiOSAndroid |
@mollfpr @Julesssss One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
oops wasn't thinking- PR review checklist is done, but let me know if either of you want to do a final pass! Otherwise good to merge |
We don't need to attach Screenshots/Videos in Reviewer Checklist for this PR? |
@aimane-chnaif yes we should |
@aimane-chnaif did you want to do screenshots for this PR? I'd like to get it merged |
yes I will complete review and add screenshots today |
Merging as we have C+ and 3 internal engineer reviews. |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
@grgia @shawnborton @Luke9389 Anything specific you want us to QA in this PR? |
🚀 Deployed to staging by @Julesssss in version: 1.2.34-0 🚀
|
🚀 Deployed to production by @luacmartins in version: 1.2.34-1 🚀
|
@@ -2,7 +2,7 @@ | |||
permalink: /404.html | |||
--- | |||
<div class="centered-content with-lhn"> | |||
<img class="icon" src="/assets/images/circle-hourglass.svg" /> | |||
<img class="icon" src="/assets/images/hourglass.svg" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/assets/images/hourglass.svg
was not existing on docs
Details
Replace Icons in New Dot for WAQ Branding
Fixed Issues
$ #12442
Tests
Offline tests
QA Steps
PR Author Checklist
I linked the correct issue in the
### Fixed Issues
section aboveI wrote clear testing steps that cover the changes made in this PR
Tests
sectionOffline steps
sectionQA steps
sectionI included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
toggleReport
and notonIconClick
)src/languages/*
filesWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedIf a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like
Avatar
, I verified the components usingAvatar
are working as expected)I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)If a new CSS style is added I verified that:
StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like
Avatar
is modified, I verified thatAvatar
is working as expected in all cases)If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.
PR Reviewer Checklist
The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
).src/languages/*
filesWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
have been tested & I retested again)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Screenshots
Web
Mobile Web - Chrome
Mobile Web - Safari
Screen.Recording.2022-11-22.at.4.21.42.PM.mov
Desktop
Screen.Recording.2022-11-22.at.4.19.43.PM.mov
iOS
Screen.Recording.2022-11-22.at.4.21.11.PM.mov
Android