Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core Branding Add New Icons #12796

Merged
merged 13 commits into from
Nov 29, 2022
Merged

Core Branding Add New Icons #12796

merged 13 commits into from
Nov 29, 2022

Conversation

grgia
Copy link
Contributor

@grgia grgia commented Nov 16, 2022

Details

Replace Icons in New Dot for WAQ Branding

Fixed Issues

$ #12442

Tests

  • Verify that no errors appear in the JS console
  • Verify all icons look correct

Offline tests

QA Steps

  • Verify that no errors appear in the JS console
  • Verify all icons look correct during normal regression testing

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above

  • I wrote clear testing steps that cover the changes made in this PR

    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms

  • I ran the tests on all platforms & verified they passed on:

    • iOS / native
    • Android / native
    • iOS / Safari
    • Android / Chrome
    • MacOS / Chrome
    • MacOS / Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)

  • I followed proper code patterns (see Reviewing the code)

    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product was added in all src/languages/* files
    • I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers

  • I followed the guidelines as stated in the Review Guidelines

  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)

  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)

  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such

  • If a new component is created I verified that:

    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:

    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)

  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.

  • I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

PR Reviewer Checklist

The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for expected offline behavior are in the Offline steps section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified tests pass on all platforms & I tested again on:
    • iOS / native
    • Android / native
    • iOS / Safari
    • Android / Chrome
    • MacOS / Chrome
    • MacOS / Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product was added in all src/languages/* files
    • I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots

Web

image

image

image

image

image

image

image

image

image

image

image

image

image

Mobile Web - Chrome

Mobile Web - Safari

Screen.Recording.2022-11-22.at.4.21.42.PM.mov

Desktop

Screen.Recording.2022-11-22.at.4.19.43.PM.mov

iOS

Screen.Recording.2022-11-22.at.4.21.11.PM.mov

Android

Screen Shot 2022-11-22 at 5 24 05 PM Screen Shot 2022-11-22 at 5 21 48 PM Screen Shot 2022-11-22 at 5 21 43 PM Screen Shot 2022-11-22 at 5 21 35 PM

@grgia grgia requested a review from shawnborton November 16, 2022 19:52
@shawnborton
Copy link
Contributor

I'll work on some of the missing icons and provide them here. There are actually some of the missing ones that are in the .zip file but I think I just did not name them correctly (like flash.svg instead of bolt.svg, gear.svg instead of cog.svg, etc)

@shawnborton
Copy link
Contributor

Here's a few more:
MoreIcons.zip

@grgia grgia self-assigned this Nov 17, 2022
@grgia
Copy link
Contributor Author

grgia commented Nov 17, 2022

Here's where I'm left:
Quick note- is the hourglass circle being replaced with just the hourglass?

Screen Shot 2022-11-16 at 5 44 10 PM

@shawnborton
Copy link
Contributor

apple, android, zoom, shadow, paypal, google-meet, confetti-pop, lets-chat, image-crop-mask don't need to be changed

welcome-screenshot, cascading-cards (both), pin-circle can be deleted (not used anymore)

circle-hourglass can be replaced with just the hourglass icon

So I think that just leaves clipboard, new workspace, example-check (both), and default workspace?

@shawnborton
Copy link
Contributor

Here is a new-workspace svg... note that I made it 40x40 as I think that is the correct size for these kinds of things, in case you need to adjust anything code-wise to support that (original looks wider than it is tall, which seems strange): new-workspace.svg.zip

And here is a default workspace avatar: workspace-default-avatar.svg.zip

Will work on the check images, and TCW is working on the other missing ones (clipboard, link-add).

@shawnborton
Copy link
Contributor

Here are new example check images (not the BG is transparent like before, and the height might have changed slightly? I think these should be shown at 200x48?)

ExampleCheckImages.zip

image

@grgia
Copy link
Contributor Author

grgia commented Nov 18, 2022

Whoops meant to put this here:
image
image

@grgia
Copy link
Contributor Author

grgia commented Nov 18, 2022

image

image

Hmm the routing number image is slightly blurry now
Screen Shot 2022-11-18 at 11 33 22 AM

@shawnborton
Copy link
Contributor

Here are some new, larger check images to try: CheckImages.zip

@grgia
Copy link
Contributor Author

grgia commented Nov 18, 2022

Could I get those with transparent BG?

@grgia
Copy link
Contributor Author

grgia commented Nov 18, 2022

Screen Shot 2022-11-18 at 11 43 05 AM

Also here's what we're currently left with

@shawnborton
Copy link
Contributor

Oops, let's try that again: CheckImages.zip

Will keep you posted on link-copy and clipboard, otherwise I think the rest of your list doesn't need to be updated.

@grgia
Copy link
Contributor Author

grgia commented Nov 18, 2022

Update, looks great!
image

@shawnborton
Copy link
Contributor

Agree!

One thing I am noticing, what about the announce room icon and the admins room icon? Where are those found?

@grgia
Copy link
Contributor Author

grgia commented Nov 18, 2022

Screen Shot 2022-11-18 at 12 10 13 PM

Nice catch, those are in images/avatars here!

@grgia
Copy link
Contributor Author

grgia commented Nov 18, 2022

Screen Shot 2022-11-18 at 12 12 24 PM

There's also product illustrations, I know Daniel added a few of these in his WIP PR, but is there an issue to replace all of these with our new illustrations?

@shawnborton
Copy link
Contributor

Yeah, Daniel's PR will effectively replace all of those.

@shawnborton
Copy link
Contributor

shawnborton commented Nov 21, 2022

Here's 4 more, though looks like we might only be using two of these in the app...
MoreIcons.zip

@grgia
Copy link
Contributor Author

grgia commented Nov 21, 2022

Woot! I think that the upload link might be broken, could you try reuploading it?

@melvin-bot melvin-bot bot requested a review from nkuoch November 22, 2022 23:31
@melvin-bot
Copy link

melvin-bot bot commented Nov 22, 2022

@aimane-chnaif @nkuoch One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@Luke9389
Copy link
Contributor

Luke9389 commented Nov 23, 2022

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified tests pass on all platforms & I tested again on:
    • iOS / native
    • Android / native
    • iOS / Safari
    • Android / Chrome
    • MacOS / Chrome
    • MacOS / Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product was added in all src/languages/* files
    • I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
Mobile Web - Chrome
Mobile Web - Safari
Desktop
iOS
Android

@grgia grgia changed the title [Hold] Core Branding Add New Icons Core Branding Add New Icons Nov 23, 2022
@grgia grgia requested review from a team and removed request for a team November 23, 2022 20:06
@melvin-bot melvin-bot bot requested review from Julesssss and mollfpr November 23, 2022 20:07
@melvin-bot
Copy link

melvin-bot bot commented Nov 23, 2022

@mollfpr @Julesssss One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@grgia
Copy link
Contributor Author

grgia commented Nov 23, 2022

oops wasn't thinking- PR review checklist is done, but let me know if either of you want to do a final pass! Otherwise good to merge

@aimane-chnaif
Copy link
Contributor

aimane-chnaif commented Nov 23, 2022

@aimane-chnaif @nkuoch One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

We don't need to attach Screenshots/Videos in Reviewer Checklist for this PR?

@Julesssss
Copy link
Contributor

We don't need to attach Screenshots/Videos in Reviewer Checklist for this PR?

@aimane-chnaif yes we should

@grgia
Copy link
Contributor Author

grgia commented Nov 28, 2022

@aimane-chnaif did you want to do screenshots for this PR? I'd like to get it merged

@aimane-chnaif
Copy link
Contributor

@aimane-chnaif did you want to do screenshots for this PR? I'd like to get it merged

yes I will complete review and add screenshots today

@aimane-chnaif
Copy link
Contributor

Screenshots/Videos

Web
web.mp4
Mobile Web - Chrome
mchrome.mp4
Mobile Web - Safari
msafari.mp4
Desktop
desktop.mp4
Android
android.mp4
iOS (light theme)

about
chats archived
chats
connect bank1
details
fab menu
payments
popover
reimburse expenses
report
security
settings
workspace
workspaces

iOS (dark theme)

about
chats archived
chats
connect bank1
details
fab menu
payments
popover
reimburse expenses
report
security
settings
workspace
workspaces

NOTE: Please check iOS (light theme) and iOS (dark theme) for screenshots in detail. Other platforms are videos.

@Julesssss
Copy link
Contributor

Merging as we have C+ and 3 internal engineer reviews.

@Julesssss Julesssss merged commit 20c9936 into main Nov 29, 2022
@Julesssss Julesssss deleted the georgia-new-icons branch November 29, 2022 14:29
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@mvtglobally
Copy link

@grgia @shawnborton @Luke9389 Anything specific you want us to QA in this PR?

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @Julesssss in version: 1.2.34-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Dec 1, 2022

🚀 Deployed to production by @luacmartins in version: 1.2.34-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@@ -2,7 +2,7 @@
permalink: /404.html
---
<div class="centered-content with-lhn">
<img class="icon" src="/assets/images/circle-hourglass.svg" />
<img class="icon" src="/assets/images/hourglass.svg" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assets/images/hourglass.svg was not existing on docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants