-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expense - Changing expense report name and saving app crashes #54717
Comments
Triggered auto assignment to @MitchExpensify ( |
Edited by proposal-police: This proposal was edited at 2025-01-01 13:14:56 UTC. ProposalPlease re-state the problem that we are trying to solve in this issue.Changing expense report name and saving app crashes What is the root cause of that problem?We are missing fallback ID in the App/src/components/ParentNavigationSubtitle.tsx Lines 30 to 35 in e5108a1
Looking deeper, when the report name is updated, the system continues to send a What changes do you think we should make in order to solve the problem?We can add fallback ID to useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${parentReportID || CONST.DEFAULT_NUMBER_ID}`) or we can add a fallback ID to prop parentReportID=CONST.DEFAULT_NUMBER_ID If this is not urgent, we can also fix it via the backend What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?N/A What alternative solutions did you explore? (Optional)N/A |
rajan123 Your proposal will be dismissed because you did not follow the proposal template. |
guitz Your proposal will be dismissed because you did not follow the proposal template. |
@linhvovan29546's proposal makes sense. I can help move this forward @MitchExpensify as C+. |
In fact, this is a backend issue. However, we prevent crashing behavior by add fallback ID Update root cause #54717 (comment) |
The same RCA with #53547. |
@MitchExpensify Yes. |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 9.0.80-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
Issue reported by: Applause Internal Team
Device used: Redmi note 10s Android 13
App Component: Money Requests
Action Performed:
Expected Result:
Changing expense report name and saving app must not crash.
Actual Result:
Changing expense report name and saving app crashes
Workaround:
Unknown
Platforms:
Screenshots/Videos
Bug6704748_1735718141545!Crash.txt
Bug6704748_1735718141522.Screenrecorder-2025-01-01-13-07-06-647_compress_1.mp4
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: