Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expense - Changing expense report name and saving app crashes #54717

Closed
2 of 8 tasks
IuliiaHerets opened this issue Jan 1, 2025 · 9 comments
Closed
2 of 8 tasks

Expense - Changing expense report name and saving app crashes #54717

IuliiaHerets opened this issue Jan 1, 2025 · 9 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@IuliiaHerets
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.80-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
Issue reported by: Applause Internal Team
Device used: Redmi note 10s Android 13
App Component: Money Requests

Action Performed:

  1. Go to https://staging.new.expensify.com/home
  2. Tap fab -- new workspace
  3. Go to self DM
  4. Create an expense
  5. Select share it with accountant from whisper
  6. Complete the flow selecting workspace and a user
  7. Open expense in workspace chat
  8. Tap header
  9. Change the expense report name and save

Expected Result:

Changing expense report name and saving app must not crash.

Actual Result:

Changing expense report name and saving app crashes

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6704748_1735718141545!Crash.txt

Bug6704748_1735718141522.Screenrecorder-2025-01-01-13-07-06-647_compress_1.mp4

View all open jobs on GitHub

@IuliiaHerets IuliiaHerets added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jan 1, 2025
Copy link

melvin-bot bot commented Jan 1, 2025

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@linhvovan29546
Copy link
Contributor

linhvovan29546 commented Jan 1, 2025

Edited by proposal-police: This proposal was edited at 2025-01-01 13:14:56 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Changing expense report name and saving app crashes

What is the root cause of that problem?

We are missing fallback ID in the ParentNavigationSubtitle component

function ParentNavigationSubtitle({parentNavigationSubtitleData, parentReportActionID, parentReportID = '', pressableStyles}: ParentNavigationSubtitleProps) {
const styles = useThemeStyles();
const {workspaceName, reportName} = parentNavigationSubtitleData;
const {isOffline} = useNetwork();
const {translate} = useLocalize();
const [report] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${parentReportID}`);

Looking deeper, when the report name is updated, the system continues to send a getMissingOnyxMessages request. In the Onyx data, the parentReportID is null

Detail Screenshot 2025-01-01 at 8 54 12 PM

What changes do you think we should make in order to solve the problem?

We can add fallback ID to useOnyx(${ONYXKEYS.COLLECTION.REPORT}${parentReportID})

useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${parentReportID || CONST.DEFAULT_NUMBER_ID}`)

or we can add a fallback ID to prop

parentReportID=CONST.DEFAULT_NUMBER_ID

If this is not urgent, we can also fix it via the backend

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

N/A

Copy link
Contributor

github-actions bot commented Jan 1, 2025

rajan123 Your proposal will be dismissed because you did not follow the proposal template.

Copy link
Contributor

github-actions bot commented Jan 1, 2025

guitz Your proposal will be dismissed because you did not follow the proposal template.

@parasharrajat
Copy link
Member

parasharrajat commented Jan 1, 2025

@linhvovan29546's proposal makes sense. I can help move this forward @MitchExpensify as C+.
Looks kind of urgent issue due to app crashing behaviour.

@linhvovan29546
Copy link
Contributor

linhvovan29546 commented Jan 1, 2025

@linhvovan29546's proposal makes sense. I can help move this forward @MitchExpensify as C+. Looks kind of urgent issue due to app crashing behaviour.

In fact, this is a backend issue. However, we prevent crashing behavior by add fallback ID

Update root cause #54717 (comment)

@mkzie2
Copy link
Contributor

mkzie2 commented Jan 3, 2025

The same RCA with #53547.

@MitchExpensify
Copy link
Contributor

Are you saying this is being solved elsewhere over in #53547., @mkzie2 ?

@mkzie2
Copy link
Contributor

mkzie2 commented Jan 3, 2025

@MitchExpensify Yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
None yet
Development

No branches or pull requests

5 participants