[HOLD for payment 2025-01-07] [HOLD for payment 2025-01-02] Icons are decolorized in security

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.78-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @allgandalf
Slack conversation (hyperlinked to channel name): expensify_bugs

Action Performed:

1. Open settings > Security, > observe the icon on top left

Expected Result:

Icons are displayed in color

Actual Result:

Icons are decolorized in security

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Recording.863.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @anmurali

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @tylerkaraszewski (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[parasharrajat]

This PR #52823 caused this issue.

Here this line https://github.com/Expensify/App/pull/52823/files#diff-3ea703b86598917b6d2bd0c62d7489450ad5d73328aedb4596694419fcccc77eR185 we are now passing the default theme.icon to iconFill which overrides the color values.

[parasharrajat]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Wrong color is shown for header icons.

What is the root cause of that problem?

We are not assigning a default value of theme.icon to all icons on Header via

App/src/components/HeaderWithBackButton/index.tsx

Line 185 in a088878

fill={iconFill ?? theme.icon}

.

THis change was added in #52823 to color TripDetails Page.

What changes do you think we should make in order to solve the problem?

1. We should remove the default value theme.icon from this prop at

   App/src/components/HeaderWithBackButton/index.tsx

   Line 185 in a088878

   fill={iconFill ?? theme.icon}

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[allgandalf]

Proposal makes sense to me 👍

[parasharrajat]

I created the PR based on approval from Slack.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[aldo-expensify]

Requested CP for #54514 here: https://expensify.slack.com/archives/C07J32337/p1735069519771039

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.78-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP staging] Fix the HeaderWithBackButton compnent so that icons take their natural fill color #54494

If no regressions arise, payment will be issued on 2025-01-02. 🎊

For reference, here are some details about the assignees on this issue:

• @parasharrajat requires payment through NewDot Manual Requests
• @allgandalf requires payment (Needs manual offer from BZ)

[melvin-bot]

@parasharrajat @anmurali @parasharrajat The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.79-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP staging] Fix the HeaderWithBackButton compnent so that icons take their natural fill color #54494

If no regressions arise, payment will be issued on 2025-01-07. 🎊

For reference, here are some details about the assignees on this issue:

• @parasharrajat requires payment through NewDot Manual Requests
• @allgandalf requires payment (Needs manual offer from BZ)

[melvin-bot]

@parasharrajat @anmurali @parasharrajat The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @parasharrajat owed $250 via NewDot

BugZero Checklist (@anmurali)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[melvin-bot]

@anmurali, @parasharrajat, @aldo-expensify Eep! 4 days overdue now. Issues have feelings too...

[parasharrajat]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
• 2b. Reported on staging (eg. found during regression or PR testing)
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: [vip-travel] Create Trip Details Screen #52823 (comment)

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: Not needed

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Test:

1. Open settings.
2. Open other settings pages e.g Security, Profile etc.
3. Observe the icon on top left icon on the header.
4. Icon should be colored.

Do we agree 👍 or 👎

[anmurali]

Payment Summary

• @allgandalf $250 approved via Upwork offer
• @parasharrajat $250 approved via New Dot.

[melvin-bot]

@anmurali, @parasharrajat, @aldo-expensify Eep! 4 days overdue now. Issues have feelings too...

[parasharrajat]

@anmurali Please close this. I will request it later.

[melvin-bot]

@anmurali, @parasharrajat, @aldo-expensify Still overdue 6 days?! Let's take care of this!

[parasharrajat]

Payment requested as per #54480 (comment)

[JmillsExpensify]

$250 approved for @parasharrajat