[HOLD for payment 2025-01-02] [$250] QAB- QAB navigates to last opened expense type rather than summited expense

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v9.0.71-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

1. Navigate to https://staging.new.expensify.com
2. Create WS
3. Click FAB> Submit expense> Scan receipt and submit the expense
4. Notice QAB displays Scan receipt option
5. Click FAB > Submit expense
6. Go to distance or manual expense option (do not submit any expense) and navigate back
7. Notice QAB is still Scan receipt - Click QAB

Expected Result:

As scan receipt was the last expense type summited to WS, QAB should navigate to scan receipt option

Actual Result:

QAB navigates to the last navigated tab(in step 6) rater than submitted tab as QAB name on FAB

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6684131_1733307060392.Scan.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021864415280896735708
• Upwork Job ID: 1864415280896735708
• Last Price Increase: 2024-12-04
• Automatic offers:
• FitseTLT | Contributor | 105254767

Issue Owner

Current Issue Owner: @isabelastisser

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

Alex Your proposal will be dismissed because you did not follow the proposal template.

[FitseTLT]

Edited by proposal-police: This proposal was edited at 2024-12-04 12:16:14 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

QAB- QAB navigates to last opened expense type rather than summited expense

What is the root cause of that problem?

We are not explicitly passing the request type here

App/src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.tsx

Lines 263 to 266 in 6482913

	case CONST.QUICK_ACTIONS.REQUEST_MANUAL:
	case CONST.QUICK_ACTIONS.REQUEST_SCAN:
	case CONST.QUICK_ACTIONS.REQUEST_DISTANCE:
	selectOption(() => IOU.startMoneyRequest(CONST.IOU.TYPE.SUBMIT, quickActionReportID, undefined, true), true);

so it will fallback to the last request type

What changes do you think we should make in order to solve the problem?

We should explicitly pass the request type for startMoneyRequest

let requestType;
        if ([CONST.QUICK_ACTIONS.REQUEST_MANUAL, CONST.QUICK_ACTIONS.SPLIT_MANUAL,CONST.QUICK_ACTIONS.TRACK_MANUAL].includes(quickAction?.action)) requestType = CONST.IOU.REQUEST_TYPE.MANUAL;
        else if ([CONST.QUICK_ACTIONS.REQUEST_SCAN, CONST.QUICK_ACTIONS.SPLIT_SCAN, CONST.QUICK_ACTIONS.TRACK_SCAN].includes(quickAction?.action)) requestType = CONST.IOU.REQUEST_TYPE.SCAN;
        else if ([CONST.QUICK_ACTIONS.REQUEST_DISTANCE, CONST.QUICK_ACTIONS.SPLIT_DISTANCE, CONST.QUICK_ACTIONS.TRACK_DISTANCE].includes(quickAction?.action))
            requestType = CONST.IOU.REQUEST_TYPE.DISTANCE;

and pass requestType param for startMoneyRequest in all cases here

App/src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.tsx

Lines 266 to 284 in 6482913

	selectOption(() => IOU.startMoneyRequest(CONST.IOU.TYPE.SUBMIT, quickActionReportID, undefined, true), true);
	return;
	case CONST.QUICK_ACTIONS.SPLIT_MANUAL:
	case CONST.QUICK_ACTIONS.SPLIT_SCAN:
	selectOption(() => IOU.startMoneyRequest(CONST.IOU.TYPE.SPLIT, quickActionReportID, undefined, true), true);
	return;
	case CONST.QUICK_ACTIONS.SPLIT_DISTANCE:
	selectOption(() => IOU.startMoneyRequest(CONST.IOU.TYPE.SPLIT, quickActionReportID, undefined, false), true);
	return;
	case CONST.QUICK_ACTIONS.SEND_MONEY:
	selectOption(() => IOU.startMoneyRequest(CONST.IOU.TYPE.PAY, quickActionReportID, undefined, true), false);
	return;
	case CONST.QUICK_ACTIONS.ASSIGN_TASK:
	selectOption(() => Task.startOutCreateTaskQuickAction(isValidReport ? quickActionReportID : '', quickAction.targetAccountID ?? -1), false);
	break;
	case CONST.QUICK_ACTIONS.TRACK_MANUAL:
	case CONST.QUICK_ACTIONS.TRACK_SCAN:
	case CONST.QUICK_ACTIONS.TRACK_DISTANCE:
	selectOption(() => IOU.startMoneyRequest(CONST.IOU.TYPE.TRACK, quickActionReportID, undefined, true), false);

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

We can render our FloatingActionButtonAndPopover populating the necessary data in onyx (including the quick action data) and providing the necessary mocks, then press (fireEvent.press) on the quick action menu item (by querying the menu item via giving test id or any other suitable way) and then we can mock our Navigation.navigate function and assert that it is called with the correct route parameter via toHaveBeenCalledWith(i.e. the correct requestType is included in the path).

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021864415280896735708

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jayeshmangwani (External)

[saifelance]

Job added to Upwork: https://www.upwork.com/jobs/~021864415280896735708

Job invite?

[jayeshmangwani]

Job invite?

This link is not a job invitation but rather a link to the job posted on Upwork.

[jayeshmangwani]

@saifelance Please refrain from submitting irrelevant proposals, as your proposal is not related to this issue.

[jayeshmangwani]

@FitseTLT's Proposal looks good to me. We could pass the requestType to the startMoneyRequest function to preserve the active tab.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @MonilBhavsar, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[MonilBhavsar]

Looks good! Let's please add automated cases for various cases

[melvin-bot]

📣 @FitseTLT 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

@isabelastisser, @MonilBhavsar, @jayeshmangwani Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[jayeshmangwani]

@FitseTLT What's the ETA for the PR?

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.78-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix - QAB- QAB navigates to last opened expense type rather than summited expense #53945

If no regressions arise, payment will be issued on 2025-01-02. 🎊

For reference, here are some details about the assignees on this issue:

• @jayeshmangwani requires payment through NewDot Manual Requests
• @FitseTLT requires payment automatic offer (Contributor)

[melvin-bot]

@jayeshmangwani @isabelastisser @jayeshmangwani The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[jayeshmangwani]

@MonilBhavsar @isabelastisser both of these issues #53545 and #53866 are similar, and I think this checklist is enough for this issue too.

[isabelastisser]

Based on the comment above, we can use the checklist from this issue for this bug.

[isabelastisser]

Payment summary:

@jayeshmangwani requires payment through NewDot Manual Requests $250 for C+ review PENDING
@FitseTLT requires payment automatic offer $250 for Contributor role. PAID in Upwork.

[isabelastisser]

all set!

[garrettmknight]

$250 approved for @jayeshmangwani