[HOLD for payment 2024-11-20] [$250] Only show the "Request early cancelation" button on Subscription to users that have been billed

[MitchExpensify]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Issue reported by: @trjExpensify
Slack conversation (Internal): https://expensify.slack.com/archives/C07HPDRELLD/p1730254508322699

Action Performed:

1. Create your first workspace
2. Go to Settings
3. Go to subscriptions

Expected Result:

We need the "Request early cancelation" option under "Payment card" to only show once you have been billed at least once

Actual Result:

The "Request early cancelation" option shows as soon as you create a workspace and before your subscription has started with its first billing

Workaround:

NA

Platforms:

All

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021852437879061502559
• Upwork Job ID: 1852437879061502559
• Last Price Increase: 2024-11-08

Issue Owner

Current Issue Owner: @puneetlath

[melvin-bot]

Triggered auto assignment to @puneetlath (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[melvin-bot]

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

[melvin-bot]

Triggered auto assignment to Design team member for new feature review - @shawnborton (NewFeature)

[MitchExpensify]

Assuming this needs to be internal as it touches billing, labelling as such

[puneetlath]

Hmm, I think this should be able to handle externally. The client should already have all the information it needs to decide whether or not to show that option. Making external.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021852437879061502559

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[Shahidullah-Muffakir]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Show the "Request early cancelation" only if user is billed

What is the root cause of that problem?

New feature

What changes do you think we should make in order to solve the problem?

add this check here: account.hasPurchases &&

App/src/pages/settings/Subscription/CardSection/CardSection.tsx

Line 198 in 20fadd7

{privateSubscription?.type === CONST.SUBSCRIPTION.TYPE.ANNUAL && <RequestEarlyCancellationMenuItem />}

[twilight2294]

Edited by proposal-police: This proposal was edited at 2024-11-01 20:34:19 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Only show the "Request early cancelation" button on Subscription to users that have been billed

What is the root cause of that problem?

Feature request we need to hide the Request early cancelation button when the user has not been billed.

Currently we only check privateSubscription?.type === CONST.SUBSCRIPTION.TYPE.ANNUAL to show the button. and hence it is visible

What changes do you think we should make in order to solve the problem?

We can use the hasPurchases value of ACCOUNT onyx key which Indicates whether the user has at least one previous purchase, with that we still need to check privateSubscription?.type === CONST.SUBSCRIPTION.TYPE.ANNUAL because there won't be any early cancelation for pay-as-you-go:

App/src/types/onyx/Account.ts

Lines 127 to 130 in 20fadd7

	/** Indicates whether the user has at least one previous purchase */
	hasPurchases?: boolean;

{account?.hasPurchases && privateSubscription?.type === CONST.SUBSCRIPTION.TYPE.ANNUAL && <RequestEarlyCancellationMenuItem />} 

What alternative solutions did you explore? (Optional)

[twilight2294]

Updated proposal

Updated to more correct solution (We would still need to hide the button if the subscription type if pay-as-you-go, the button should only be visible in case the user has previous purchase as well as the plan is annual

[ShridharGoel]

Proposal

Please re-state the problem that we are trying to solve in this issue.

We need to only show the "Request early cancelation" button on Subscription to users that have been billed.

What is the root cause of that problem?

We don't have any check on the billing status when showing the early cancellation option.

App/src/pages/settings/Subscription/CardSection/CardSection.tsx

Line 198 in bef062b

{privateSubscription?.type === CONST.SUBSCRIPTION.TYPE.ANNUAL && <RequestEarlyCancellationMenuItem />}

What changes do you think we should make in order to solve the problem?

Update it to the below to show the option only when there's a billing status available:

{billingStatus && privateSubscription?.type === CONST.SUBSCRIPTION.TYPE.ANNUAL && <RequestEarlyCancellationMenuItem />}

We can also add some checks like not showing the option when the billing status in an error etc.

[devKid88]

Proposal

Please re-state the problem that we are trying to solve in this issue.

We need the "Request early cancelation" option under "Payment card" to only show once you have been billed at least once

What is the root cause of that problem?

When we validate should we show a "Request early cancelation" option, we currently only checking for the type of subscription, not checking if the user has any payments before.

What changes do you think we should make to solve the problem?

We can check if the user has any payments, but also we possibly have to check is eligible for a refund (both checks are available in the account data), if so it will indicate that we can proceed with rendering the 'Request early cancelation" option. I am new to the platform, but maybe isEligibleForRefund will be enough to check this. Definitely, the fix is here, and we can easily refine the approach and fix it.

[melvin-bot]

📣 @devKid88! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[devKid88]

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~0113d60b2da9445a4d

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[melvin-bot]

@puneetlath, @shawnborton, @parasharrajat Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[blimpich]

@ShridharGoel billingStatus can exist and the user can still not have been billed. For example, it can be "failed," in which case a user has not been billed successfully, whereas hasPurchases will only be true if we have actually gotten money from the user. I think honestly we could make it work with billingStatus but I think hasPurchases is simpler and more straightforward.

[Shahidullah-Muffakir]

Thank you for accepting my proposal! I'll have the PR ready for review within 24 hours.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.60-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• hide 'Request early cancellation' option until after first billing #52282

If no regressions arise, payment will be issued on 2024-11-20. 🎊

For reference, here are some details about the assignees on this issue:

• @parasharrajat requires payment through NewDot Manual Requests
• @Shahidullah-Muffakir requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@puneetlath] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @parasharrajat owed $250 via NewDot
• ROLE: @Shahidullah-Muffakir paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@puneetlath)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1852437879061502559/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[parasharrajat]

Regression Test Steps

1. Create a new workspace
2. Navigate to Settings > Subscriptions.
3. Verify that the Request early cancellation option is not displayed

Do you agree 👍 or 👎 ?

[melvin-bot]

@puneetlath, @shawnborton, @blimpich, @parasharrajat, @Shahidullah-Muffakir Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[Shahidullah-Muffakir]

@blimpich Friendly bump for payment, Thanks.

[puneetlath]

Hmm, @Shahidullah-Muffakir looks like an upwork offer wasn't automatically created for you for some reason. I've sent you one here. Can you ping me on this issue when you've accepted?

[Shahidullah-Muffakir]

Hmm, @Shahidullah-Muffakir looks like an upwork offer wasn't automatically created for you for some reason. I've sent you one here. Can you ping me on this issue when you've accepted?

@puneetlath , Offer accepted, Thanks.

[puneetlath]

Regression test issue: https://github.com/Expensify/Expensify/issues/447720

Payment summary:

• C - $250 - @Shahidullah-Muffakir - paid via Upwork
• C+ - $250 - @parasharrajat - to be paid via NewDot

Thanks everyone!

[parasharrajat]

payment requested as per #51892 (comment)

[JmillsExpensify]

$250 approved for @parasharrajat