[HOLD for payment 2024-10-24] [$50] iOS - Attachment - Opening exclamation mark on "Downloaded!" modal is not correct in Spanish

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.41-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): https://expensify.testrail.io/index.php?/tests/view/5018371
Issue reported by: Applause - Internal Team

Action Performed:

Pre-requisite: user must have set the language to Spanish

1. Open New Expensify app
2. Go to any chat with an attachment (or send an attachment if there is none)
3. Tap on the attachment
4. Tap on the download button and wait for it to download

Expected Result:

Opening exclamation mark should be correct, title in the modal should say "¡Descargado!"

Actual Result:

Opening exclamation mark is not correct, title in the modal says "!Descargado!"

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021841232628406634819
• Upwork Job ID: 1841232628406634819
• Last Price Increase: 2024-10-01
• Automatic offers:
• akinwale | Reviewer | 104321452
• Nodebrute | Contributor | 104321453

Issue Owner

Current Issue Owner: @mallenexpensify

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@mallenexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[Nodebrute]

Edited by proposal-police: This proposal was edited at 2024-09-28 21:06:21 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Opening exclamation mark on "Downloaded!" modal is not correct in Spanish

What is the root cause of that problem?

We are not using the correct Spanish translation

App/src/languages/es.ts

Line 4194 in 3047c1b

title: '!Descargado!',

What changes do you think we should make in order to solve the problem?

Use ¡Descargado! instead

App/src/languages/es.ts

Line 4194 in 3047c1b

title: '!Descargado!',

Optional: We can confirm the copy we want to use for Spanish translation in PR and identify other areas where translations need to be fixed.

What alternative solutions did you explore? (Optional)

We can match the Spanish translation with english translations and remove the first exclamation mark. We can use the word Descargado!

App/src/languages/es.ts

Line 4194 in 3047c1b

title: '!Descargado!',

Optional: I can see we are missing an exclamation mark here too

App/src/languages/es.ts

Line 4195 in 3047c1b

message: 'Archivo descargado correctamente',

Archivo descargado correctamente!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021841232628406634819

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale (External)

[mallenexpensify]

@akinwale this is a super quick/easy fix, right? I'm planning to make it $50, wanted to check with you first though.

[akinwale]

@akinwale this is a super quick/easy fix, right? I'm planning to make it $50, wanted to check with you first though.

@mallenexpensify Yes, this is just a translation string update.

[melvin-bot]

⚠️ This issue has had its price increased by 4x or more. Please review the issue and ensure the price is correct.

[melvin-bot]

Upwork job price has been updated to $50

[mallenexpensify]

Thanks @akinwale, made it $50, plz review @Nodebrute 's proposal above.

[sher999]

Proposal

---

Hey I have done this change

• on ios 17.5 native iphone 15

@akinwale respected sir can you please look at it ?

[mallenexpensify]

@sher999 please familiarize yourself with our CONTRIBUTING.md and https://github.com/Expensify/App/tree/main/contributingGuides

[Nodebrute]

@akinwale Can you review my proposal? It's a quick fix.

[melvin-bot]

@akinwale, @mallenexpensify Huh... This is 4 days overdue. Who can take care of this?

[akinwale]

We can move forward with @Nodebrute's proposal here.

🎀👀🎀 C+ reviewed.

@akinwale , when you're back from traveling. Also, will this issue be fixed by the proposal here? Thx

@mallenexpensify Did you intend to link a different issue here?

[melvin-bot]

Triggered auto assignment to @arosiclair, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @akinwale 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @Nodebrute 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[mallenexpensify]

@arosiclair 👀 on the above proposal plz, should be super quick :)

I removed my comment above cuz I can't remember the correct link I meant to share ¯_(ツ)_/¯

[arosiclair]

Yeah I hired Nodebrute. Just waiting on the C+ review.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.49-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix download translation #50439

If no regressions arise, payment will be issued on 2024-10-24. 🎊

For reference, here are some details about the assignees on this issue:

• @akinwale requires payment automatic offer (Reviewer)
• @Nodebrute requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@akinwale] The PR that introduced the bug has been identified. Link to the PR:
• [@akinwale] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@akinwale] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@akinwale] Determine if we should create a regression test for this bug.
• [@akinwale] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[mallenexpensify]

Contributor: @Nodebrute paid $50 via Upwork
Contributor+: @akinwale paid $50 via Upwork.

No need for a regression test here, thx!