Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-10-24] [A/B Testing - Create Expense] Update Action Menu in Chats (DM, Workspace, selfDM) #49691

Closed
grgia opened this issue Sep 25, 2024 · 16 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item.

Comments

@grgia
Copy link
Contributor

grgia commented Sep 25, 2024

Project

Part of A/B Testing Project
Follow up to this PR / Issue

cc @fabioh8010

Goal

Update the action menu for DMs, Workspace Chats, and selfDM:

This is where we’ve landed with the DM/Workspace chat menu items:
Create expense in a DM is = Submit expense. You can’t track in a DM with someone today anyway.
Create expense in the selfDM is = Track expense. You can “submit it” using the actionable whisper after creation like today.
Create expense in the workspace chat is = Submit expense.

Design

Figma

Issue OwnerCurrent Issue Owner: @OfstadC
@grgia grgia added Daily KSv2 NewFeature Something to build that is a new item. labels Sep 25, 2024
@grgia grgia self-assigned this Sep 25, 2024
Copy link

melvin-bot bot commented Sep 25, 2024

Triggered auto assignment to @OfstadC (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Sep 25, 2024
Copy link

melvin-bot bot commented Sep 25, 2024

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

Copy link

melvin-bot bot commented Sep 25, 2024

Triggered auto assignment to Design team member for new feature review - @dubielzyk-expensify (NewFeature)

@fabioh8010
Copy link
Contributor

fabioh8010 commented Sep 25, 2024

Hi, I'm Fábio from Callstack - expert agency - and I would like to work on this issue.

@fabioh8010
Copy link
Contributor

Update: Waiting for #49007 to be completed before start working on this

@OfstadC OfstadC changed the title [A/B Testing - Create Expense] Update Action Menu in Chats (DM, Workspace, selfDM) [Hold for #49007][A/B Testing - Create Expense] Update Action Menu in Chats (DM, Workspace, selfDM) Oct 1, 2024
@grgia grgia changed the title [Hold for #49007][A/B Testing - Create Expense] Update Action Menu in Chats (DM, Workspace, selfDM) [A/B Testing - Create Expense] Update Action Menu in Chats (DM, Workspace, selfDM) Oct 2, 2024
@pasyukevich
Copy link
Contributor

Hi, I'm Eugene from Callstack - an expert agency - I have the capacity and would like to take over this issue.

@grgia
Copy link
Contributor Author

grgia commented Oct 2, 2024

Thanks @pasyukevich! Could you please prioritize this one?

@pasyukevich
Copy link
Contributor

Sure, I work on it as a main priority

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Oct 7, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Oct 17, 2024
@melvin-bot melvin-bot bot changed the title [A/B Testing - Create Expense] Update Action Menu in Chats (DM, Workspace, selfDM) [HOLD for payment 2024-10-24] [A/B Testing - Create Expense] Update Action Menu in Chats (DM, Workspace, selfDM) Oct 17, 2024
Copy link

melvin-bot bot commented Oct 17, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Oct 17, 2024
Copy link

melvin-bot bot commented Oct 17, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.49-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-10-24. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Oct 17, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@pasyukevich] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@OfstadC] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Oct 23, 2024
@OfstadC
Copy link
Contributor

OfstadC commented Oct 23, 2024

Just to confirm, no other payment is needed here, yeah? If i'm missing someone, please let me know!

@melvin-bot melvin-bot bot removed the Overdue label Oct 23, 2024
Copy link

melvin-bot bot commented Oct 24, 2024

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

@OfstadC
Copy link
Contributor

OfstadC commented Oct 24, 2024

@pasyukevich Any regression testing to propose here? If not, I think this is set to close.

@pasyukevich
Copy link
Contributor

@OfstadC, there is no regression testing to propose here

@OfstadC
Copy link
Contributor

OfstadC commented Oct 25, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item.
Projects
Development

No branches or pull requests

5 participants