Web – Xero – Error page 500 appears when connect to Xero

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v9.0.34-2
Reproducible in staging?: Y
Reproducible in production?: N
Issue was found when executing this PR: #48519
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

1. Go to https://staging.new.expensify.com/

2. Log in with expensifail account

3. Create a workspace

4. Enable "Accounting" in the "More features" page.

5. Navigate to "Accounting"

6. Connect to Xero

7. Enable 2 FA

8. Enter Xero credentials

9. Click on Continue with one organization

Expected Result:

The sync is complete

Actual Result:

Error page 500 appears

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6601939_1726210086452.Xero.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @grgia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[IuliiaHerets]

We think that this bug might be related to #wave-collect - Release 1

[grgia]

@nyomanjyotisa cc @ikevin127 @Beamanator this deploy blocker was found while QAing your PR, could you please let me know if you have any additional context

[nyomanjyotisa]

-1-New-Expensify.25.mp4

Can't reproduce on latest main^

[luacmartins]

This kinda looks like an API issue to me with the oauth callback. @grgia can you reproduce this on staging?

[luacmartins]

Logs

Couldn't get valid connection data ~~ integration: 'xero' policyID: '84A1663F6E414ACE' data: 'is_temp_logs54a6cbb0-f8e6-4426-8b30-ca2072979ae9.log' class: 'ExpensifyException' msg: 'Invalid connection configuration' code: '410'
Couldn't load Xero connection data ~~ policyID: '84A1663F6E414ACE' class: 'ExpensifyException' msg: 'Invalid connection configuration' code: '410'

[luacmartins]

We can see the URL is staging.expensify.com too. @grgia maybe this is a web blocker. Please confirm.

[grgia]

looking @luacmartins

[grgia]

@mananjadhav @dangrous I see you've been working on Xero stuff, maybe you have more info on the above? Still looking into this being a web blocker @luacmartins

[grgia]

'Invalid connection configuration' code: '410'
seems to be hitting here https://github.com/Expensify/Integration-Server/blob/b23547d64498d85179125738f36763b5b47cd5ea/src/expensify/beans/expensify/policy/integration/xero/XeroConfiguration.java#L362

[grgia]

Also cc @francoisl

[grgia]

I'm 99% sure we can remove this from the app deploy blocker list, works in staging for me

[grgia]

Gonna close this out @luacmartins

[IuliiaHerets]

QA team can reproduce this issue in the latest build - v9.0.39-0. Cannot reproduce the issue on an incognito window.

Recording.4011.mp4

[lakchote]

I've investigated, the Xero's connection config is not in a correct state for the policy ID 48F701BD3789D925.

Do we know why the connection config is getting into that state?

Honestly, I do not have the answer to that question. cc @francoisl maybe you'll have the answer? Otherwise, we'd need to try to reproduce that state. My guess would be an incomplete setup flow triggers that state.

[sakluger]

I'm going to post in QA in Slack to ask for a retest.

[m-natarajan]

Bug is not reproducible anymore.

bandicam.2024-09-26.15-39-01-419.mp4

[sakluger]

Okay sounds like this is fixed. Closing!

[mananjadhav]

I was able to reproduce this recently on staging if you check the video attached here. So I am not sure if we did something that fixed it.

[trjExpensify]

Yeah, I'm not convinced this is fixed personally.

[trjExpensify]

I'd be curious for Franc's take on Lucien's q above before closing in haste.

[mananjadhav]

Yeah I haven't got a chance to look at this again. But I've always got this when I try a fresh login and first time sync. I have a few workspaces connected to other accounting integrations for my QA. But I think this would have to be fixed internally. The error page that we see is on staging.expensify.com ie the OldDot.

Few things that come on top of my head are:

1. Payload size must be causing the issue? (highly likely)
2. Any rate limits per IP or from Xero?
3. Any backend bug (less likely as subsequent sync work fine).

[sakluger]

Got it, sorry for closing this one prematurely. @francoisl - any thoughts on Lucien's question?

[melvin-bot]

@sakluger this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[francoisl]

When that happens, can you try to open https://staging.expensify.com and https://staging.new.expensify.com in separate tabs, and check if you're signed in the same Expensify account in both?

From what I'm seeing in the logs for the rayID 8c25fa7d6995ca59 from the screencast in the OP, there are 2 separate accounts involved - [email protected], and a gmail address.
(logs1, logs2 by policyID).

Because of that, the backend thinks you're trying to update a policy you don't have access to, and returns an error. I'm not sure why it ends up as a "bad gateway" error though.

[sakluger]

From what I'm seeing in the logs for the rayID 8c25fa7d6995ca59 from the screencast in the OP, there are 2 separate accounts involved

I would expect us to return an error in this scenario, but maybe we should use a more descriptive error than a 500?

[sakluger]

@IuliiaHerets could you please try this again and check @francoisl's question above?

When that happens, can you try to open https://staging.expensify.com/ and https://staging.new.expensify.com/ in separate tabs, and check if you're signed in the same Expensify account in both?

[IuliiaHerets]

@sakluger Issue is not reproducible now

bandicam.2024-10-03.09-07-55-576.mp4

[sakluger]

Okay, since @grgia couldn't reproduce before and now @IuliiaHerets can't reproduce, we can close it out again. Feel free to reopen if it happens again.