[HOLD for payment 2024-10-10] [$250] [Dev] Console Warning: Function components cannot be given refs. Attempts to access this ref will fail. Did you mean to use React.forwardRef()?

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.30-9
Reproducible in staging?: Needs Reproduction
Reproducible in production?: Needs Reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @c3024
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1726072515490119?thread_ts=1726072125.690969&cid=C049HHMV9SM

Action Performed:

1. Logon to ND on iOS App
2. Go to the self DM page

Expected Result:

No console warning

Actual Result:

Console Warning

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021834579040151664712
• Upwork Job ID: 1834579040151664712
• Last Price Increase: 2024-09-13

Issue Owner

Current Issue Owner: @joekaufmanexpensify

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[MelvinBot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

[joekaufmanexpensify]

Getting help reproducing this, since it's a dev environment bug

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Console warning when open a self DM report.

What is the root cause of that problem?

The console warning tells that we are passing a ref prop to a functional component without usign forwardRef. The main culprit is from the withOnyx and the other one is from the withCurrentUserPersonalDetails hook.

If we see at the OP screenshots, it's coming from ReportTypingIndicator, but it actually happens on a lot of places and potentially on all component that uses withOnyx.

What changes do you think we should make in order to solve the problem?

Replace withOnyx usage with useOnyx hook. There are still a lot of withOnyx usage on the codebase, so we can focus on this issue on some component that triggers the warning in self DM.

Here is the list of the component where we can replace the withOnyx to useOnyx and withCurrentUserPersonalDetails to useCurrentUserPersonalDetails.

• AttachmentModal
• ReportActionItem
• ReportActionItemCreated
• ReportActionsList
• ReportTypingIndicator
• UserTypingEventListener
• ReportActionCompose

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021834579040151664712

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[allroundexperts]

@bernhardoj's proposal has the correct RCA and the proposed solution should fix the issue as well. Let's go with them!

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @aldo-expensify, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[joekaufmanexpensify]

@bernhardoj is there an ETA for PR here?

[bernhardoj]

Sorry, I was sick. PR is ready.

cc: @allroundexperts

[joekaufmanexpensify]

Hope you're feeling better, and TY!

[joekaufmanexpensify]

PR in review

[joekaufmanexpensify]

PR still in review

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.43-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix warning "Function components cannot be given refs" #49377

If no regressions arise, payment will be issued on 2024-10-10. 🎊

For reference, here are some details about the assignees on this issue:

• @allroundexperts requires payment through NewDot Manual Requests
• @bernhardoj requires payment through NewDot Manual Requests
• @c3024 requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
• [@allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@allroundexperts] Determine if we should create a regression test for this bug.
• [@allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@joekaufmanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[joekaufmanexpensify]

@allroundexperts, could you handle the checklist so I can prep for payment?

[allroundexperts]

@joekaufmanexpensify I don't think a regression test and the checklist makes much sense here since the functionality is un-effected. Let me know if you think otherwise.

[joekaufmanexpensify]

Ah, yeah that is fair. TY!

[joekaufmanexpensify]

There is no reporting bonus anymore, so payment is due to @c3024 for this one.

[joekaufmanexpensify]

Only payment due here is:

• @bernhardoj - $250 for PR via NewDot.
• @allroundexperts - $250 for C+ via NewDot.

[joekaufmanexpensify]

Both of you, feel free to request payment whenever you're ready! I'm going to close the issue in the meantime, but lmk if anything else is needed!

[bernhardoj]

Requested in ND.

[JmillsExpensify]

$250 approved for @bernhardoj

[JmillsExpensify]

$250 approved for @allroundexperts