Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HybridApp] When quickly switching between apps and Hybrid App with the keyboard open, it flashes dark mode and changes my keyboard to dark mode #48299

Closed
1 of 6 tasks
m-natarajan opened this issue Aug 29, 2024 · 18 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Monthly KSv2 Reviewing Has a PR in review

Comments

@m-natarajan
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number:
Reproducible in staging?: Needs reproduction
Reproducible in production?: -
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @AndrewGable
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1724949894220739

Action Performed:

  1. Open the hybrid app , Initiate and compose a DM with any user (Keyboard open)
  2. Quickly swipe left or right along the bottom edge of the screen to switch between recently used apps

Expected Result:

No visual issues

Actual Result:

Quickly switching between apps and Hybrid App with the keyboard open, it flashes dark mode and changes my keyboard to dark mode

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

RPReplay_Final1724949033.MP4

View all open jobs on GitHub

@m-natarajan m-natarajan added Daily KSv2 Needs Reproduction Reproducible steps needed Bug Something is broken. Auto assigns a BugZero manager. labels Aug 29, 2024
Copy link

melvin-bot bot commented Aug 29, 2024

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@MelvinBot
Copy link

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

@melvin-bot melvin-bot bot added the Overdue label Sep 2, 2024
Copy link

melvin-bot bot commented Sep 2, 2024

@JmillsExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@staszekscp
Copy link
Contributor

staszekscp commented Sep 4, 2024

Hey! At the moment I am investigating this issue, and I was able to reproduce this issue also on the NewDot app:

RPReplay_Final1725437954.MP4

It seems that the workaround would be to timeout the value returned by useColorScheme, because the problem is known, and still exists. There is a chance that the problem will disappear when we enable bridgelessMode, but at the moment I think the timeout would be the best solution.

@JmillsExpensify JmillsExpensify removed the Needs Reproduction Reproducible steps needed label Sep 4, 2024
@JmillsExpensify
Copy link

Nice, did you want to take this issue or are we going to assign to someone internal?

@melvin-bot melvin-bot bot removed the Overdue label Sep 4, 2024
@war-in
Copy link
Contributor

war-in commented Sep 5, 2024

Hi @JmillsExpensify 👋 I took this issue over from @staszekscp and I'm going to create a PR in a moment 🤞

@war-in war-in mentioned this issue Sep 5, 2024
48 tasks
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Sep 5, 2024
@staszekscp
Copy link
Contributor

Sorry @JmillsExpensify for missing your question yesterday! I was on the way to the React Universe Conference, but since I didn’t want to leave the issue unfinished I asked @war-in to build and test the fix! 😀 The PR is ready, so I think we’re good to go!

Copy link

melvin-bot bot commented Sep 5, 2024

Triggered auto assignment to @AndrewGable, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@trjExpensify trjExpensify changed the title Hybrid app-When quickly switching between apps and Hybrid App with the keyboard open, it flashes dark mode and changes my keyboard to dark mode [HybridApp] When quickly switching between apps and Hybrid App with the keyboard open, it flashes dark mode and changes my keyboard to dark mode Sep 11, 2024
@melvin-bot melvin-bot bot removed the Weekly KSv2 label Sep 30, 2024
Copy link

melvin-bot bot commented Sep 30, 2024

This issue has not been updated in over 15 days. @JmillsExpensify, @AndrewGable eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot added the Monthly KSv2 label Sep 30, 2024
@AndrewGable
Copy link
Contributor

This was fixed last month

@fedirjh
Copy link
Contributor

fedirjh commented Oct 15, 2024

cc @AndrewGable it Seems like this was closed before paying for the PR review (#48642). Could you please re-open it and assign me as C+?

@AndrewGable
Copy link
Contributor

@JmillsExpensify - Can you check #48299 (comment)? Thank you 🙏

@JmillsExpensify
Copy link

Apols missed this. @fedirjh I just sent you an offer on Upwork

@JmillsExpensify
Copy link

@fedirjh please accept the Upwork offer when you have a moment. Thanks!

@fedirjh
Copy link
Contributor

fedirjh commented Dec 6, 2024

cc @JmillsExpensify This is just missing the payment summary. I have requested the payment in new dot also declined the offer on Upwork.

@JmillsExpensify
Copy link

Ah ok, didn't realize you were paid in NewDot.

Payment summary: $250 @fedirjh for PR review and testing.

@JmillsExpensify
Copy link

Closing this out.

@garrettmknight
Copy link
Contributor

$250 approved for @fedirjh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Monthly KSv2 Reviewing Has a PR in review
Projects
No open projects
Status: Done
Development

No branches or pull requests

8 participants