[HOLD for Payment 2024-09-12][$62.50] Add new sub-header to More features page

[joekaufmanexpensify]

Problem

Coming from here, there are concerns that the current More features page on the workspace editor doesn't make it sufficiently clear that enabling a toggle often simply adds a feature to the workspace editor to configure the feature, rather than actually turning it on. This could impact feature adoption, or drive support volume.

Solution

Add a new sub-header directly under More features header on this page of the workspace, that clarifies that toggling something on simply adds the feature to the workspace editor.

Sub-header copy should be: Use the toggles below to enable more features as you grow. Each feature will appear in the navigation menu for further customization.

It should go directly under More features, similar to how the Categories page shown below has a sub-header.

cc @heyjennahay @jamesdeanexpensify @JmillsExpensify @shawnborton @dannymcclain

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0182dc1eaaa54e652c
• Upwork Job ID: 1828148191299361076
• Last Price Increase: 2024-08-26
• Automatic offers:
• rayane-djouah | Reviewer | 103742172
• Krishna2323 | Contributor | 103742174

Issue Owner

Current Issue Owner: @Krishna2323

[melvin-bot]

Triggered auto assignment to @adelekennedy (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[melvin-bot]

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

[melvin-bot]

Triggered auto assignment to Design team member for new feature review - @dannymcclain (NewFeature)

[melvin-bot]

Current assignee @adelekennedy is eligible for the Bug assigner, not assigning anyone new.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0182dc1eaaa54e652c

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-djouah (External)

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)

[joekaufmanexpensify]

Adjusted price to $62.50, since this is a very, very minor change. Automation didn't work with Upwork, so adjusted the price manually there too

[Krishna2323]

Edited by proposal-police: This proposal was edited at 2024-08-26 19:26:30 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Add new sub-header to More features page

What is the root cause of that problem?

Improvement

What changes do you think we should make in order to solve the problem?

Below this line we need to add <Text style={[styles.pl5, styles.mb4, styles.mt3, styles.textSupporting]}>{translate('workspace.moreFeatures.subtitle')}</Text>, the translation will be different and will be added in workspace.moreFeatures object in en.ts and es.ts file.

App/src/pages/workspace/WorkspaceMoreFeaturesPage.tsx

Line 410 in 0fd1de0

/>

We can also apply maxWidth for the text:

                <Text style={[styles.pl5, styles.mb4, styles.mt3, styles.textSupporting, shouldUseNarrowLayout ? styles.workspaceSectionMobile : styles.workspaceSection]}>
                    {translate('workspace.moreFeatures.subtitle')}
                </Text>

What alternative solutions did you explore? (Optional)


Result

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Add new sub-header to More features page

What is the root cause of that problem?

New Feature

What changes do you think we should make in order to solve the problem?

1. We need to add new translation workspace.moreFeatures.subtitle

2. Create a new function and use this in here

    const getHeaderText = () => (
        <View style={[styles.ph5, styles.pb5, styles.pt3]}>
            <Text style={[styles.textNormal, styles.colorMuted]}>{translate('workspace.moreFeatures.subtitle')}</Text>
        </View>
    );

What alternative solutions did you explore? (Optional)

[rayane-djouah]

Friendly bump @AndrewGable on #48023 (comment)

[melvin-bot]

📣 @rayane-djouah 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @Krishna2323 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[Krishna2323]

@joekaufmanexpensify, could you please provide the spanish translation? Or should we ask on slack?

@rayane-djouah, PR ready for review ^

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[rayane-djouah]

This ^ was a very small issue and was addressed in a follow-up PR: #48573

[rayane-djouah]

Note

The production deploy automation failed: This should be on [HOLD for Payment 2024-09-12] according to #48515 production deploy checklist, confirmed in #48389 (comment)

[rayane-djouah]

@adelekennedy This is due payment

[adelekennedy]

Payouts due:

• Contributor: $62.50 @Krishna2323 Upwork @Krishna2323 please except the offer on Upwork!
• Contributor+: $62.50 @rayane-djouah Upwork

Upwork job is here.

[adelekennedy]

offer still pending @Krishna2323

[Krishna2323]

Sorry for delay @adelekennedy, offer accepted.