[HOLD for payment 2024-09-26] [$250] [Dupe Detection] Review duplicates - Tag in X: Y format is displayed in X\: Y format in review flow

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v9.0.21-3
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

Precondition:

• Workspace has a tag in X: Y format.

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Submit an expense without tag.
4. Submit another same expense as the previous one, but with tag in X: Y format.
5. Go to transaction thread.
6. Click Review duplicates.
7. Select Keep this one (any).
8. Proceed to tag selection page.

Expected Result:

Tag in X: Y format will be displayed in X: Y format in review flow.

Actual Result:

Tag in X: Y format is displayed in X: Y format in review flow.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6575232_1723985370030.20240818_204619.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0176ca0a6294fa423b
• Upwork Job ID: 1826096228342537444
• Last Price Increase: 2024-08-21
• Automatic offers:
• etCoderDysto | Contributor | 103689450

Issue Owner

Current Issue Owner: @getusha

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

We think that this bug might be related to #wave-collect - Release 2

[IuliiaHerets]

@stephanieelliott FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[etCoderDysto]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Tag in X: Y format is displayed in X: Y format in review flow

What is the root cause of that problem?

We are passing a tag that is formatted in X\: Y without removing the \ here to text prop of options object here

App/src/pages/TransactionDuplicate/ReviewTag.tsx

Lines 23 to 30 in 62722e8

	const options = useMemo(
	() =>
	compareResult.change.tag?.map((tag) =>
	!tag
	? {text: translate('violations.none'), value: ''}
	: {
	text: tag,
	value: tag,

Then ReviewFields will use the text prop to render the X\: Y formatted tag

App/src/pages/TransactionDuplicate/ReviewTag.tsx

Lines 45 to 48 in 62722e8

	<ReviewFields<'tag'>
	stepNames={stepNames}
	label={translate('violations.tagToKeep')}
	options={options}

What changes do you think we should make in order to solve the problem?

Using PolicyUtils.getCleanedTagName(), we should remove \ from X\: Y tag before passing it to ReviewFields here

 {
      text: PolicyUtils.getCleanedTagName(tag),
      value: tag,
},

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0176ca0a6294fa423b

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (External)

[raza-ak]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Tag in X: Y format is displayed in X: Y format in review flow

What is the root cause of that problem?

There are two issues.

1. [Frontend] When users create a tag then escapeTagName function is appending // before colon in the tag name before sending request to server.
   -1-New-Expensify.webm

2. [Backend] I tested by removing the // from the tag name but // is still appending to the tab name.

What changes do you think we should make in order to solve the problem?

1. We don’t need to call escapeTagName function and send the user provided tag name to server.
2. I tested by removing the // from the tag name but // is still appending to the tab name. So we need to fix this issue from backend as well.

[getusha]

cc @bernhardoj this looks related to #46556

[bernhardoj]

It's not. We're not cleaning the tag name as @etCoderDysto suggested.

[getusha]

@etCoderDysto's proposal looks good to me.
🎀 👀 🎀 C+ Reviewed!

[melvin-bot]

Triggered auto assignment to @puneetlath, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @etCoderDysto 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[etCoderDysto]

PR will be ready for review soon

[melvin-bot]

@puneetlath, @stephanieelliott, @getusha, @etCoderDysto Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[puneetlath]

@etCoderDysto how's the PR coming?

[etCoderDysto]

Hi @puneetlath. Sorry, I am OOO until the coming Monday. PR will be ready for review on Monday.

[melvin-bot]

@puneetlath @stephanieelliott @getusha @etCoderDysto this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[etCoderDysto]

PR will be ready for review by tomorrow

[etCoderDysto]

@getusha PR is ready for review

[stephanieelliott]

PR is still under active review

[stephanieelliott]

PR was merged to main

[stephanieelliott]

PR was deployed to prod on 9/19 but it looks like the automation didn't work. Updating manually to add payment date

[melvin-bot]

This issue has not been updated in over 15 days. @puneetlath, @stephanieelliott, @getusha, @etCoderDysto eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[stephanieelliott]

Summarizing payment on this issue:

• Contributor: @etCoderDysto $250 via Upwork -- PAID
• Contributor+: @getusha $250 via NewDot -- please request

Upwork job is here: https://www.upwork.com/jobs/~0176ca0a6294fa423b

[garrettmknight]

$250 approved for @getusha