[HOLD for payment 2024-08-14] [$250] [CVP] [Critical] Not redirecting to workspace chat and not converting the IOU to an expense report when Pay with business account selected

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.13-3
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @quinthar
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1722037742346479

Action Performed:

1. User A submits an IOU to User B
2. User B selects option "Pay with expensify"
3. Select option "business bank account"
4. Observe the LHN

Expected Result:

A new workspace created and moved the IOU to "expense report" for the payer and user redirected to workspace chat

Actual Result:

Workspace created , Not redirected to workspace chat and not converting the IOU to an expense report

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Screen.Recording.2024-07-26.at.4.52.15.PM.mov

Recording.389.mp4

Logs.txt

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f077fda3c01ec8f0
• Upwork Job ID: 1818013143723474571
• Last Price Increase: 2024-07-29
• Automatic offers:
• gijoe0295 | Contributor | 103331425

Issue Owner

Current Issue Owner: @trjExpensify

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[gijoe0295]

Proposal

Please re-state the problem that we are trying to solve in this issue.

In bottom-up flow, after paying with Expensify using Business bank account, a new workspace created but:

1. Not redirected to workspace chat
2. Not converting the IOU to an expense report

What is the root cause of that problem?

For 2, I could not reproduce it, the IOU is indeed converted to a new expense report inside the newly created workspace. We can easily see that in QA's second video at 0:46:

• The initial $10.00 IOU disappeared in the DM and a message said moved the report to...
• The fourth chat in LHN said Applause's Workspace owes $10.00

For 1, we does not navigate to the workspace chat after creation, just navigate to the add bank account page:

App/src/components/KYCWall/BaseKYCWall.tsx

Lines 128 to 138 in 4ffbd42

	} else if (paymentMethod === CONST.PAYMENT_METHODS.BUSINESS_BANK_ACCOUNT) {
	if (iouReport && ReportUtils.isIOUReport(iouReport)) {
	const policyID = Policy.createWorkspaceFromIOUPayment(iouReport);
	// Navigate to the bank account set up flow for this specific policy
	Navigation.navigate(ROUTES.BANK_ACCOUNT_WITH_STEP_TO_OPEN.getRoute('', policyID));
	return;
	}
	Navigation.navigate(addBankAccountRoute);
	}

What changes do you think we should make in order to solve the problem?

1. Return the newly created employee workspace chat ID from this function:

App/src/libs/actions/Policy/Policy.ts

Line 2067 in e0581a8

function createWorkspaceFromIOUPayment(iouReport: OnyxEntry<Report>): string | undefined {

2. Then navigate to that workspace chat

3. Optionally, we could highlight the newly expense report preview action within that workspace chat by returning the report preview action ID:

App/src/libs/actions/Policy/Policy.ts

Lines 2401 to 2402 in e0581a8

	// We need to move the report preview action from the DM to the workspace chat.
	const reportPreview = ReportActionsUtils.getParentReportAction(iouReport);

So when Business bank account is selected here, add this snippet:

const {policyID, workspaceChatReportID, reportPreviewReportActionID} = Policy.createWorkspaceFromIOUPayment(iouReport) ?? {};

if (workspaceChatReportID) {
    Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(workspaceChatReportID, reportPreviewReportActionID));
}

Screenshots

navigate-to-workspace.mov

RHP opens on top of Workspace chat

The workspace chat is GBR'ed right away

[gijoe0295]

Proposal Updated

• Prettify proposal
• Add details to root cause analysis

[trjExpensify]

Confirming a couple of things in thread.

In the meantime, @gijoe0295 can you include a video of your proposal above to check the expected results? Thanks!

[trjExpensify]

Okay, so sounds like the two items to look at here are:

• Redirect to the workspace chat when clicking the “Pay with business bank account” button option right away when we create the workspace, and open the add bank account page in the RHP of the workspace chat not the DM.
• Make sure the workspace chat with the converted expense report is GBR’d right away, it doesn't require a click into the report preview for it to appear on the workspace chat row in the LHN.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01f077fda3c01ec8f0

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[trjExpensify]

@mananjadhav can you jump on that proposal review, please? We'd love to get this one turned around ASAP. Thanks!

[gijoe0295]

@trjExpensify @mananjadhav Added screenshots to my proposal. My initial proposal addresses all the latest expectations #46339 (comment).

[gijoe0295]

Note that we have a regression from #46323 where Business Bank Account is always selected when selecting Pay with Expensify:

App/src/components/AddPaymentMethodMenu.tsx

Lines 75 to 82 in 25646b9

	// We temporarily disabled P2P debit cards so we will automatically select the personal bank account option if there is no other option to select.
	useEffect(() => {
	if (!isVisible) {
	return;
	}
	onItemSelected(CONST.PAYMENT_METHODS.PERSONAL_BANK_ACCOUNT);
	}, [isPersonalOnlyOption, isVisible, onItemSelected]);

The condition should be !isVisible || !isPersonalOnlyOption. In order to test this flow, please modify that way.

[trjExpensify]

^^ @marcaaron given the context on that PR that deployed a few hours ago, checking you're okay with that change.

For the bottom-up flow, both of these options should be retained:

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[mananjadhav]

@gijoe0295 's proposal looks good to me.

🎀 👀 🎀 C+ reviewed.

[melvin-bot]

Triggered auto assignment to @danieldoglas, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[gijoe0295]

PR ready in 3 hours.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.17-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix: Not redirect to workspace chat when pay IOU with business account #46557

If no regressions arise, payment will be issued on 2024-08-14. 🎊

For reference, here are some details about the assignees on this issue:

• @mananjadhav requires payment through NewDot Manual Requests
• @gijoe0295 requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mananjadhav] The PR that introduced the bug has been identified. Link to the PR:
• [@mananjadhav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mananjadhav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mananjadhav] Determine if we should create a regression test for this bug.
• [@mananjadhav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[gijoe0295]

@trjExpensify Before summarizing payment I wonder if I'm eligible for payments for #46490 since I posted a working solution being used in the PR.

[trjExpensify]

Yeah, we ended up doing two PRs in the end to clear that blocker?

[gijoe0295]

@trjExpensify That's correct. And the blocker's PR was implemented by @mananjadhav.

[mananjadhav]

@trjExpensify We implemented two PRs - one for this blocker which I wrote and the second one for another issue that this PR @gijoe0295 wrote.

But yeah I agree they posted the solution before I implemented in the comments. I implemented it unblock the release.

[trjExpensify]

Cool, so I'll do the following:

• $375 to @gijoe0295 for this issue + taking us most of the way with the proposal on the other issue.
• $500 to @mananjadhav for the other issue's PR, and the C+ review of this one.
• $250 to @mollfpr for the C+ review of the other issue's PR

How does that sound?

[mananjadhav]

A little confused here. Are we talking about any other issue? I don’t think the blocker PR implemented was reviewed by C+. I am not in front of the system. I can check later.

[mollfpr]

@trjExpensify I don't think I reviewed any PR regarding this issue 😅

[trjExpensify]

Ah, @mollfpr is right. You were assigned, but didn't review. Cool, so two issues, two PRs:

Issue: Not redirecting to workspace chat and not converting the IOU to an expense report when Pay with business account selected

• PR: Authored by @gijoe0295, reviewed by @mananjadhav.

Issue: Expense - "Business bank account" option appears briefly when paying with Expensify

• PR: Authored by @mananjadhav, reviewed by Rory (internal).

So amending the payment summary as follows:

• $375 to @gijoe0295 for this issue + taking us most of the way with the proposal on the other issue.
• $500 to @mananjadhav for the other issue's PR, and the C+ review of this one.

Sound right?

[mananjadhav]

That’s right.

[trjExpensify]

Okay great, go ahead and request Manan. @gijoe0295 I've settled up.

[JmillsExpensify]

$500 approved for @mananjadhav