Report field - Show violation on single transaction expense reports

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Found when validating #44139
Version Number: 9.0.12.0
Reproducible in staging?: y
Reproducible in production?: no
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

Precondition:

• Workspace is under Control plan.
• Report fields feature is enabled.
• Text type report field is added and it has no initial value.
• The workspace has no unsettled expense.

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Submit a manual expense.
4. Go to expense report.
5. Note that report field violations do not show up.
6. Submit another manual expense.
7. Note that report field violation shows up.
8. Go to Troubleshoot > Clear cache and restart > Reset and restart.
9. Go to expense report.
10. Note that report field violations disappear..

Expected Result:

In Step 5, report field violation will show up after submitting the first expense.
In Step 10, report field violation will persist after clearing cache and restarting app.

Actual Result:

In Step 5, report field violation does not show up after submitting the first expense.
It only shows up after submitting the second expense (Step 7).
In Step 10, report field violation disappears after clearing cache and restarting app.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6552777_1721919071237.20240725_224410.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @AndrewGable (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[AndrewGable]

@thienlnam @jnowakow @war-in @blazejkustra @allroundexperts - Can you check into this?

[thienlnam]

Doesn't need to be a blocker since this is a new feature - cc @jnowakow

[war-in]

In Step 5, report field violation does not show up after submitting the first expense.

Hi 👋 I think @jnowakow told me that fields haven't shown up for single expenses at the time he was implementing violations. That's why he didn't implement this functionality at the time.

In Step 10, report field violation disappears after clearing cache and restarting app.

It depends on the backend response. If the backend doesn't return the correct data RBRs won't be shown. @thienlnam please share your thoughts here 🙏

[thienlnam]

Heyo, thanks for the context.

For this issue let's handle the single expense reports since they now show the report fields.

The violations coming from the BE is still in the works, pending on other issue so that is still expected

[war-in]

I think I found the cause of the issue: #46425

When the first expense was created we dealt with an optimistic IOU report and there was no fieldList field in it. If the fieldList is undefined we can't tell which fields were violated.

I added fieldList to the OptimisticIOUReport and OptimisticExpenseReport types. That way we can optimistically set fieldList 🎉

I'll mark PR as ready for review tomorrow because I need to test it and record videos

[war-in]

PR is ready for C+ review :)

cc @allroundexperts

[melvin-bot]

This issue has not been updated in over 15 days. @thienlnam, @kadiealexander, @war-in eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[allroundexperts]

Can I get assigned here since I reviewed the PR?

[thienlnam]

Yeah, but this was a regression from #44139

[allroundexperts]

My bad. This can be closed. You're correct @thienlnam