[HOLD for payment 2024-08-09] [$250] Expense - Report turns to skeleton after deleting expense with comments offline

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.7-4
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to DM with any user that has no unsettled expense.
3. Submit an expense.
4. Click on the expense preview.
5. Send a few comments.
6. Go offline.
7. Click on the report header.
8. Click Delete expense.
9. Delete the expense.

Expected Result:

Report will not turn to skeleton after deleting the expense offline.

Actual Result:

The part above the comments turns to skeleton after deleting the expense offline.
This issue only happens when there is only one expense.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6543519_1721109876583.20240716_140113.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d020bfa76c4b7e26
• Upwork Job ID: 1813325690168936392
• Last Price Increase: 2024-07-16
• Automatic offers:
• nkdengineer | Contributor | 103162922

Issue Owner

Current Issue Owner: @Christinadobrzyn

[melvin-bot]

Triggered auto assignment to @grgia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

We think this issue might be related to the #collect project.

[Christinadobrzyn]

Asking if this is related to #44798

[thienlnam]

Taking this over since Georgia is offline

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01d020bfa76c4b7e26

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[chiragsalian]

Not a blocker for backend. The issue purely happens when offline in newDot so its most likely purely a frontend issue.
Removed deployblocker label

[thienlnam]

Going to remove the blocker since this is an edge case flow

[melvin-bot]

📣 @nkdengineer 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[Christinadobrzyn]

PR is under review - #45665

[Christinadobrzyn]

PR is under review - #45665

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.15-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: Report turns to skeleton after deleting expense with comments offline #45665

If no regressions arise, payment will be issued on 2024-08-09. 🎊

For reference, here are some details about the assignees on this issue:

• @parasharrajat requires payment through NewDot Manual Requests
• @nkdengineer requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR:
• [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@parasharrajat] Determine if we should create a regression test for this bug.
• [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: https://github.com/Expensify/Expensify/issues/418512

[parasharrajat]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR: fix: update logic of filtering created actions from transaction thread report #44946
• [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/44946/files#r1701593938
• [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not needed
• [@parasharrajat] Determine if we should create a regression test for this bug. Yes
• [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Steps

1. Go to DM with any user that has no unsettled expense.
2. Submit an expense.
3. Click on the expense preview.
4. Send a few comments.
5. Go offline.
6. Click on the report header.
7. Click Delete expense.
8. Delete the expense.
9. Verify that: Report will not turn to skeleton after deleting the expense offline.

Do you agree 👍 or 👎 ?

[Christinadobrzyn]

Preparing for payment.

Regression test - https://github.com/Expensify/Expensify/issues/418512

Payouts due:

• Contributor: $250 @nkdengineer (upwork offer - https://www.upwork.com/nx/wm/offer/103162922)
• Contributor+: $250 @parasharrajat - paid through NewDot

[Christinadobrzyn]

payment scheduled for tomorrow

[Christinadobrzyn]

payday is here! Paid out based on this payment summary - #45461 (comment)

@parasharrajat please make sure to request a payment through NewDot. Thank you! Closing

[parasharrajat]

Payment requested as per #45461 (comment)

[JmillsExpensify]

$250 approved for @parasharrajat