[PAID] [$250] Expense report - App crashes after exporting expense report to CSV in OD

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.7.4
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4728021
Email or phone of affected tester (no customers): [email protected]
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Precondition: user is a member of a workspace

1. Go to https://staging.new.expensify.com/
   and log in as a member
2. Navigate to the workspace chat
3. Submit an expense
4. Log in as an admin in incognito
5. Open the workspace chat
6. Approve the submitted expense report and pay elsewhere
7. Log into OD as a member
8. Open the paid report
9. Select Export to > Default CSV
10. Navigate to ND as a member and admin

Expected Result:

The system message the report was exported to CSV is added to the expense report, user can continue interact with the app

Actual Result:

The app crashes when navigating to ND as an admin and a blank page is displayed for a member

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6543500_1721107283699.Recording__599.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c1c4c7f4d69f1ec4
• Upwork Job ID: 1813147807396768155
• Last Price Increase: 2024-07-16

Issue Owner

Current Issue Owner: @strepanier03

[melvin-bot]

Triggered auto assignment to @lakchote (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

We think this issue might be related to the #collect project.

[izarutskaya]

Production

bandicam.2024-07-16.11-19-33-167.mp4

[lakchote]

Demoting from blocker as it's an edge case (exporting a CSV in OD then trying to access it in ND) and shouldn't block other PRs . Also making it external.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c1c4c7f4d69f1ec4

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jayeshmangwani (External)

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The app crashes when navigating to ND as an admin and a blank page is displayed for a member

What is the root cause of that problem?

In

App/src/libs/ReportActionsUtils.ts

Line 643 in 1465a92

const resolution = originalMessage && 'resolution' in originalMessage ? originalMessage?.resolution : null;

, we use in operator to search in originalMessage. However originalMessage could be a string and it throws error because in is only supported for objects.

What changes do you think we should make in order to solve the problem?

Update

App/src/libs/ReportActionsUtils.ts

Line 643 in 1465a92

const resolution = originalMessage && 'resolution' in originalMessage ? originalMessage?.resolution : null;

to

const resolution = originalMessage && typeof originalMessage === 'object' && 'resolution' in originalMessage ? originalMessage?.resolution : null;

So we proceed only if originalMessage is an object

What alternative solutions did you explore? (Optional)

In

App/src/libs/ReportActionsUtils.ts

Line 643 in 1465a92

const resolution = originalMessage && 'resolution' in originalMessage ? originalMessage?.resolution : null;

, Replace 'resolution' in originalMessage by originalMessage?.resolution. ?. is safe and will work for any data type of originalMessage

[lakchote]

@jayeshmangwani please review @tienifr's proposal when you can, thanks!

[jayeshmangwani]

Sure, in the next 30 minutes.

[jayeshmangwani]

@tienifr's Proposal of adding the check typeof originalMessage === 'object' looks good to me. I've tested it, and it worked well. We can go with the proposal.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.8-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] fix: app crashes after exporting report to CSV #45580

If no regressions arise, payment will be issued on 2024-07-25. 🎊

For reference, here are some details about the assignees on this issue:

• @jayeshmangwani requires payment through NewDot Manual Requests
• @tienifr requires payment through NewDot Manual Requests

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@jayeshmangwani] The PR that introduced the bug has been identified. Link to the PR:
• [@jayeshmangwani] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@jayeshmangwani] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@jayeshmangwani] Determine if we should create a regression test for this bug.
• [@jayeshmangwani] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@strepanier03] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.9-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] fix: app crashes after exporting report to CSV #45580

If no regressions arise, payment will be issued on 2024-07-26. 🎊

For reference, here are some details about the assignees on this issue:

• @jayeshmangwani requires payment through NewDot Manual Requests
• @tienifr requires payment through NewDot Manual Requests

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@jayeshmangwani] The PR that introduced the bug has been identified. Link to the PR:
• [@jayeshmangwani] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@jayeshmangwani] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@jayeshmangwani] Determine if we should create a regression test for this bug.
• [@jayeshmangwani] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@strepanier03] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[jayeshmangwani]

• [@jayeshmangwani] The PR that introduced the bug has been identified. Link to the PR: fix: LHN of self-DM still shows actionable whisper after submitted #44684
• [@jayeshmangwani] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: fix: LHN of self-DM still shows actionable whisper after submitted #44684 (comment)
• [@jayeshmangwani] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [@jayeshmangwani] Determine if we should create a regression test for this bug. Not Sure
• [@jayeshmangwani] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

I'm not sure about adding this regression test for this issue, as it is a niche case when changes from ND and OD occur together.

But I am proposing the following if we decide to create it:

Regression Test Proposal

1. As workspace member, submit an expense to a workspace
2. As workspace admin, approve and pay the above expense
3. As workspace member, go to OD, open the paid report
4. Select Export to > Default CSV
5. Go to ND, open the workspace chat
6. Verify the app neither crashes nor displays blank page for workspace admin and member
7. Verify that, system message the report was exported to CSV is added to the expense report

Do we agree 👍 or 👎

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @jayeshmangwani owed $250 via NewDot
• Reviewer: @tienifr owed $250 via NewDot

BugZero Checklist (@strepanier03)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1813147807396768155/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[strepanier03]

Payment Summary

• $250 - @jayeshmangwani via NewDot
• $250 - @tienifr via NewDot

@JmillsExpensify - Payment requests (2) incoming.

[JmillsExpensify]

$250 approved for @tienifr

[jayeshmangwani]

@strepanier03 Issue can be closed. I will request on ND

[melvin-bot]

@JmillsExpensify, @strepanier03, @lakchote, @jayeshmangwani, @tienifr Whoops! This issue is 2 days overdue. Let's get this updated quick!

[strepanier03]

Thanks all, closing now.

[jayeshmangwani]

Requested as per #45457 (comment)

[JmillsExpensify]

$250 approved for @tienifr