[$250] Composer - Composer box is refocused when Copying Link on Web and Desktop #45204

lanitochka17 · 2024-07-10T19:48:53Z

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

Version Number: 9.0.6-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Issue found when executing PR #44399

Action Performed:

Right click on a message (in web or desktop)
Select copy to clipboard

Expected Result:

User doesn't expect the composer to get refocused.

Actual Result:

Composer gets refocussed: Expected chart

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6538235_1720636352340.Composer_is_not_refocused.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01a3374b61f565b9cf
Upwork Job ID: 1811154850298352037
Last Price Increase: 2024-10-02

Issue Owner

Current Issue Owner: @situchan

melvin-bot · 2024-07-10T19:49:03Z

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

lanitochka17 · 2024-07-10T19:50:33Z

@lschurr FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

lanitochka17 · 2024-07-10T19:51:02Z

We think that this bug might be related to #vip-vsb

melvin-bot · 2024-07-10T21:45:42Z

Job added to Upwork: https://www.upwork.com/jobs/~01a3374b61f565b9cf

melvin-bot · 2024-07-10T21:45:46Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

gijoe0295 · 2024-07-10T23:43:19Z

I'm the author of #44399. That's our bad not to note a precondition for the composer to automatically refocus: it must already be focused before interacting with the context menu. So this is not a valid bug considering the current expectations. We can still change the expectations but should note that this is not a regression. Thanks.

nkdengineer · 2024-07-11T08:30:32Z

Edited by proposal-police: This proposal was edited at 2024-08-05 18:25:46 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

The composer is NOT refocused

What is the root cause of that problem?

When a report is focused, we set the composer focus callback with shouldFocusForNonBlurInputOnTapOutside as false by default

App/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions/ComposerWithSuggestions.tsx

Lines 589 to 591 in a19ef98

    
           ReportActionComposeFocusManager.onComposerFocus((shouldFocusForNonBlurInputOnTapOutside = false) => { 
        
               if ((!willBlurTextInputOnTapOutside && !shouldFocusForNonBlurInputOnTapOutside) || !isFocused) { 
        
                   return;

When we click on the copy link, we call ReportActionComposeFocusManager.focus function to focus on the composer. The difference here is willBlurTextInputOnTapOutside is false in the native platform and true in other platforms and shouldFocusForNonBlurInputOnTapOutside is false by default so the composer is always re-focused on web/desktop and not re-focused on native

App/src/pages/home/report/ContextMenu/ContextMenuActions.tsx

Line 454 in a19ef98

hideContextMenu(true, ReportActionComposeFocusManager.focus);

What changes do you think we should make in order to solve the problem?

We should keep track the composer is focused or not when we open the context menu. Then we pass it as payload data when we open the context menu.

In ReportActionComposeFocusManager, create a new variable to keep track of the time the composer is blurred. And create a function to check this. We have a check time - (composerBluredTime ?? 0) <= 100 because when we open the context menu, the composer is blurred and then the context menu is opened immediately.

let composerBluredTime: number | null = null;
function blur() {
    composerBluredTime = new Date().getTime();
}

function isJustBlured(time: number) {
    return time - (composerBluredTime ?? 0) <= 100;
}

Calling ReportActionComposeFocusManager.blur() here when the composer is blurred

ReportActionComposeFocusManager.blur()

App/src/pages/home/report/ReportActionCompose/ReportActionCompose.tsx

Line 308 in 98d8a5a

const onBlur = useCallback(

Add an extra param isComposerFocused here

isComposerFocused = false,

App/src/pages/home/report/ContextMenu/ReportActionContextMenu.ts

Line 121 in 98d8a5a

isOverflowMenu = false,

App/src/pages/home/report/ContextMenu/ReportActionContextMenu.ts

Line 151 in 98d8a5a

isOverflowMenu,

In PopoverReportActionContextMenu, get this param here and pass it to BaseReportActionContextMenu

App/src/pages/home/report/ContextMenu/PopoverReportActionContextMenu.tsx

Line 173 in 98d8a5a

isOverflowMenu = false,

Pass isComposerFocused as a payload data here

App/src/pages/home/report/ContextMenu/BaseReportActionContextMenu.tsx

Line 244 in 98d8a5a

const payload: ContextMenuActionPayload = {

Pass isComposerFocused param as ReportActionComposeFocusManager.isJustBlured(new Date().getTime()) || ReportActionComposeFocusManager.isFocused() when we open the context menu here.

false,
ReportActionComposeFocusManager.isJustBlured(new Date().getTime()) || ReportActionComposeFocusManager.isFocused(),

App/src/pages/home/report/ReportActionItem.tsx

Line 365 in 98d8a5a

setIsEmojiPickerActive as () => void,

Get isComposerFocused here and check if it's true we will

hideContextMenu(true, () => {
    if (!isComposerFocused) {
        return;
    }
    ReportActionComposeFocusManager.focus(true);
});

App/src/pages/home/report/ContextMenu/ContextMenuActions.tsx

Line 454 in 98d8a5a

onPress: (closePopover, {reportAction, reportID}) => {

The test branch here https://github.com/nkdengineer/App/tree/fix/45204

What alternative solutions did you explore? (Optional)

If we want to not focus on the composer after we select the context menu action in mWeb, we can add shouldFocusInputOnScreenFocus check here.

if ((!willBlurTextInputOnTapOutside && !shouldFocusForNonBlurInputOnTapOutside && !shouldFocusInputOnScreenFocus) || !isFocused) {
    return;
}

App/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions/ComposerWithSuggestions.tsx

Lines 589 to 591 in a19ef98

    
           ReportActionComposeFocusManager.onComposerFocus((shouldFocusForNonBlurInputOnTapOutside = false) => { 
        
               if ((!willBlurTextInputOnTapOutside && !shouldFocusForNonBlurInputOnTapOutside) || !isFocused) { 
        
                   return;

shouldFocusInputOnScreenFocus is used to consistent the focus behavior mWeb and native so we can use this

App/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions/ComposerWithSuggestions.tsx

Lines 206 to 208 in 5af66e0

    
           // We want consistent auto focus behavior on input between native and mWeb so we have some auto focus management code that will 
        
           // prevent auto focus on existing chat for mobile device 
        
           const shouldFocusInputOnScreenFocus = canFocusInputOnScreenFocus();

situchan · 2024-07-12T06:04:25Z

Platform	Focused before menu	Focused after copying link (before fix)	Focused after copying link (after fix)
Web	✅	✅
Web	❌	✅
mSafari	✅	✅
mSafari	❌	✅
mChrome	✅	✅
mChrome	❌	✅
iOS	✅	✅
iOS	❌	❌ (bug to fix)	✅
Android	✅	✅ (but no keyboard popup)
Android	❌	❌ (bug to fix)	✅

So the expected behavior is to refocus always on all platforms regardless of pre-focus status?

nkdengineer · 2024-07-15T04:30:33Z

So the expected behavior is to refocus always on all platforms regardless of pre-focus status?

I think it's expected.

lschurr · 2024-07-15T14:49:27Z

Any update @situchan? Are we saying this is expected and not a bug?

melvin-bot · 2024-07-15T18:34:28Z

@lschurr, @situchan Whoops! This issue is 2 days overdue. Let's get this updated quick!

situchan · 2024-07-16T05:31:01Z

Any update @situchan? Are we saying this is expected and not a bug?

I am saying this is not worth fixing.

@Expensify/design what do you think of #45204 (comment)?

shawnborton · 2024-07-16T05:46:14Z

Hmm interesting one for sure. My first reaction is that I don't think I would expect the composer to be refocused after using the Copy link menu item. The user is basically electing to tap outside of the composer box... so I don't think we should assume that they want to head back into the composer box immediately after interacting with a different part of the app. Curious what Danny and Jon think though!

shawnborton · 2024-07-16T05:47:05Z

At the same time, if we only have two places (iOS and Android) where we aren't doing this behavior, I can see where it makes sense to make everything consistent so we have the same exact behavior on all platforms.

dannymcclain · 2024-07-16T14:51:51Z

My first reaction is that I don't think I would expect the composer to be refocused after using the Copy link menu item. The user is basically electing to tap outside of the composer box... so I don't think we should assume that they want to head back into the composer box immediately after interacting with a different part of the app.

Totally agree with this 100%.

At the same time, if we only have two places (iOS and Android) where we aren't doing this behavior, I can see where it makes sense to make everything consistent so we have the same exact behavior on all platforms.

Personally I think it makes more sense to not refocus the input on any platform after an action like this... but that might just be my personal preference :run-away:.

On mobile, the keyboard takes up so much space and sometimes it can be hard to remove focus from the composer (and get the keyboard to go away). And trying to browse a conversation with the keyboard up is pretty frustrating. So I think I would still prefer not auto-focusing the composer. Just :my-two-cents:.

situchan · 2024-07-16T17:46:05Z

Thanks for the feedback.
Looks like we wanna focus only on web / desktop, not focus on all mobile platforms (iOS, android, mWeb) for consistency.

Platform	Focused before menu	Focused after copying link (before fix)	Focused after copying link (after fix)
Web	✅	✅
Web	❌	✅
mSafari	✅	✅
mSafari	❌	✅ (bug to fix)	❌
mChrome	✅	✅
mChrome	❌	✅ (bug to fix)	❌
iOS	✅	✅
iOS	❌	❌
Android	✅	✅ (but no keyboard popup)
Android	❌	❌

dubielzyk-expensify · 2024-07-17T02:07:28Z

I'm with Danny on this one. I don't think it makes that much sense to do on mobile due to the keyboard popping up. On desktop you got two input methods (keyboard and mouse) and focusing the composer doesn't break any flow or require a dismissal so that's fine for me. But on mobile, I just think it'd be more disruptive

nkdengineer · 2024-07-17T05:24:05Z

Updated proposal #45204 (comment) with new expected behavior.

shawnborton · 2024-07-17T05:29:49Z

Cool cool, thanks to you both for your thoughts - I like where you landed.

melvin-bot · 2024-07-17T16:00:05Z

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

lschurr · 2024-09-04T15:52:12Z

Still looking for proposals

melvin-bot · 2024-09-04T16:00:54Z

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

situchan · 2024-09-04T18:42:21Z

Not overdue

mvtglobally · 2024-09-09T04:08:22Z

Issue not reproducible during KI retests. (First week)

lschurr · 2024-09-09T15:33:08Z

Hey @situchan - Are you able to reproduce this one still?

melvin-bot · 2024-09-10T18:02:13Z

@lschurr, @srikarparsi, @situchan Eep! 4 days overdue now. Issues have feelings too...

situchan · 2024-09-10T19:24:37Z

OP is outdated. This is final expected behavior.

situchan · 2024-09-10T19:28:19Z

still reproducible on v9.0.31-22

web.mp4

melvin-bot · 2024-09-11T16:00:46Z

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

mvtglobally · 2024-09-13T16:36:03Z

Issue not reproducible during KI retests. (Second week)

situchan · 2024-09-16T01:30:31Z

Not overdue

melvin-bot · 2024-09-18T16:00:41Z

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot · 2024-09-25T16:00:38Z

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot · 2024-09-27T18:01:27Z

@lschurr, @srikarparsi, @situchan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

lschurr · 2024-10-01T12:35:07Z

I'm OOO until next week - Did we come to a decision about this one @srikarparsi?

melvin-bot · 2024-10-01T18:02:16Z

@lschurr, @srikarparsi, @situchan 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

srikarparsi · 2024-10-01T21:59:45Z

Just followed up in the thread

melvin-bot · 2024-10-02T16:00:34Z

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot · 2024-10-03T18:02:51Z

@lschurr, @srikarparsi, @situchan 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

mallenexpensify · 2024-10-03T21:39:19Z

Closing, as we closed #vib-vsb, this is an edge case bug and not a near-term priority.

lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jul 10, 2024

melvin-bot bot assigned lschurr Jul 10, 2024

lschurr added the External Added to denote the issue can be worked on by a contributor label Jul 10, 2024

melvin-bot bot changed the title ~~Composer - Composer box is not refocused when Copying Link~~ [$250] Composer - Composer box is not refocused when Copying Link Jul 10, 2024

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 10, 2024

melvin-bot bot assigned situchan Jul 10, 2024

kbecciv mentioned this issue Jul 10, 2024

Deploy Checklist: New Expensify 2024-07-10 #45144

Closed

melvin-bot bot added the Overdue label Jul 15, 2024

melvin-bot bot removed the Overdue label Jul 16, 2024

melvin-bot bot removed the Overdue label Sep 4, 2024

melvin-bot bot added the Overdue label Sep 9, 2024

melvin-bot bot removed the Overdue label Sep 10, 2024

melvin-bot bot added the Overdue label Sep 13, 2024

melvin-bot bot removed the Overdue label Sep 16, 2024

melvin-bot bot added Overdue and removed Overdue labels Sep 18, 2024

melvin-bot bot added the Overdue label Sep 27, 2024

mallenexpensify closed this as completed Oct 3, 2024

melvin-bot bot removed the Overdue label Oct 3, 2024

[$250] Composer - Composer box is refocused when Copying Link on Web and Desktop #45204

[$250] Composer - Composer box is refocused when Copying Link on Web and Desktop #45204

Comments

lanitochka17 commented Jul 10, 2024 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

melvin-bot bot commented Jul 10, 2024

lanitochka17 commented Jul 10, 2024

lanitochka17 commented Jul 10, 2024

melvin-bot bot commented Jul 10, 2024

melvin-bot bot commented Jul 10, 2024

gijoe0295 commented Jul 10, 2024 • edited Loading

nkdengineer commented Jul 11, 2024 • edited by github-actions bot Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

situchan commented Jul 12, 2024

nkdengineer commented Jul 15, 2024

lschurr commented Jul 15, 2024

melvin-bot bot commented Jul 15, 2024

situchan commented Jul 16, 2024

shawnborton commented Jul 16, 2024

shawnborton commented Jul 16, 2024

dannymcclain commented Jul 16, 2024

situchan commented Jul 16, 2024

dubielzyk-expensify commented Jul 17, 2024

nkdengineer commented Jul 17, 2024

shawnborton commented Jul 17, 2024

melvin-bot bot commented Jul 17, 2024

lschurr commented Sep 4, 2024

melvin-bot bot commented Sep 4, 2024

situchan commented Sep 4, 2024

mvtglobally commented Sep 9, 2024

lschurr commented Sep 9, 2024

melvin-bot bot commented Sep 10, 2024

situchan commented Sep 10, 2024

situchan commented Sep 10, 2024

melvin-bot bot commented Sep 11, 2024

mvtglobally commented Sep 13, 2024

situchan commented Sep 16, 2024

melvin-bot bot commented Sep 18, 2024

melvin-bot bot commented Sep 25, 2024

melvin-bot bot commented Sep 27, 2024

lschurr commented Oct 1, 2024

melvin-bot bot commented Oct 1, 2024

srikarparsi commented Oct 1, 2024

melvin-bot bot commented Oct 2, 2024

melvin-bot bot commented Oct 3, 2024

mallenexpensify commented Oct 3, 2024

lanitochka17 commented Jul 10, 2024 •

edited by melvin-bot bot

Loading

gijoe0295 commented Jul 10, 2024 •

edited

Loading

nkdengineer commented Jul 11, 2024 •

edited by github-actions bot

Loading