You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
During review for the detailed design, we decided we should support offline pattern B when manually exporting reports here. To implement that we need to
Create an optimistic EXPORTINTEGRATION action in our Report.exportToIntegration and Report.markAsManuallyExported actions
The text should say started exporting this report to {integration}...
Pass the optimisticReportActionID to both Report_Export and MarkAsExported APIs
Use the ID to create the action in Auth
Auth will queue updates for the report action with the final text: exported this report to {integration}. [View out-of-pocket expenses].
On failure
create the INTEGRATIONSMESSAGE action with the error message like normal (using a different ID)
delete the optimistic action on the frontend using failureData
Manual Test Steps
Sucessful offline export
Submit an expense report
Log in as the workspace admin
Approve the report
Go offline
3-dot menu > Export > Xero
Verify a semi-transparent exported action gets added to the report
Go online
Verify the action becomes fully opaque
Failed offline export
Prerequisites
Add a chart of account (expense category) to Xero that you can delete later
Steps
Create a report with an expense
Categorize the expense using the new Xero category
Submit it
Log in as the workspace admin and approve the report
Log into Xero and delete the chart of account
Go offline in NewDot
Export the report to Xero (3-dot menu > Export > Xero)
Verify a semi-transparent exported action gets added to the report
Go online
Verify
the exported action is removed
a report export error action is added in it's place
Automated Tests
Verify optimisticData for the INTEGRATIONSMESSAGE is merged for both Report.exportToIntegration and Report.markAsManuallyExported actions
Verify failureData removes the action
The text was updated successfully, but these errors were encountered:
This issue has not been updated in over 15 days. @lakchote eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
Main issue: https://github.com/Expensify/Expensify/issues/409245
Part of QBO Export and Error Handling in NewDot
Doc section: https://docs.google.com/document/d/1aQl-AK_F6IqszWYG2aEllTsD5x3h4b8Zu0XEG0LuQ08/edit#heading=h.xw0s9oqvo44s
Project: https://github.com/orgs/Expensify/projects/129
Feature Description
During review for the detailed design, we decided we should support offline pattern B when manually exporting reports here. To implement that we need to
EXPORTINTEGRATION
action in ourReport.exportToIntegration
andReport.markAsManuallyExported
actionsstarted exporting this report to {integration}...
optimisticReportActionID
to bothReport_Export
andMarkAsExported
APIsexported this report to {integration}. [View out-of-pocket expenses].
INTEGRATIONSMESSAGE
action with the error message like normal (using a different ID)failureData
Manual Test Steps
Sucessful offline export
Failed offline export
Prerequisites
Steps
Automated Tests
INTEGRATIONSMESSAGE
is merged for bothReport.exportToIntegration
andReport.markAsManuallyExported
actionsThe text was updated successfully, but these errors were encountered: