[HOLD for payment 2024-07-24] Search - Grouped expenses show User submits to User instead of to Workspace

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.5-4
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Launch New Expensify app.
2. Create a new workspace.
3. Go to workspace chat.
4. Submit two expenses.
5. Go to Search.
6. Go to Shared (important).

Expected Result:

The grouped expenses will show that user submits to the workspace.

Actual Result:

The grouped expenses shows that user submits to the same user.
On web layout, it displays correctly, which is user submits to the workspace.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6536279_1720469431803.RPReplay_Final1720469217.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @alexpensify

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @AndrewGable (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

@alexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think this issue might be related to the #collect project.

[izarutskaya]

Production

[AndrewGable]

@luacmartins - Just wanted to confirm that the expected steps are correct on this one: we want to show the user or workspace being submitted to on the grouped UI?

[luacmartins]

We should be showing the workspace as submitted to

[luacmartins]

I'm pretty sure this comes from this PR. @c3024 @brunovjk could you please take a look?

[c3024]

transactionItem has a reportType field to check if the transaction is an expense. reportItem does not have it. I think ideally backend should send reportType for reportItem as well.

We can just use type of one of the transactions' reportType also to check if it is an expense report without any changes on backend.

[AndrewGable]

@c3024 @luacmartins - Should we revert the PR and make the changes to the backend and update the original PR?

[luacmartins]

I have some draft PRs up, I'll finish them once I'm done with a call. Meanwhile, we can demote this to NAB since part of the fix is in Auth.

[luacmartins]

@alexpensify for clarify, there's no payment due on this issue. It'll be handled in #44093

[alexpensify]

Noted, thank you for that update!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.7-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix to field on reportListItem #45105

If no regressions arise, payment will be issued on 2024-07-24. 🎊

For reference, here are some details about the assignees on this issue:

• @brunovjk requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@brunovjk] The PR that introduced the bug has been identified. Link to the PR:
• [@brunovjk] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@brunovjk] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@brunovjk] Determine if we should create a regression test for this bug.
• [@brunovjk] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@alexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[brunovjk]

Hello @luacmartins :D I was about to fill out the BugZero Checklist, I'm confused, does this issue count as a regression for this PR? Thanks.

[luacmartins]

I don't think so, they had different root causes.

[brunovjk]

• [@brunovjk] The PR that introduced the bug has been identified. Link to the PR: N/A
• [@brunovjk] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• [@brunovjk] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [@brunovjk] Determine if we should create a regression test for this bug. Yes
• [@brunovjk] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. * Since there's no payment due on this issue. It'll be handled in 44093, the regression test can be the same.

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @brunovjk paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@alexpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[alexpensify]

Based on this update: #45013 (comment), there is no required payment action. Closing!