[HOLD for payment 2024-07-24] [$250] Login – Expensify changes to Hidden in LHN if login with new Gmail account and reload page

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v9.0.4-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4694015
Email or phone of affected tester (no customers): [email protected]
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Log in with a new Gmail account
3. Choose Track and Budget Expenses
4. Enter your name in Onboarding modal
5. Verify Expensify and Concierge chats present in LHN
6. Reload page

Expected Result:

Expensify and Concierge chats present in LHN

Actual Result:

Hidden is name of Expensify and user name/Hidden as a Concierge in LHN, when login with new Gmail account and reload page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6532713_1720069292265.Hidden_is_name_of_Expensify_and_user_name_as_a_Concierge.mp4

2024-07-08_13-03-19.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ac469d1b3213174d
• Upwork Job ID: 1810389985506651244
• Last Price Increase: 2024-07-08
• Automatic offers:
• ahmedGaber93 | Reviewer | 103078265
• dominictb | Contributor | 103078266

Issue Owner

Current Issue Owner: @Christinadobrzyn

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[dominictb]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Hidden is name of Expensify and user name/Hidden as a Concierge in LHN, when login with new Gmail account and reload page

What is the root cause of that problem?

In

App/src/libs/migrations/Participants.ts

Line 46 in 6ac95e4

if (report?.participantAccountIDs) {

we just check report?.participantAccountIDs, to start migrating Participants.

After login, participantAccountIDs is empty ([]) so there's nothing to migrate. but it still pass the above check

-> the valid accountID in participants is set to null

App/src/libs/migrations/Participants.ts

Line 65 in 6ac95e4

participants[accountID] = null;

Logic to display Hidden based on participants

We're showing the display name based on option.text in

App/src/components/LHNOptionsList/OptionRowLHN.tsx

Line 134 in a91b7f8

const fullTitle = isGroupChat ? ReportUtils.getGroupChatName(undefined, false, report) : optionItem.text;

option.text = ReportUtils.getReportName

App/src/libs/SidebarUtils.ts

Lines 442 to 444 in a91b7f8

	const reportName = ReportUtils.getReportName(report, policy);
	result.text = reportName;

In the detail implementation of getReportName, we get the reportName from participantsWithoutCurrentUser

App/src/libs/ReportUtils.ts

Line 3466 in a91b7f8

return participantsWithoutCurrentUser.map((accountID) => getDisplayNameForParticipant(accountID, isMultipleParticipantReport)).join(', ');

In this case participantsWithoutCurrentUser is empty -> Hidden is shown

App/src/components/DisplayNames/index.tsx

Line 9 in a91b7f8

const title = fullTitle || translate('common.hidden');

What changes do you think we should make in order to solve the problem?

We need to add the check for empty list in here

            if (report?.participantAccountIDs && !isEmpty(report?.participantAccountIDs)) {

What alternative solutions did you explore? (Optional)

NA

[Christinadobrzyn]

I'm not sure if this can be external - we'll start there.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01ac469d1b3213174d

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ahmedGaber93 (External)

[ahmedGaber93]

Reviewing today

[ahmedGaber93]

@dominictb Thanks for the proposal.
Your proposal works well, but can you please mention the code follow that display 'Hidden' based on participants with explanation if needed in your root cause?

[dominictb]

@ahmedGaber93 I added the detail explanation in my proposal

[ahmedGaber93]

@dominictb's proposal LGTM!

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @carlosmiceli, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @ahmedGaber93 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @dominictb 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[Christinadobrzyn]

working on the PR - #45369

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.7-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: check empty array for report participants #45369

If no regressions arise, payment will be issued on 2024-07-24. 🎊

For reference, here are some details about the assignees on this issue:

• @ahmedGaber93 requires payment automatic offer (Reviewer)
• @dominictb requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ahmedGaber93] The PR that introduced the bug has been identified. Link to the PR:
• [@ahmedGaber93] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@ahmedGaber93] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@ahmedGaber93] Determine if we should create a regression test for this bug.
• [@ahmedGaber93] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: https://github.com/Expensify/Expensify/issues/414726

[ahmedGaber93]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ahmedGaber93] The PR that introduced the bug has been identified. Link to the PR: Participants migration #40254
• [@ahmedGaber93] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/40254/files#r1686288563
• [@ahmedGaber93] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [@ahmedGaber93] Determine if we should create a regression test for this bug. Yes
• [@ahmedGaber93] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

1. Go to NewDot
2. Log in with a new Gmail account
3. Choose Track and Budget Expenses
4. Enter your name in Onboarding modal
5. Verify Expensify and Concierge chats present in LHN
6. Reload page
7. Verify that: Expensify and Concierge chats present in LHN with correct name instead of Hidden

Do we agree 👍 or 👎

[Christinadobrzyn]

Regression test - https://github.com/Expensify/Expensify/issues/414726

Payouts due on payment day:

• Contributor: $250 @dominictb (Paid in Upwork - https://www.upwork.com/nx/wm/workroom/37820150/overview)
• Contributor+: $250 @ahmedGaber93 (Paid in Upwork - https://www.upwork.com/nx/wm/workroom/37789064/overview)

[Christinadobrzyn]

Payment day - payment summary here - #44833 (comment)

Closing this as complete!