[HOLD for payment 2024-07-26] [$250] iOS - Distance - Center icon overlaps with compass icon

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.2-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Launch New Expensify app
2. Go to FAB > Submit expense > Distance
3. Use two fingers to rotate the map

Expected Result:

Center icon will not overlap with compass icon

Actual Result:

Center icon overlaps with compass icon

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6525406_1719418260738.RPReplay_Final1719412840.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c7fdbfc969413a5e
• Upwork Job ID: 1806794874145887299
• Last Price Increase: 2024-06-28
• Automatic offers:
• ahmedGaber93 | Reviewer | 102939572
• Krishna2323 | Contributor | 102939574

Issue Owner

Current Issue Owner: @trjExpensify

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@trjExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-vsp

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

iOS - Distance - Center icon overlaps with compass icon

What is the root cause of that problem?

The centre icon is placed with p5 (20px) padding.

App/src/components/MapView/MapView.tsx

Lines 269 to 281 in 67186f1

	{interactive && (
	<View style={[styles.pAbsolute, styles.p5, styles.t0, styles.r0, {zIndex: 1}]}>
	<Button
	onPress={centerMap}
	iconFill={theme.icon}
	iconStyles={styles.ml1}
	medium
	icon={Expensicons.Crosshair}
	accessibilityLabel={translate('common.center')}
	/>
	</View>
	)}
	</View>

What changes do you think we should make in order to solve the problem?

Adjust the padding to change the position of the icon to bottom left/right.

What alternative solutions did you explore? (Optional)

Options 1. Hide the compass using compassEnabled prop.

Options 2. Updated compass position using compassPosition prop. Scale bar position can also be changed using scaleBarPosition

Option 3. Compass can also be hidden by positioning it just below the center button compassPosition={{top: 20, right: 20}}.

[trjExpensify]

Hm, @Expensify/design I'm not sure on this. Do we literally just cover the compass icon in the background or should it not be there at all?

[shawnborton]

Ah interesting, that only shows up if you rotate the map I bet?

[dannymcclain]

Ah interesting, that only shows up if you rotate the map I bet?

Yup you're right. I had never seen that compass before but I just tested out rotating the map and that's when it shows up. Womp.

[trjExpensify]

Goooot it. So both of these UI elements need to live together in the same view then conceivably?

[shawnborton]

It looks like we can also just move the compass or disable it entirely. From here:

So I like the idea of maybe moving the compass to the bottom right or something? Curious what @Expensify/design thinks.

[trjExpensify]

Got it. Bottom right, above the info button? We can pay a retainer to get rid of all the Mapbox stuff at the bottom at some point in the future.

I think we should keep the compass, as I think it's pretty standard when turning the map to reorientate it.

[shawnborton]

Yeah, that's what I was thinking. And the info button would typically always show because the default view is not to rotate the map.

[trjExpensify]

Sounds good!

[Krishna2323]

@shawnborton @trjExpensify, what do you think about placing the compass below the scale bar? I think it relates to the scale bar and should be positioned near it.

below_scalebar.mp4

[trjExpensify]

Works for me, but I'll defer to Shawn!

[dannymcclain]

I like it beneath the scale bar—it does feel kinda related and tucks up in there nicely. Will also wait for Shawn to weigh in 🙂

[shawnborton]

Oh I really like that too, let's do it

[Krishna2323]

@trjExpensify, can we apply the external label to get this moving?

[trjExpensify]

Let's do it!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c7fdbfc969413a5e

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ahmedGaber93 (External)

[ahmedGaber93]

@Krishna2323's alternative solutions option 2 using compassPosition to change the compass position LGTM!
also, result is accepted by the design team.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @lakchote, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @GoldenDragon320! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[lakchote]

@Krishna2323's proposal LGTM.

[melvin-bot]

📣 @ahmedGaber93 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @Krishna2323 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[ahmedGaber93]

@Krishna2323 please let me know when PR is ready. thanks!

[Krishna2323]

@ahmedGaber93 PR ready for review ^.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.9-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: iOS - Distance - Center icon overlaps with compass icon. #44752

If no regressions arise, payment will be issued on 2024-07-26. 🎊

For reference, here are some details about the assignees on this issue:

• @ahmedGaber93 requires payment automatic offer (Reviewer)
• @Krishna2323 requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ahmedGaber93] The PR that introduced the bug has been identified. Link to the PR:
• [@ahmedGaber93] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@ahmedGaber93] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@ahmedGaber93] Determine if we should create a regression test for this bug.
• [@ahmedGaber93] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[ahmedGaber93]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ahmedGaber93] The PR that introduced the bug has been identified. Link to the PR: fix add center button and blue dot #40759
• [@ahmedGaber93] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: fix add center button and blue dot #40759 (comment)
• [@ahmedGaber93] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [@ahmedGaber93] Determine if we should create a regression test for this bug. Yes
• [@ahmedGaber93] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

1. Go to FAB > Submit expense > Distance
2. Android only - Look at the map view Verify compass icon is displayed by default on the top left corner and there is no scale bar
3. iOS only - Use two fingers to rotate the map and Verify compass icon is displayed after rotate on the top left corner and there is no scale bar

Do we agree 👍 or 👎

[trjExpensify]

Payment summary as follows:

• $250 to @ahmedGaber93 for C+
• $250 to @Krishna2323 for the fix

Paid!