[HOLD for payment 2024-07-24] [$250] Expense - Payment buttons show different amount for report consisting of submitted & tracked expense

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.0.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Submit an expense ($200).
4. Track an expense ($100).
5. Look at the amount on the payment button in expense preview in the main chat and expense report.

Expected Result:

The amount on the payment button in expense preview in the main chat and expense report should be the same.

Actual Result:

The amount on the payment button in expense preview in the main chat and expense report are different.
Main chat shows $300.
Expense report shows $200.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6520331_1718960940842.20240621_170327.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019e4af48063736ac0
• Upwork Job ID: 1805264313238989971
• Last Price Increase: 2024-06-24

Issue Owner

Current Issue Owner: @slafortune

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[m-natarajan]

@slafortune FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[m-natarajan]

We think that this bug might be related to #wave-collect - Release 1

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The amount in report preview button and in expense report button is different.

What is the root cause of that problem?

In report preview, we always use the total amount of the expense.

App/src/components/ReportActionItem/ReportPreview.tsx

Lines 205 to 208 in 68374a5

	const getDisplayAmount = (): string => {
	if (totalDisplaySpend) {
	return CurrencyUtils.convertToDisplayString(totalDisplaySpend, iouReport?.currency);
	}

In expense report header, we use the reimbursableSpend for the amount.

App/src/components/MoneyReportHeader.tsx

Line 123 in 68374a5

const formattedAmount = CurrencyUtils.convertToDisplayString(reimbursableSpend, moneyRequestReport.currency);

The expense report header also have more condition to show the amount, for example, if there is an held expense, then we only show the non-hold amount.

App/src/components/MoneyReportHeader.tsx

Line 125 in 68374a5

const displayedAmount = ReportUtils.hasHeldExpenses(moneyRequestReport.reportID) && canAllowSettlement ? nonHeldAmount : formattedAmount;

But if every expense are held, then we don't show the amount.

App/src/components/MoneyReportHeader.tsx

Line 242 in 68374a5

formattedAmount={!ReportUtils.hasOnlyHeldExpenses(moneyRequestReport.reportID) ? displayedAmount : ''}

What changes do you think we should make in order to solve the problem?

To make it consistent, we can follow the condition/logic from the expense report header. We will create a new function called getSettlementAmount which will use the reimbursableSpend as the amount and take the other condition from the expense report header.

const getSettlementAmount = () => {
    if all is on hold: return empty
    if has held expense and allow settlement: return non held amount
    
    return CurrencyUtils.convertToDisplayString(reimbursableSpend, iouReport?.currency);
}

Also, I found that it's possible that the amount is 0 when we have 1 submitted expense and 1 tracked expense and hold the submitted expense. The non-held amount in this case will be -0. If we don't want to show 0, then we can return an empty string if it's 0.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~019e4af48063736ac0

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[thesahindia]

@bernhardoj's proposal looks good to me!

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @dangrous, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[dangrous]

whattt I thought I posted a comment here yesterday. Well, it said basically:

This proposal makes sense! But, I want to confirm internally to make sure there's not a specific reason that these DON'T currently match (like, from an accounting or other perspective). I've asked in Slack and should hear back soon! (internal link: https://expensify.slack.com/archives/C03U7DCU4/p1719527792898199)

[dangrous]

reasked, that was a bad time to do it I think. Hopefully will have an answer soon! If I hear nothing, I think we can move forward because to me it seems to make sense that they should match.

[dangrous]

rude, melvin.

[dangrous]

Okay after discussing internally, we're closing this out as expected behavior - thanks so much for the proposal and review @thesahindia and @bernhardoj

Basically the thought is the preview shows all charges, the pay button only shows what you can actually pay currently, and so both serve different purposes.

[bernhardoj]

PR is ready

cc: @thesahindia

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.7-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix different amount shown in pay buttons between report preview and expense report header #44838

If no regressions arise, payment will be issued on 2024-07-24. 🎊

For reference, here are some details about the assignees on this issue:

• @bernhardoj requires payment through NewDot Manual Requests
• @thesahindia requires payment through NewDot Manual Requests

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@thesahindia] The PR that introduced the bug has been identified. Link to the PR:
• [@thesahindia] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@thesahindia] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@thesahindia] Determine if we should create a regression test for this bug.
• [@thesahindia] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@slafortune] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[dangrous]

not overdue, payment tomorrow.

[bernhardoj]

Requested in ND.

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @bernhardoj owed $250 via NewDot
• Reviewer: @thesahindia owed $250 via NewDot

BugZero Checklist (@slafortune)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1805264313238989971/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[slafortune]

@bernhardoj can you please complete the checklist?

[bernhardoj]

@slafortune @thesahindia is the C+ here.

[slafortune]

Ah yes - sorry about that!

@thesahindia can you please complete the checklist?

[slafortune]

@bernhardoj role Contributor - owed $250 via NewDot
@thesahindia role C+ - owed $250 via NewDot

[JmillsExpensify]

$250 approved for @bernhardoj

[melvin-bot]

@dangrous, @slafortune, @bernhardoj, @thesahindia Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[thesahindia]

It was like this from the beginning.

If we want we can add a test case, here are the steps:-

1. Go to a workspace chat
2. Click at the "+" icon
3. Click on "Submit expense" > Fill the details
4. Click at "+" icon again
5. Click on "Track expense" > Fill the details
6. Verify the report preview pay button shows the submitted expense amount and doesn't include the track amount

[slafortune]

cc - @JmillsExpensify
@thesahindia role C+ - owed $250 via NewDot

[JmillsExpensify]

$250 approved for @thesahindia