[HOLD for payment 2024-07-26] [$250] [Hold] Distance rates- Deleted distance rate is not disabled when submitting distance expense offline #44154

lanitochka17 · 2024-06-21T13:00:25Z

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

Version Number: 9.0.0-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4652159
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

Workspace has a few distance rates

Go to staging.new.expensify.com
Go to workspace settings > Distance rates
Go offline
Delete one of the distance rates
Go to workspace chat
Submit a distance expense with the deleted distance rate
Go online

Expected Result:

In Step 6, app should prevent the deleted distance rate from being selected when submitting a distance distance

Actual Result:

In Step 6, user can submit a distance expense with the deleted distance rate, which results in error when returning online

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6520132_1718947996614.20240621_132706.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01ad6ccc1c574e1a03
Upwork Job ID: 1810478926161920694
Last Price Increase: 2024-07-09
Automatic offers:

shubham1206agra | Reviewer | 103049061
paultsimura | Contributor | 103049063

Issue Owner

Current Issue Owner: @OfstadC

melvin-bot · 2024-06-21T13:00:35Z

Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

lanitochka17 · 2024-06-21T13:01:07Z

@OfstadC FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

lanitochka17 · 2024-06-21T13:01:40Z

We think that this bug might be related to #wave-collect - Release 1

bernhardoj · 2024-06-21T13:57:26Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

We can still select pending-delete distance rate and will result in an error when submitted.

What is the root cause of that problem?

We are not filtering any distance rate that is pending-delete when showing the rate list.

App/src/pages/iou/request/step/IOURequestStepDistanceRate.tsx

Lines 62 to 72 in 68374a5

    
           const sections = Object.values(rates).map((rate) => { 
        
               const rateForDisplay = DistanceRequestUtils.getRateForDisplay(rate.unit, rate.rate, rate.currency, translate, toLocaleDigit); 
        
               return { 
        
                   text: rate.name ?? rateForDisplay, 
        
                   alternateText: rate.name ? rateForDisplay : '', 
        
                   keyForList: rate.customUnitRateID, 
        
                   value: rate.customUnitRateID, 
        
                   isSelected: lastSelectedRateID ? lastSelectedRateID === rate.customUnitRateID : !!(rate.name === CONST.CUSTOM_UNITS.DEFAULT_RATE), 
        
               }; 
        
           });

What changes do you think we should make in order to solve the problem?

Filter out any pending-delete rate. To do that:

Return the pendingAction from getMileageRates

App/src/libs/DistanceRequestUtils.ts

Lines 59 to 65 in 68374a5

    
           mileageRates[rateID] = { 
        
               rate: rate.rate, 
        
               currency: rate.currency, 
        
               unit: distanceUnit.attributes.unit, 
        
               name: rate.name, 
        
               customUnitRateID: rate.customUnitRateID, 
        
           };

pendingAction: rate.pendingAction,

Filter out rate with pending action of delete.

App/src/pages/iou/request/step/IOURequestStepDistanceRate.tsx

Line 62 in 68374a5

const sections = Object.values(rates).map((rate) => {

.filter(rate => rate.pendingAction !== 'delete')

Krishna2323 · 2024-06-21T13:59:51Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Distance rates- Deleted distance rate is not disabled when submitting distance expense offline

What is the root cause of that problem?

We don't have any check for disabled rates on IOURequestStepDistanceRate page.

App/src/pages/iou/request/step/IOURequestStepDistanceRate.tsx

Lines 62 to 72 in 68374a5

    
           const sections = Object.values(rates).map((rate) => { 
        
               const rateForDisplay = DistanceRequestUtils.getRateForDisplay(rate.unit, rate.rate, rate.currency, translate, toLocaleDigit); 
        
               return { 
        
                   text: rate.name ?? rateForDisplay, 
        
                   alternateText: rate.name ? rateForDisplay : '', 
        
                   keyForList: rate.customUnitRateID, 
        
                   value: rate.customUnitRateID, 
        
                   isSelected: lastSelectedRateID ? lastSelectedRateID === rate.customUnitRateID : !!(rate.name === CONST.CUSTOM_UNITS.DEFAULT_RATE), 
        
               }; 
        
           });

What changes do you think we should make in order to solve the problem?

We need to first return pendingAction field from getMileageRates.

        mileageRates[rateID] = {
            rate: rate.rate,
            currency: rate.currency,
            unit: distanceUnit.attributes.unit,
            name: rate.name,
            customUnitRateID: rate.customUnitRateID,
            pendingAction: rate.pendingAction,
        };

Then add isDisabled and pendingAction.

        return {
            text: rate.name ?? rateForDisplay,
            alternateText: rate.name ? rateForDisplay : '',
            keyForList: rate.customUnitRateID,
            value: rate.customUnitRateID,
            isSelected: lastSelectedRateID ? lastSelectedRateID === rate.customUnitRateID : !!(rate.name === CONST.CUSTOM_UNITS.DEFAULT_RATE),
            isDisabled: rate.pendingAction === 'delete',
            pendingAction: rate.pendingAction,
        };

What alternative solutions did you explore? (Optional)

If we also need to grey out the option when updated offline, we nee to also return pendingFields from getMileageRates and update the pendingAction property like we do in PolicyDistanceRatesPage.

App/src/pages/workspace/distanceRates/PolicyDistanceRatesPage.tsx

Lines 113 to 118 in 68374a5

    
           pendingAction: 
        
               value.pendingAction ?? 
        
               value.pendingFields?.rate ?? 
        
               value.pendingFields?.enabled ?? 
        
               value.pendingFields?.currency ?? 
        
               (policy?.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD ? policy?.pendingAction : undefined),

    const sections = Object.values(rates).map((rate) => {
        const rateForDisplay = DistanceRequestUtils.getRateForDisplay(rate.unit, rate.rate, rate.currency, translate, toLocaleDigit);

        return {
            text: rate.name ?? rateForDisplay,
            alternateText: rate.name ? rateForDisplay : '',
            keyForList: rate.customUnitRateID,
            value: rate.customUnitRateID,
            isSelected: lastSelectedRateID ? lastSelectedRateID === rate.customUnitRateID : !!(rate.name === CONST.CUSTOM_UNITS.DEFAULT_RATE),
            isDisabled: rate.pendingAction === 'delete',
            pendingAction:
                rate.pendingAction ??
                rate.pendingFields?.rate ??
                rate.pendingFields?.enabled ??
                rate.pendingFields?.currency ??
                (policy?.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD ? policy?.pendingAction : undefined),
        };
    });

Krishna2323 · 2024-06-21T14:10:00Z

Proposal Updated

Removed redundant code.

Krishna2323 · 2024-06-21T14:13:18Z

Proposal Updated

We also need to add pendingAction: rate.pendingAction for correct styling.

Krishna2323 · 2024-06-21T14:19:09Z

Proposal Updated

Added alternative

OfstadC · 2024-06-21T21:01:41Z

Following this Slack thread before proceeding

OfstadC · 2024-06-24T13:20:42Z

@mallenexpensify I wonder if the Offline Distance request issues should be consolidated since they might have the same/similar solution? 🤔

mallenexpensify · 2024-06-25T00:06:46Z

Asking about consolidating, should have an update tomorrow 🤞

OfstadC · 2024-06-26T16:25:27Z

Thanks Matt!

OfstadC · 2024-06-27T18:53:09Z

Any update @mallenexpensify ? 😃

mallenexpensify · 2024-06-28T00:11:29Z

@paultsimura can you please comment so I can assign to you?
Created a tracking issue for 'offline distance' issues.

[Tracking] Offline Distance issues #44582

paultsimura · 2024-06-28T06:00:53Z

👋🏼

OfstadC · 2024-07-01T15:57:46Z

@mallenexpensify Is there any action I need to take here?

mallenexpensify · 2024-07-02T23:35:16Z

No @OfstadC , @paultsimura is going to to plan to holistically address offline distance bugs. He'll comment here with an update once he's reviewed all issues (and either raise a PR or recommend making the issue external)

melvin-bot · 2024-07-04T18:12:12Z

@OfstadC Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

paultsimura · 2024-07-05T16:09:47Z

@mallenexpensify I have a quite simple fix for this – if I put up a PR, who's going to be the reviewer?

melvin-bot · 2024-07-09T15:59:37Z

📣 @paultsimura 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

melvin-bot · 2024-07-19T19:26:37Z

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot · 2024-07-19T19:26:40Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.9-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

fix: Optimistically disable the distance rate on removal #45146

If no regressions arise, payment will be issued on 2024-07-26. 🎊

For reference, here are some details about the assignees on this issue:

@paultsimura requires payment automatic offer (Contributor)
@shubham1206agra requires payment automatic offer (Reviewer)

melvin-bot · 2024-07-19T19:26:42Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@paultsimura / @shubham1206agra] The PR that introduced the bug has been identified. Link to the PR:
[@paultsimura / @shubham1206agra] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@paultsimura / @shubham1206agra] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@paultsimura / @shubham1206agra] Determine if we should create a regression test for this bug.
[@paultsimura / @shubham1206agra] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@OfstadC] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

OfstadC · 2024-07-26T15:13:51Z

@shubham1206agra I think you may need to accept the offer in Upwork? It's not showing an option to Approve payment

OfstadC · 2024-07-26T15:14:21Z

Payment Summary:

Paid @paultsimura $250 via Upwork
Matt A. paid @shubham1206agra $250 via Upwork.

shubham1206agra · 2024-07-26T18:15:05Z

@OfstadC Offer accepted

mallenexpensify · 2024-07-26T22:42:48Z

@shubham1206agra paid via Upwork, payment confirmation updated above. @shubham1206agra plz complete the BZ checklist above.

melvin-bot · 2024-07-29T18:08:49Z

@arosiclair, @OfstadC, @paultsimura, @shubham1206agra Whoops! This issue is 2 days overdue. Let's get this updated quick!

arosiclair · 2024-07-30T13:54:31Z

@shubham1206agra I think you still need to complete the checklist

shubham1206agra · 2024-07-30T15:20:01Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@shubham1206agra] The PR that introduced the bug has been identified. Link to the PR: feat: policy distance rates edit #38237
[@shubham1206agra] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/38237/files#r1697154647
[@shubham1206agra] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: NA
[@shubham1206agra] Determine if we should create a regression test for this bug. No
[@shubham1206agra] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@OfstadC] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

mallenexpensify · 2024-07-30T23:59:07Z

@shubham1206agra do we want a test case for this? If so, please provide the steps. If not, please provide reasoning why not. Thx

shubham1206agra · 2024-07-31T01:07:57Z

@mallenexpensify We don't need any test steps here as this was an edge case that we missed during initial implementation, and the bug should not happen again in future.

melvin-bot · 2024-07-31T18:07:03Z

@arosiclair, @OfstadC, @paultsimura, @shubham1206agra Huh... This is 4 days overdue. Who can take care of this?

lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jun 21, 2024

melvin-bot bot assigned OfstadC Jun 21, 2024

OfstadC mentioned this issue Jun 21, 2024

[HOLD #44582] Workspace - Distance rate enabled offline when creating the workspace online not grayed #44163

Closed

6 tasks

melvin-bot bot added the Overdue label Jun 24, 2024

melvin-bot bot removed the Overdue label Jun 24, 2024

mallenexpensify mentioned this issue Jun 28, 2024

[Tracking] Offline Distance issues #44582

Closed

5 tasks

mallenexpensify changed the title ~~Distance rates- Deleted distance rate is not disabled when submitting distance expense offline~~ [Hold] Distance rates- Deleted distance rate is not disabled when submitting distance expense offline Jun 28, 2024

melvin-bot bot added the Overdue label Jul 1, 2024

melvin-bot bot removed the Overdue label Jul 1, 2024

melvin-bot bot added the Overdue label Jul 3, 2024

paultsimura mentioned this issue Jul 10, 2024

fix: Optimistically disable the distance rate on removal #45146

Merged

48 tasks

melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Jul 10, 2024

melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jul 19, 2024

melvin-bot bot changed the title ~~[$250] [Hold] Distance rates- Deleted distance rate is not disabled when submitting distance expense offline~~ [HOLD for payment 2024-07-26] [$250] [Hold] Distance rates- Deleted distance rate is not disabled when submitting distance expense offline Jul 19, 2024

melvin-bot bot removed the Reviewing Has a PR in review label Jul 19, 2024

melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jul 26, 2024

melvin-bot bot added the Overdue label Jul 29, 2024

shubham1206agra mentioned this issue Jul 30, 2024

feat: policy distance rates edit #38237

Merged

50 tasks

mallenexpensify closed this as completed Jul 31, 2024

melvin-bot bot removed the Overdue label Jul 31, 2024

github-project-automation bot moved this to Done in [#whatsnext] #wave-collect Jul 31, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HOLD for payment 2024-07-26] [$250] [Hold] Distance rates- Deleted distance rate is not disabled when submitting distance expense offline #44154

[HOLD for payment 2024-07-26] [$250] [Hold] Distance rates- Deleted distance rate is not disabled when submitting distance expense offline #44154

lanitochka17 commented Jun 21, 2024 •

edited by melvin-bot bot

Loading

melvin-bot bot commented Jun 21, 2024

lanitochka17 commented Jun 21, 2024

lanitochka17 commented Jun 21, 2024

bernhardoj commented Jun 21, 2024

Krishna2323 commented Jun 21, 2024 •

edited

Loading

Krishna2323 commented Jun 21, 2024

Krishna2323 commented Jun 21, 2024

Krishna2323 commented Jun 21, 2024

OfstadC commented Jun 21, 2024

OfstadC commented Jun 24, 2024

mallenexpensify commented Jun 25, 2024

OfstadC commented Jun 26, 2024

OfstadC commented Jun 27, 2024

mallenexpensify commented Jun 28, 2024

paultsimura commented Jun 28, 2024

OfstadC commented Jul 1, 2024

mallenexpensify commented Jul 2, 2024

melvin-bot bot commented Jul 4, 2024

paultsimura commented Jul 5, 2024

melvin-bot bot commented Jul 9, 2024

melvin-bot bot commented Jul 19, 2024

melvin-bot bot commented Jul 19, 2024

melvin-bot bot commented Jul 19, 2024

OfstadC commented Jul 26, 2024

OfstadC commented Jul 26, 2024 •

edited by mallenexpensify

Loading

shubham1206agra commented Jul 26, 2024

mallenexpensify commented Jul 26, 2024

melvin-bot bot commented Jul 29, 2024

arosiclair commented Jul 30, 2024

shubham1206agra commented Jul 30, 2024

mallenexpensify commented Jul 30, 2024

shubham1206agra commented Jul 31, 2024

melvin-bot bot commented Jul 31, 2024

[HOLD for payment 2024-07-26] [$250] [Hold] Distance rates- Deleted distance rate is not disabled when submitting distance expense offline #44154

[HOLD for payment 2024-07-26] [$250] [Hold] Distance rates- Deleted distance rate is not disabled when submitting distance expense offline #44154

Comments

lanitochka17 commented Jun 21, 2024 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

melvin-bot bot commented Jun 21, 2024

lanitochka17 commented Jun 21, 2024

lanitochka17 commented Jun 21, 2024

bernhardoj commented Jun 21, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Krishna2323 commented Jun 21, 2024 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Krishna2323 commented Jun 21, 2024

Proposal Updated

Krishna2323 commented Jun 21, 2024

Proposal Updated

Krishna2323 commented Jun 21, 2024

Proposal Updated

OfstadC commented Jun 21, 2024

OfstadC commented Jun 24, 2024

mallenexpensify commented Jun 25, 2024

OfstadC commented Jun 26, 2024

OfstadC commented Jun 27, 2024

mallenexpensify commented Jun 28, 2024

paultsimura commented Jun 28, 2024

OfstadC commented Jul 1, 2024

mallenexpensify commented Jul 2, 2024

melvin-bot bot commented Jul 4, 2024

paultsimura commented Jul 5, 2024

melvin-bot bot commented Jul 9, 2024

melvin-bot bot commented Jul 19, 2024

melvin-bot bot commented Jul 19, 2024

melvin-bot bot commented Jul 19, 2024

OfstadC commented Jul 26, 2024

OfstadC commented Jul 26, 2024 • edited by mallenexpensify Loading

shubham1206agra commented Jul 26, 2024

mallenexpensify commented Jul 26, 2024

melvin-bot bot commented Jul 29, 2024

arosiclair commented Jul 30, 2024

shubham1206agra commented Jul 30, 2024

mallenexpensify commented Jul 30, 2024

shubham1206agra commented Jul 31, 2024

melvin-bot bot commented Jul 31, 2024

lanitochka17 commented Jun 21, 2024 •

edited by melvin-bot bot

Loading

Krishna2323 commented Jun 21, 2024 •

edited

Loading

OfstadC commented Jul 26, 2024 •

edited by mallenexpensify

Loading