[HOLD for payment 2024-07-25] [QBO Export] [$250] Implement manual report exports

[arosiclair]

Part of QBO Export and Error Handling in NewDot

Main issue: https://github.com/Expensify/Expensify/issues/350150
Doc section: https://docs.google.com/document/d/1aQl-AK_F6IqszWYG2aEllTsD5x3h4b8Zu0XEG0LuQ08/edit#heading=h.xw0s9oqvo44s
Project: #wave-collect

Feature Description

As described in the doc, we need to

• Add new exportToIntegration and markAsManuallyExported actions
• Add a new Export menu item to the report details page
• Create a new ReportDetailsExportPage with "Export" and "Mark as exported" options
• Update ReportPreview actions to show export options
• Update the MoneyReportHeader to show export options

Manual Test Steps

Prerequisites

• Collect workspace with an admin and member
• Setup QBO integration connection

Steps

1. Log into QBO and disconnect the Expensify app (Menu > Apps > Overview > Expensify 3-dot menu > Disconnect)
2. Log into NewDot as the admin
3. Verify there's a RBR on the path: Avatar > Workspaces > [Workspace name] > Accounting > QBO
4. Verify a red error message appears on the connection explaining the issue
5. Select QBO’s 3-dot menu
6. Verify there’s a “Enter credentials” option
7. Select “Enter credentials”
8. Verify a new window opens to log into QBO

Automated Tests

Prerequisites

• Collect workspace with an admin and member
• Setup QBO integration connection
• An approved expense report that failed to export

QBO

1. Open the 3-dot menu on the failed report
2. Verify there’s an “Export” Item
3. Select it
4. Verify there are “Quickbooks Online” and “Mark as manually entered” options
5. Select Quickbooks Online
6. Verify
7. A system message “exported to QuickBooks Online” is added to the report
8. The red dot on the report in the LHN is removed

Mark as exported

1. Open the 3-dot menu on the failed report
2. Verify there’s an “Export” Item
3. Select it
4. Verify there’s a “Mark as manually entered” option and select it
5. Verify
6. A system message “marked this report as manually exported to QuickBooks Online” is added to the report
7. The red dot on the report in the LHN is removed

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~012f33d4c08ab8cd9c
• Upwork Job ID: 1803471658259345111
• Last Price Increase: 2024-06-19
• Automatic offers:
• hungvu193 | Contributor | 102807841

Issue Owner

Current Issue Owner: @lschurr

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~012f33d4c08ab8cd9c

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann (External)

[melvin-bot]

Triggered auto assignment to @lschurr (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[melvin-bot]

📣 @hungvu193 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[trjExpensify]

Hans is taking the C+ on this as part of the QBO export project. I believe @kosmydel will be implementing this one as well.

[kosmydel]

Commenting for assignment :)

[trjExpensify]

Donezo!

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.8-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [QBO Export] Manual exports #44170

If no regressions arise, payment will be issued on 2024-07-25. 🎊

For reference, here are some details about the assignees on this issue:

• @hungvu193 requires payment automatic offer (Contributor)
• @kosmydel does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@hungvu193] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@lschurr] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[hungvu193]

Regression Test:

Prerequisites:

• Collect workspace with an admin and member
• Setup QBO integration connection

Test 1

1. Open the report details (click the carret in the header) on the failed report (See [QBO Export] Manual exports #44170 (comment) to make a failed report).
2. Verify there’s an “Export” Item button.
3. Select it
4. Verify there’s a “Mark as manually entered” option and select it
5. Verify A system message “marked this report as manually exported to QuickBooks Online” is added to the report and the red dot on the report in the LHN is removed
6. Click on the "Export" item and "Mark as manually entered" again, verify the "reports have already been exported" modal is displayed.

Tests 2:

1. Turn off auto sync in Workspace -> Accounting -> Advanced.
2. Create a new expense in the policy.
3. Pay expense elsewhere.
4. A Export button should appear in the report preview and report header.
5. Click on the "Export" button in the report preview
6. Verify everything works as expected.

Do we 👍 or 👎 ?

[hungvu193]

Feel free to close this one. I'll request on ND later

[lschurr]

Payment summary:

• Contributor: @kosmydel (no payment needed)
• Reviewer: @hungvu193 $250 (via newdot requests)

[hungvu193]

Requested on ND

[JmillsExpensify]

$250 approved for @hungvu193