Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PAID] [Free trial] Implement and show Free Trial banner and badges in the App after Free Trial starts #43672

Closed
MitchExpensify opened this issue Jun 13, 2024 · 18 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item.

Comments

@MitchExpensify MitchExpensify added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jun 13, 2024
Copy link

melvin-bot bot commented Jun 13, 2024

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@MitchExpensify MitchExpensify moved this to Release 2: Summer 2024 (Aug) in [#whatsnext] #wave-collect Jun 13, 2024
@MitchExpensify MitchExpensify added NewFeature Something to build that is a new item. and removed Bug Something is broken. Auto assigns a BugZero manager. labels Jun 13, 2024
Copy link

melvin-bot bot commented Jun 13, 2024

Current assignee @strepanier03 is eligible for the NewFeature assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Jun 13, 2024
@pac-guerreiro
Copy link
Contributor

Hi! I’m Pedro Guerreiro from Callstack - expert contributor group. I’d like to work on this task!

@trjExpensify
Copy link
Contributor

Assigned you @pac-guerreiro, also taking the issue off hold as the PR for #43668 is deployed to staging.

@trjExpensify trjExpensify changed the title [Free trial] HOLD on #43668 - Implement and show Free Trial banner and badges in the App after Free Trial starts [Free trial] Implement and show Free Trial banner and badges in the App after Free Trial starts Jun 21, 2024
@hoangzinh
Copy link
Contributor

I can help to review the PR.

@pac-guerreiro
Copy link
Contributor

@trjExpensify @hoangzinh PR is ready now - #44371 😄

@trjExpensify
Copy link
Contributor

Wahoo, let's go!

@chiragsalian chiragsalian self-assigned this Jul 2, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jul 10, 2024
@melvin-bot melvin-bot bot changed the title [Free trial] Implement and show Free Trial banner and badges in the App after Free Trial starts [HOLD for payment 2024-07-17] [Free trial] Implement and show Free Trial banner and badges in the App after Free Trial starts Jul 10, 2024
Copy link

melvin-bot bot commented Jul 10, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jul 10, 2024
Copy link

melvin-bot bot commented Jul 10, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.5-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-07-17. 🎊

For reference, here are some details about the assignees on this issue:

  • @rojiphil requires payment (Needs manual offer from BZ)
  • @hoangzinh requires payment (Needs manual offer from BZ)
  • @pac-guerreiro does not require payment (Contractor)

Copy link

melvin-bot bot commented Jul 10, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@rojiphil / @hoangzinh] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@strepanier03] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Jul 15, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-07-17] [Free trial] Implement and show Free Trial banner and badges in the App after Free Trial starts [HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [Free trial] Implement and show Free Trial banner and badges in the App after Free Trial starts Jul 15, 2024
Copy link

melvin-bot bot commented Jul 15, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.6-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-07-22. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Jul 15, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@rojiphil / @hoangzinh] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@strepanier03] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jul 16, 2024
@strepanier03
Copy link
Contributor

Offers were sent out and once they're accepted and the reg test step above is complete I can pay them out and close the contracts. Will check again tomorrow.

@hoangzinh
Copy link
Contributor

Accepted. Thanks @strepanier03

@rojiphil
Copy link
Contributor

@strepanier03 No payment to me as I did not get involved here.

@strepanier03
Copy link
Contributor

Thanks for the heads up @rojiphil, I'll withdraw that offer.

@strepanier03
Copy link
Contributor

I've paid @hoangzinh and canceled the contract I mistakenly sent to @rojiphil.

@strepanier03 strepanier03 changed the title [HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [Free trial] Implement and show Free Trial banner and badges in the App after Free Trial starts [PAID] [Free trial] Implement and show Free Trial banner and badges in the App after Free Trial starts Jul 19, 2024
@github-project-automation github-project-automation bot moved this from Release 2: Summer 2024 (Aug) to Done in [#whatsnext] #wave-collect Jul 19, 2024
@hoangzinh hoangzinh removed their assignment Jul 24, 2024
@hoangzinh
Copy link
Contributor

Oops, sorry I missed clicking on "unassign" me. @strepanier03 can you help add me back? 😭

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item.
Projects
No open projects
Archived in project
Development

No branches or pull requests

7 participants